From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12503: 24.2.50; `bookmark-write-file' should bind `print-circle' to t Date: Mon, 24 Sep 2012 09:11:36 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348503139 23001 80.91.229.3 (24 Sep 2012 16:12:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Sep 2012 16:12:19 +0000 (UTC) To: 12503@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 24 18:12:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGBGf-0001MB-Ao for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 18:12:21 +0200 Original-Received: from localhost ([::1]:46792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGa-0003Kr-FH for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 12:12:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGS-0003K9-U8 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:12:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGBGR-0005yY-QL for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:12:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGR-0005yU-N4 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:12:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TGBIH-0003YB-W1 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Sep 2012 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134850323813628 (code B ref -1); Mon, 24 Sep 2012 16:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Sep 2012 16:13:58 +0000 Original-Received: from localhost ([127.0.0.1]:53408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGBID-0003Xk-Bn for submit@debbugs.gnu.org; Mon, 24 Sep 2012 12:13:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51668) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGBIA-0003Xb-RG for submit@debbugs.gnu.org; Mon, 24 Sep 2012 12:13:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGBGI-0005xW-Uj for submit@debbugs.gnu.org; Mon, 24 Sep 2012 12:11:59 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:56330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGI-0005xS-RC for submit@debbugs.gnu.org; Mon, 24 Sep 2012 12:11:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGH-0003JF-ME for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:11:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGBGC-0005wa-W4 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:11:57 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:49711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGBGC-0005wT-P7 for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 12:11:52 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8OGBois007755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Sep 2012 16:11:51 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8OGBoLr013409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 24 Sep 2012 16:11:50 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8OGBoWQ014268 for ; Mon, 24 Sep 2012 11:11:50 -0500 Original-Received: from dradamslap1 (/10.159.184.43) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 Sep 2012 09:11:49 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2ab0V0dcONe3Q6RfmnXhedeA7S3Q== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64846 Archived-At: Users can define their own bookmark types, which can store anything at all in bookmark records, that is, any Lisp objects. Such objects can contain circularities: one part referring to another part or to the whole - IOW circular lists. When `bookmark-write-file' writes a bookmark list to the bookmark file, it takes care to bind `print-length' and `print-level' to nil, but it does yet not bind `print-circle' to t. It should do that as well. The result currently is that a user's bookmark file can be corrupted, becoming unreadable because it contains invalid Lisp `read' syntax. I have seen this a couple of times now, with users of Bookmark+. Bookmark+ does use bookmarks that have circular structure, and it saves them correctly by binding `print-circle' to t. A user can read such a bookmark file into vanilla Emacs, and s?he can use the bookmarks there. But if s?he then saves the file again, in vanilla Emacs, the result is invalid Lisp. The file cannot be read (in either vanilla Emacs or Bookmark+). The user has lost bookmarks and can recuperate them only by hand-editing the corrupted file, which is laborious and error prone. The simple change of binding `print-circle' to t will have no negative effect on bookmark.el behavior, and it will solve the problem, preventing data loss if users have defined bookmark structures that are circular. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-09-17 on MARVIN Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'