From: "Kirill A. Korinsky" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 50534@debbugs.gnu.org
Subject: bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS
Date: Tue, 14 Sep 2021 14:54:59 +0200 [thread overview]
Message-ID: <CE3DCD65-3103-455A-ADB6-53724A7DB6AC@korins.ky> (raw)
In-Reply-To: <YUCR4ZPVW5ZFXvjy@idiocy.org>
[-- Attachment #1.1: Type: text/plain, Size: 1226 bytes --]
Hey,
I haven't yet tested your last patch.
Right now I'm on 1e83d04214f27a79a4d4841772da946e24cbf21d as local root and it starts to have wired visual things like that:
Before your last patches everything was fine.
--
wbr, Kirill
> On 14. Sep 2021, at 14:13, Alan Third <alan@idiocy.org> wrote:
>
> On Tue, Sep 14, 2021 at 01:26:44PM +0200, Kirill A. Korinsky wrote:
>> I have one bad news: it still exists but less often.
>>
>> I can reproduce it one time in 10 starts of my emacs.
>
> The *only* place that should modify FRAME_EXTERNAL_TOOL_BAR is
> ns_set_tool_bar_lines, which should be called *every time* the number
> of lines is changed.
>
> It would be nice to know what the value of FRAME_EXTERNAL_TOOL_BAR and
> tool-bar-lines are when the toolbar is wrongly visible, because I
> can't find a single location in the code that sets the visibility
> without first checking FRAME_EXTERNAL_TOOL_BAR, and it should *always*
> be set by ns_set_tool_bar_lines.
>
> *sigh* I've no idea.
>
> Attached is the nuclear option. If this doesn't work then
> FRAME_EXTERNAL_TOOL_BAR is wrong.
>
> --
> Alan Third
> <0001-A-further-fix-for-toolbar-visibility-problems-on-mac.patch>
[-- Attachment #1.2.1: Type: text/html, Size: 2838 bytes --]
[-- Attachment #1.2.2: Screenshot 2021-09-14 at 14.52.33.png --]
[-- Type: image/png, Size: 15607 bytes --]
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-14 12:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 0:29 bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.50534.B.16314065846903.ack@debbugs.gnu.org>
2021-09-12 9:25 ` bug#50534: Acknowledgement (28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS) Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-12 11:48 ` bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS Alan Third
2021-09-12 12:54 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-12 15:33 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-12 15:44 ` Alan Third
2021-09-12 16:40 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-12 19:43 ` Alan Third
2021-09-12 19:52 ` Alan Third
2021-09-12 20:14 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-12 20:35 ` Alan Third
2021-09-12 21:02 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 18:44 ` Alan Third
2021-09-13 18:52 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 18:54 ` Alan Third
2021-09-13 18:57 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 19:11 ` Alan Third
2021-09-13 20:42 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 22:21 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 23:25 ` Alan Third
2021-09-14 0:05 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 9:21 ` Alan Third
2021-09-14 11:26 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 12:13 ` Alan Third
2021-09-14 12:54 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-14 14:17 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 14:35 ` Alan Third
2021-09-14 14:43 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-17 17:26 ` Alan Third
2021-09-26 10:56 ` Alan Third
2021-09-26 16:23 ` Mattias Engdegård
2021-09-27 10:10 ` Alan Third
2021-09-28 19:00 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-28 19:14 ` Alan Third
2021-09-29 10:53 ` Kirill A. Korinsky via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 16:07 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE3DCD65-3103-455A-ADB6-53724A7DB6AC@korins.ky \
--to=bug-gnu-emacs@gnu.org \
--cc=50534@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=kirill@korins.ky \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.