From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Thu, 29 Jul 2021 13:55:48 -0400 Message-ID: References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> <834kcetmly.fsf@gnu.org> <831r7itjc8.fsf@gnu.org> <24808548-23F4-4068-877E-37C7190A02B0@gmail.com> <83wnpas1q7.fsf@gnu.org> <83k0l9rvf5.fsf@gnu.org> <83fsvxrszr.fsf@gnu.org> <83czr1rpei.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, Stephen Leake , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 29 19:57:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9AHK-0004cj-66 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 19:57:06 +0200 Original-Received: from localhost ([::1]:46632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9AHI-0000Fi-SG for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 13:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9AG8-0006Dx-VY for emacs-devel@gnu.org; Thu, 29 Jul 2021 13:55:52 -0400 Original-Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:47044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9AG7-0007kH-FU; Thu, 29 Jul 2021 13:55:52 -0400 Original-Received: by mail-qk1-x72e.google.com with SMTP id c9so6774635qkc.13; Thu, 29 Jul 2021 10:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7PfUy5JM7ETTd1GIiv9comkhSOba03u5i1x0i/QRs2E=; b=sTzxdHtzNzrNtWvJxk7w7DrxacfF1dt2eUJWgrstmYlBHy/wP9G6Sv5c40/NwYyyPk V/9+GAC1vJo6wfQ+DNAHegEw28WLgUVryBYpurcIzsic9s+EavsJcZF//HG1sc2TP6PK 3EiqVza7YblhCfiaEUc2dGNlN3iUJb4bOpWNIftYPHG0ENtyFktiZU+vthLS8FjYFng3 IlStQ8SLIkYUh9eOyEauNBNCNgnhy0/KnHi6Wpo8wDK9RRr7uA9VgPGzJ4vtRN8i5Eg7 iWzJaaVyCT58VZ0w1ktRhX/KIpzjNqwvPC2eTM1BVvTFiz60E1OhdTbjTyjqlsjKK6/M ze5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7PfUy5JM7ETTd1GIiv9comkhSOba03u5i1x0i/QRs2E=; b=rYZ1LvlAdsgOtuSGRYYqNddbvw+SBnczpuoKmrKbwsR/gpqbjPqCMM1UZpK7UQxyM9 LiwpY2pxrNw5STnPphu7VWYEZ+uhRQT1fetoQgBa+yqg6lq9onvCGGZ3wi6TJJjcjuMY vdQ6hKICrTdae63AAKc11v43cXmiYiREjnku5OgMPrteIEVNEHzCszNixCYFc6XxHonu 2vJtiOjJ5kkW/TOnK1ZmKQh/OdqHE/MskOQCS+bOtHEU79QrxLrFbeqJ0cp0JxxxNc1m pz7Fyyu6ADW1sWPAG3JyZkSbVw8WgNzQ3ahS+ieE4dyPIwm5hHWXCuZUF2nO2mHkk4lQ +IZw== X-Gm-Message-State: AOAM533gBIuhAJiA8RSEa+FAzOF2ErXvcN7rtoqAEK5E3jfaskokc7/4 D5hqyICHIfbcWE6N6+TwguJ3enZTYM+JiQ== X-Google-Smtp-Source: ABdhPJwF9DfGLXstQHaMmKKpNhxYwkK/HSTIbWp9ZU5BToG5joVFqf+omRQ+l/8C6BUMrUuHHKO8aQ== X-Received: by 2002:a05:620a:15c7:: with SMTP id o7mr6379230qkm.33.1627581349584; Thu, 29 Jul 2021 10:55:49 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com (2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com. [2603:7080:302:635e:540d:2222:3fe9:1314]) by smtp.gmail.com with ESMTPSA id 141sm2092009qki.15.2021.07.29.10.55.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 10:55:49 -0700 (PDT) In-Reply-To: <83czr1rpei.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=casouri@gmail.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271796 Archived-At: >>=20 >> Ideally, tree-sitter only sees the narrowed region because everytime = it is called, the buffer is narrowed. However, tree-sitter doesn=E2=80=99t= work that way, it needs to be updated when user edits the buffer, when = the buffer is widened. If your goal is give lisp control of what = tree-sitter sees, we can=E2=80=99t just give tree-sitter the whole = buffer whenever the user makes some change. >=20 > In the above scenario, then the Lisp program that narrows the buffer > should figure out how to do that correctly. The call to TS will then > express the changes in the narrowed region only. >=20 >>> Anyway, you are once again bothered by a scenario that should not >>> happen at all: a Lisp program should not call TS first with, then >>> without narrowing (or the other way around). I don't see why such >>> situation should happen, and if they do, the Lisp programs which = need >>> them will have to figure out what to do and how. >>=20 >> Even if lisp always call tree-sitter with narrowing, we still need to = update tree-sitter when the buffer is widened. >=20 > No, I don't think so. Why would we need to? =46rom the TS POV the = text > outside the restriction doesn't exist because it never sees it. Actually, that sounds like how it works in my code right now. After the = last few exchanges, I still have the feeling that we are not on the same = page. Could you have a look at the code in ts_ensure_parsed and = ts_record_change, and see if it aligns with what you consider to be the = right thing? If you have read them already and think you understand what = are they doing, could you tell me how exactly should these two functions = behave, in your opinion? Thanks. Yuan=