From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Date: Tue, 18 Aug 2020 16:11:02 +0200 Message-ID: References: <83lfidgtc7.fsf@gnu.org> <838sedgq2x.fsf@gnu.org> <02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org> <20200817195610.GA70682@breton.holly.idiocy.org> <3F71EF82-A143-4E3A-AEF3-8A236091891D@acm.org> <20200818084306.GA89999@breton.holly.idiocy.org> <83eeo4f8gs.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13814"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42904@debbugs.gnu.org, Alan Third To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 18 16:44:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k82qJ-0003W1-1v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 16:44:03 +0200 Original-Received: from localhost ([::1]:47438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k82qH-00011L-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 10:44:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k82LK-0005Lc-9Y for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k82LJ-0007ZR-R1 for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k82LJ-000234-Mk for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Aug 2020 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42904-submit@debbugs.gnu.org id=B42904.15977598717799 (code B ref 42904); Tue, 18 Aug 2020 14:12:01 +0000 Original-Received: (at 42904) by debbugs.gnu.org; 18 Aug 2020 14:11:11 +0000 Original-Received: from localhost ([127.0.0.1]:36567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82KU-00021j-Tx for submit@debbugs.gnu.org; Tue, 18 Aug 2020 10:11:11 -0400 Original-Received: from mail154c50.megamailservers.eu ([91.136.10.164]:41242 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82KR-00021Y-S4 for 42904@debbugs.gnu.org; Tue, 18 Aug 2020 10:11:10 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1597759865; bh=6z5mp3NjIeBrcaRk9EFjMuVDLKP90MpS3TiOvDoElzU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=pTAFgxl89iFNga74QlA/qoxKwDqQpxSZb8HjoT4rAwaZ1znsd6eZxbEkZu/yyXqJ2 oPTIM/EfW4JMPcyUHd4COdwo15NXTK1yWPXwiNHzntmRSBVAEyzTGgjNpP3sFosTqh Uwk+/3nNE8VW9bUc3xe3+hqTVDo7FrdlqBNoHAYE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 07IEB2Vk012805; Tue, 18 Aug 2020 14:11:04 +0000 In-Reply-To: <83eeo4f8gs.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F28.5F3BE179.00A8, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NoevjPVJ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=mhFmQku-uZFPWoOYklsA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185491 Archived-At: 18 aug. 2020 kl. 14.24 skrev Eli Zaretskii : > It isn't wrong (and there's no need to worry about alignment in this > case, AFAIK). Do you mean that SDATA is guaranteed to be aligned, or that no NS = platforms that Emacs runs on (or is likely to run on in the near future, = such as macOS on arm64) trap on unaligned? > Thanks, but I don't think we should modify the :default-char attribute > of the UTF-* encodings as part of this change. It's a separate issue, > and is a backward-incompatible change of sorts. For instance, we > should consider what this will do to display on TTY frames that don't > support Unicode. So I think we should discuss this issue separately > before we make such a change. Yes, we can certainly make it a separate change. All bug fixes are = backward-incompatible in some respect; it is not reasonable to depend on = non-Unicode characters being translated to spaces when converted to = UTF-16 since that is neither documented nor reasonably expected = behaviour. > Why is it a problem to display a space instead of invalid bytes in > this case? A problem is not necessary for a change to be desirable. The Unicode = replacement character clearly indicates that something could not be = encoded correctly, and the exact position for it; it's universally = recognised and valuable for users and developers alike. Space is the = default value for :default-char, and that it isn't U+FFFD for UTF-16 (or = other Unicode encodings) is a clear bug, since that is the correct = character to use for that purpose. My guess is that space was chosen as default because it's a character = that occurs in all coding systems, but it is clearly wrong for UTF-16. = 'us-ascii' uses '?' for :default-char, which is a better character in = that repertoire.