From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Wed, 30 Nov 2022 02:22:06 -0800 Message-ID: References: <8a2af962-4210-d01e-68d4-92d434dd2f9b@secure.kjonigsen.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59691@debbugs.gnu.org, eliz@gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 11:23:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0KFS-0004Nr-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 11:23:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0KFE-0003fl-WD; Wed, 30 Nov 2022 05:23:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0KF8-0003bS-N8 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:23:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0KF4-0001P4-HB for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:23:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0KF4-00072U-D9 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:23:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <8a2af962-4210-d01e-68d4-92d434dd2f9b@secure.kjonigsen.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 10:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.166980373627039 (code B ref 59691); Wed, 30 Nov 2022 10:23:02 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 30 Nov 2022 10:22:16 +0000 Original-Received: from localhost ([127.0.0.1]:60068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KEJ-000723-RC for submit@debbugs.gnu.org; Wed, 30 Nov 2022 05:22:16 -0500 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:35694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KEI-00071s-A3 for 59691@debbugs.gnu.org; Wed, 30 Nov 2022 05:22:14 -0500 Original-Received: by mail-pl1-f179.google.com with SMTP id y4so16218194plb.2 for <59691@debbugs.gnu.org>; Wed, 30 Nov 2022 02:22:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=IPtiR9gkQX7ZqEV8NoXt6qLxhbUYFzaBhjFNFH+VKf8=; b=bNbYagz2KXxdyeexV5U/GZwhqqP1fifL6cYFN0v12X46Xi7XLaqNZNhgMN2mgc3IIy DKMLU8pvtOVDRY67YIDhmVSLdQ7wWBn0Y9x2Iln7pkVPyLm7lrBHs1P4KaCIypAF8mEO BWn0YVc5ok/GHGtX9Fl/6nw2OE0n/KjdQFShjfWv3AtS0wT4Gl0JV1//09DVU6n38s/Q PEChIvmgoWUJeufTmmU5D0J95GE7EnhiZewjZe6faeg2j6pnxxWt21tFCwXnKUpftQRF G6Zt8TqH2YUrDffEwe6T3vOHU+HnZBZHCaN+f/zabzO0GAG7RCFTCckDt73w+1GQvlkp 3kFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IPtiR9gkQX7ZqEV8NoXt6qLxhbUYFzaBhjFNFH+VKf8=; b=PPed7QeSQgT0GQowHGyL8RedmAQ/B0OOEeWdD4jTwyNf06rSfOB/1CLV0wmZmRjho1 oFqLW+PAr869cqnvInX96iz4ztyxUQUYTXIR+VNST7vbkbTQI2HUf2FNzI3sgwewt6xN lNf8Dh5ovOxOeX1R9wqBOlNga+AuEtVzKCHE650MRmSakYlBmwplsDpKgxuStV1q5zUk t2lw9GAGlb7+aBEIz/tk27sjCxabz04HT3VQZcEgcZvXd9tvUcMUfOoKGYkeVEFMkEqp OAHkNADlbGlGy+Pq27KN0RD6FHSJBlmJPwwbaksDGAr3rCRIDPEIQNi3ULLJqDf46ZSB lT2Q== X-Gm-Message-State: ANoB5plL7Ikpkp95UPi+2DCbzTLH0glb/CtJItJff6FrftYj2O7tRasL G6D5BG9PTI+lvHtH1obZ1Dk= X-Google-Smtp-Source: AA0mqf6dVcvE/Vam+K+bKL+zrb0n5pez4CRZ/u1jAe9Re+ilUXGOJSBSQsEP2vEaQy55dASU7PleYQ== X-Received: by 2002:a17:90a:67c1:b0:212:d484:b410 with SMTP id g1-20020a17090a67c100b00212d484b410mr71030479pjm.211.1669803728417; Wed, 30 Nov 2022 02:22:08 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a14-20020a170902ecce00b00186bc66d2cbsm1073348plh.73.2022.11.30.02.22.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2022 02:22:08 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249477 Archived-At: Theodor Thornhill writes: > On 29 November 2022 22:37:25 CET, "Jostein Kj=C3=B8nigsen" = wrote: >>Nice! >> >>Should we until further notice assume that js-ts-mode suffers from >> the same issues, and that a jsx-ts-mode might be needed too? To me >> it at least sounds plausible. > > No, because there are no ambiguities in the grammar with types and = jsx. > >> >>Speaking of duplication=E2=80=A6 Now that we have tree-sitter = wouldn=E2=80=99t it be >> possible to use the same parser and/or the same major-modes for >> JS/JSX as we already do for TS/TSX? JS/JSX is just Typescript >> without the type-annotations, right? >> >>Or are there good reasons for having separate modes for these? >> > > Not sure. I like that a mode maps to a tree-sitter grammar, and = personally I don't want to intertwine things to early. No strong opinions here, but currently a user could install tree-sitter-js, and find and enable js-ts-mode, which is straightforward, which is good. Since these four modes doesn=E2=80=99t = require too much boilerplate, I think it=E2=80=99s pretty good right now. Yuan