From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62029: 29.0.60; Allow users to customize eldoc buffer separator Date: Thu, 23 Mar 2023 17:12:15 -0700 Message-ID: References: <0C40D168-54D5-47E9-8BD8-77CFCD70B895@gmail.com> <87355vdufe.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62029@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 24 01:13:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfV3p-0001Sz-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Mar 2023 01:13:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfV3J-00059R-Pf; Thu, 23 Mar 2023 20:13:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfV3I-00059B-JH for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 20:13:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfV3H-0001iH-1z for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 20:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfV3G-0001ev-4P for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62029 X-GNU-PR-Package: emacs Original-Received: via spool by 62029-submit@debbugs.gnu.org id=B62029.16796167546342 (code B ref 62029); Fri, 24 Mar 2023 00:13:02 +0000 Original-Received: (at 62029) by debbugs.gnu.org; 24 Mar 2023 00:12:34 +0000 Original-Received: from localhost ([127.0.0.1]:39552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfV2o-0001eD-4x for submit@debbugs.gnu.org; Thu, 23 Mar 2023 20:12:34 -0400 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:53093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfV2m-0001e0-Vt for 62029@debbugs.gnu.org; Thu, 23 Mar 2023 20:12:33 -0400 Original-Received: by mail-pj1-f51.google.com with SMTP id x15so129496pjk.2 for <62029@debbugs.gnu.org>; Thu, 23 Mar 2023 17:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679616747; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/ZfgFnbK2SQwvlYX4PhLX42bBlC/T5nZYcnIfWjxNME=; b=onqXhGp9eU7JU4/MqDc4CmpVW+mwlSiSmOA2xkMF7suyXANKeuHdhTby5elyatOZmJ 2GUBgcE92LDRxN1fWCK0EO1mMYFm7V3y4JS7LHnT9sAKfXstVn/UbcclLjIsjulKouqU zRciH5s9/cTnW3zpmTL5q8ZDnNrugMFx1QTkNZegd9+OEdmlrnD1UIIi7TkGQhMaXIIp rMbx7+FtwU+uTG/Dui3EjEPlPNP49ydi8bKeAzXery9Hkuyisz1Anh9t1PUc10qxlpm5 4NHwFqjIoBEiTN/oD9nvCX5YQiZ07Fje4CAszUhBtVY89BnReT7N84TpR5iAS+BeQTfz pnng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679616747; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ZfgFnbK2SQwvlYX4PhLX42bBlC/T5nZYcnIfWjxNME=; b=SLwyzqSMwsFY5MLPnRwn6yGbb9QK32MtnUOodD3F4PUrTDQuQhzsi/GzHyP+xlEodL nivVxm578wWoZfuwVFWcFmlnk3JSSfj1Y07+u4VsdJvHKNAnN1lfr7LrXN6ltAKyhWJ1 ktFZ0NIrV/fO8DYMrPd7kXX4H3jfXs00IldJ129YTu8cvMfQC7aLbRUunuxdnIJR98o7 ukfRHN06u1QdbvhFDlTYStHz1AbpFSCOaT3tW7ouDB26NPt+u+5+rQBPmLrmyIT0e9Rh yL0w2h1L9MuYqpqYf2Bu4Nj9MH3X/UrQyexN3Aj5BbDo1KJBD0H0odbQ2Xa/oGsNIO35 17+w== X-Gm-Message-State: AAQBX9dxirz+VAtdazk5MbZHyOgoHje2HCGvNfSwh6TtJGJWZXen9wjB Z8hRRZX7+nXhlTtAXzA9F8o= X-Google-Smtp-Source: AKy350bp1/XbE1As3iAWECSweOauvQzMA3Aot8dWf7L6FzJ1Mm8/m1Zr9GgFqY93UrfCvmmCIQAr1w== X-Received: by 2002:a17:902:ceca:b0:1a1:956e:5417 with SMTP id d10-20020a170902ceca00b001a1956e5417mr765045plg.22.1679616746705; Thu, 23 Mar 2023 17:12:26 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ja2-20020a170902efc200b001a1f830c9d0sm865125plb.13.2023.03.23.17.12.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Mar 2023 17:12:26 -0700 (PDT) In-Reply-To: <87355vdufe.fsf@gmail.com> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258489 Archived-At: > On Mar 23, 2023, at 2:33 PM, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > Yuan Fu writes: >=20 >> I agree. But in the same time, eldoc=E2=80=99s rendering should be >> customizable too. If someone uses eldoc-doc-buffer and want to use >> fancier separators, they should be able to. That=E2=80=99ll be easier = than >> writing another displayer that does everything the same as >> eldoc-doc-buffer except for using a different separator. >=20 > I've pushed two commits to master that address the design shortcoming = I > was referring to. Here they are summarized: >=20 > commit e19994fe8c000b0ed2dbc667cdec26cf54356907 > ElDoc: rework rendering of echo area (bug#62029) >=20 > Previously, the display function 'eldoc-display-in-echo-area' = reused > the same buffer as 'eldoc-display-in-doc-buffer', but that made it > harder to render documentation items differently depending on the > specific constraints of each display functions. >=20 > commit 9b18407c7fd91313544acfb3457be5447987e20a > ElDoc: remember origin backend in doc snippets (bug#62029) >=20 > This lays groundwork for discriminating between different > documentation providers in ElDoc display outlets, i.e. members > of eldoc-display-functions >=20 > The first commit detaches eldoc-display-in-echo-area from > eldoc-display-in-doc-buffer (It also allows the backend to control the > display in the echo area specifically). For the purposes of this bug, > it should allow eldoc-display-in-doc-buffer to more freely structure = the > *eldoc* buffer with separators, etc. >=20 > The second commit adds a :origin cookie to each doc item passed to > eldoc-display-functions. The origin is the name of the backend = itself. > It could allow for better separators in the *eldoc* buffer where each > section is titled according to the backend that produced the > documentation. >=20 > So I guess what's missing for this bug is a customizable *eldoc* = buffer > separator with a good default value, like one of those = resize-resisting > horizontal separators. Also, for customization, maybe `format-spec' = can > be used? Brilliant! On top of format-spec, maybe also a face for the title, like = eldoc-source-title. For separator, maybe something like (insert =E2=80=9CTitle" (propertize "-" 'display '(space :align-to right) 'font-lock-face '(:strike-through t) 'face '(:strike-through t))) for GUI, and use underline for terminal. Yuan=