* Build failure from trunk
@ 2013-05-07 8:43 Matthew Leach
2013-05-07 17:48 ` Jan Djärv
0 siblings, 1 reply; 10+ messages in thread
From: Matthew Leach @ 2013-05-07 8:43 UTC (permalink / raw
To: emacs-devel
Hi Emacs,
I'm having issues building Emacs after a recent update. I'm now getting:
/home/matthew/.emacs_imp/src/xfns.c:4322: undefined reference to `x_get_net_workarea'
When I revert the revision: eggert@cs.ucla.edu-20130507053401-0nu6s4p8gb1fvsx0
this fixes the problem.
Thanks,
Matt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-07 8:43 Build failure from trunk Matthew Leach
@ 2013-05-07 17:48 ` Jan Djärv
2013-05-07 19:29 ` Paul Eggert
2013-05-08 5:06 ` Jan Djärv
0 siblings, 2 replies; 10+ messages in thread
From: Jan Djärv @ 2013-05-07 17:48 UTC (permalink / raw
To: Matthew Leach; +Cc: emacs-devel
Hello.
7 maj 2013 kl. 10:43 skrev Matthew Leach <matthew@mattleach.net>:
> Hi Emacs,
>
> I'm having issues building Emacs after a recent update. I'm now getting:
>
> /home/matthew/.emacs_imp/src/xfns.c:4322: undefined reference to `x_get_net_workarea'
>
> When I revert the revision: eggert@cs.ucla.edu-20130507053401-0nu6s4p8gb1fvsx0
>
> this fixes the problem.
One would hope people would at least compile before checking in, but apparently not.
Trunk is fixed now.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-07 17:48 ` Jan Djärv
@ 2013-05-07 19:29 ` Paul Eggert
2013-05-08 5:06 ` Jan Djärv
1 sibling, 0 replies; 10+ messages in thread
From: Paul Eggert @ 2013-05-07 19:29 UTC (permalink / raw
To: Jan Djärv; +Cc: Matthew Leach, emacs-devel
On 05/07/13 10:48, Jan Djärv wrote:
> One would hope people would at least compile before checking in
Sorry about that; but I did compile, and it worked on my platform.
Unfortunately I didn't notice one of the ifdefs that didn't trigger
for my platform. I checked in a further version that should work
for both kinds of platforms.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-07 17:48 ` Jan Djärv
2013-05-07 19:29 ` Paul Eggert
@ 2013-05-08 5:06 ` Jan Djärv
2013-05-08 14:46 ` Paul Eggert
1 sibling, 1 reply; 10+ messages in thread
From: Jan Djärv @ 2013-05-08 5:06 UTC (permalink / raw
To: Matthew Leach, eggert; +Cc: emacs-devel
Hello.
> Sorry about that; but I did compile, and it worked on my platform.
> Unfortunately I didn't notice one of the ifdefs that didn't trigger
> for my platform. I checked in a further version that should work
> for both kinds of platforms.
#if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4)
This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on, so it is obviously not correct.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-08 5:06 ` Jan Djärv
@ 2013-05-08 14:46 ` Paul Eggert
2013-05-08 16:01 ` Jan Djärv
0 siblings, 1 reply; 10+ messages in thread
From: Paul Eggert @ 2013-05-08 14:46 UTC (permalink / raw
To: Jan Djärv; +Cc: Matthew Leach, emacs-devel
On 05/07/2013 10:06 PM, Jan Djärv wrote:
> #if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4)
>
> This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on, so it is obviously not correct.
Sorry, I don't see the bug. Perhaps you misread the "+" as "|"?
For 4.0, for example, GTK_MAJOR_VERSION is 4 and GTK_MINOR_VERSION is 0,
so the comparison evaluates to 4 < 3 + (0 < 4),
which is false, which is what is wanted here.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-08 14:46 ` Paul Eggert
@ 2013-05-08 16:01 ` Jan Djärv
2013-05-08 23:00 ` Paul Eggert
0 siblings, 1 reply; 10+ messages in thread
From: Jan Djärv @ 2013-05-08 16:01 UTC (permalink / raw
To: Paul Eggert; +Cc: Matthew Leach, emacs-devel
Hello.
8 maj 2013 kl. 16:46 skrev Paul Eggert <eggert@cs.ucla.edu>:
> On 05/07/2013 10:06 PM, Jan Djärv wrote:
>> #if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4)
>>
>> This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on, so it is obviously not correct.
>
> Sorry, I don't see the bug. Perhaps you misread the "+" as "|"?
> For 4.0, for example, GTK_MAJOR_VERSION is 4 and GTK_MINOR_VERSION is 0,
> so the comparison evaluates to 4 < 3 + (0 < 4),
> which is false, which is what is wanted here.
I mixed up the precedence of < and +. Anyway, this is more unclear that the corresponding #if later in the code, i.e.:
#if GTK_MAJOR_VERSION > 3 || (GTK_MAJOR_VERSION == 3 && GTK_MINOR_VERSION >= 4)
At least they should be the same so someone reading the code can see that they are related.
We don't have that style when checking Gtk+ versions in other places, so introducing it here just makes the code harder to read.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-08 16:01 ` Jan Djärv
@ 2013-05-08 23:00 ` Paul Eggert
2013-05-09 8:10 ` Jan Djärv
0 siblings, 1 reply; 10+ messages in thread
From: Paul Eggert @ 2013-05-08 23:00 UTC (permalink / raw
To: Jan Djärv; +Cc: Matthew Leach, emacs-devel
On 05/08/13 09:01, Jan Djärv wrote:
> At least they should be the same so someone reading the code can see that they are related.
Good point. Glibc has a good style here; it defines macros
__GNUC_PREREQ, __GLIBC_PREREQ, etc., to check version numbers.
I added a macro GTK_PREREQ to do that with the similar uses
for GTK version numbers, as trunk bzr 112523. Please feel
free to change it if you still find it confusing.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-08 23:00 ` Paul Eggert
@ 2013-05-09 8:10 ` Jan Djärv
2013-05-09 14:51 ` Paul Eggert
0 siblings, 1 reply; 10+ messages in thread
From: Jan Djärv @ 2013-05-09 8:10 UTC (permalink / raw
To: Paul Eggert; +Cc: Matthew Leach, emacs-devel
Hello.
9 maj 2013 kl. 01:00 skrev Paul Eggert <eggert@cs.ucla.edu>:
> On 05/08/13 09:01, Jan Djärv wrote:
>> At least they should be the same so someone reading the code can see that they are related.
>
> Good point. Glibc has a good style here; it defines macros
> __GNUC_PREREQ, __GLIBC_PREREQ, etc., to check version numbers.
> I added a macro GTK_PREREQ to do that with the similar uses
> for GTK version numbers, as trunk bzr 112523. Please feel
> free to change it if you still find it confusing.
Good idea. But you missed one in gtkutils.c.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-09 8:10 ` Jan Djärv
@ 2013-05-09 14:51 ` Paul Eggert
2013-05-09 15:19 ` Jan Djärv
0 siblings, 1 reply; 10+ messages in thread
From: Paul Eggert @ 2013-05-09 14:51 UTC (permalink / raw
To: Jan Djärv; +Cc: Matthew Leach, emacs-devel
On 05/09/2013 01:10 AM, Jan Djärv wrote:
> Good idea. But you missed one in gtkutils.c.
I also missed the fact that GTK already defines a version-checking
macro. I fixed both problems in trunk bzr 112533.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Build failure from trunk
2013-05-09 14:51 ` Paul Eggert
@ 2013-05-09 15:19 ` Jan Djärv
0 siblings, 0 replies; 10+ messages in thread
From: Jan Djärv @ 2013-05-09 15:19 UTC (permalink / raw
To: Paul Eggert; +Cc: Matthew Leach, emacs-devel
Hello.
9 maj 2013 kl. 16:51 skrev Paul Eggert <eggert@cs.ucla.edu>:
> On 05/09/2013 01:10 AM, Jan Djärv wrote:
>> Good idea. But you missed one in gtkutils.c.
>
> I also missed the fact that GTK already defines a version-checking
> macro. I fixed both problems in trunk bzr 112533.
Nice.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-05-09 15:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 8:43 Build failure from trunk Matthew Leach
2013-05-07 17:48 ` Jan Djärv
2013-05-07 19:29 ` Paul Eggert
2013-05-08 5:06 ` Jan Djärv
2013-05-08 14:46 ` Paul Eggert
2013-05-08 16:01 ` Jan Djärv
2013-05-08 23:00 ` Paul Eggert
2013-05-09 8:10 ` Jan Djärv
2013-05-09 14:51 ` Paul Eggert
2013-05-09 15:19 ` Jan Djärv
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.