From: Stephen Pegoraro <spegoraro@tutive.com>
To: emacs-devel@gnu.org
Subject: Re: HiDPI support for wave style underlines
Date: Sun, 27 Aug 2017 12:26:00 +0800 [thread overview]
Message-ID: <CAPzg8ERkij8rhfm_8j3m7Q3MAUxc+1miY4vbjXrzboOWWzk4oQ@mail.gmail.com> (raw)
In-Reply-To: <83r2w5asby.fsf@gnu.org>
It still needs a fair bit of work on my end, the current
implementation is pretty naive.
Certain fonts are also getting clipping issues on HiDPI displays. I've
been pretty short of time this month but will try to get something
better going in the next few days!
On 21 August 2017 at 22:49, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Yuri D'Elia <wavexx@thregr.org>
>> Date: Mon, 21 Aug 2017 14:32:07 +0200
>>
>> On Mon, Aug 21 2017, Yuri D'Elia wrote:
>> > I actually get a floating point exception with this since I rebuilt
>> > emacs on the 19th. I'm rebuilding emacs now with debug to check where
>> > it's located, but I pinpointed it to flyspell so...
>>
>> Thread 1 "emacs" received signal SIGFPE, Arithmetic exception.
>> 0x00000000005181a3 in x_draw_underwave (s=0x7fffffffbe20) at xterm.c:3541
>> 3541 x1 = x0 - (x0 % dx);
>> (gdb) where
>> #0 0x00000000005181a3 in x_draw_underwave (s=0x7fffffffbe20) at xterm.c:3541
>> #1 0x0000000000518877 in x_draw_glyph_string (s=0x7fffffffbe20) at xterm.c:3685
>> #2 0x00000000004805d4 in draw_glyphs (w=0x148dc30 <bss_sbrk_buffer+8070032>, x=233, row=0x2eda080, area=TEXT_AREA, start=7, end=26, hl=DRAW_NORMAL_TEXT, overlaps=0) at xdisp.c:26595
>> (gdb) p dx
>> $1 = 0
>
> Thanks, I tried to correct this with an obvious fix.
>
prev parent reply other threads:[~2017-08-27 4:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 3:29 HiDPI support for wave style underlines Stephen Pegoraro
2017-07-29 7:13 ` Eli Zaretskii
[not found] ` <CAPzg8ETxJYr8Gw0Pag5zpWqA7aap_kduwuGvJaxAT5yvPhNd6w@mail.gmail.com>
2017-07-29 9:12 ` Stephen Pegoraro
2017-08-18 8:17 ` Eli Zaretskii
2017-08-21 12:20 ` Yuri D'Elia
2017-08-21 12:32 ` Yuri D'Elia
2017-08-21 14:49 ` Eli Zaretskii
2017-08-27 4:26 ` Stephen Pegoraro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPzg8ERkij8rhfm_8j3m7Q3MAUxc+1miY4vbjXrzboOWWzk4oQ@mail.gmail.com \
--to=spegoraro@tutive.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.