From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Genovese Newsgroups: gmane.emacs.bugs Subject: bug#10191: dired-query (in dired-aux.el) fails for certain help-char's, Emacs 23 and 24 Date: Fri, 2 Dec 2011 08:22:43 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec521559f71ea6e04b31bde50 X-Trace: dough.gmane.org 1322832245 8231 80.91.229.12 (2 Dec 2011 13:24:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2011 13:24:05 +0000 (UTC) Cc: 10191@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 14:23:57 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RWT5o-0003tx-Bi for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2011 14:23:56 +0100 Original-Received: from localhost ([::1]:50944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWT5n-00072I-BG for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2011 08:23:55 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWT5h-00072D-WF for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2011 08:23:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWT5g-0002EZ-HG for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2011 08:23:49 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWT5g-0002EV-7s for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2011 08:23:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RWT5u-0005Qa-0m for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2011 08:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Genovese Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2011 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10191-submit@debbugs.gnu.org id=B10191.132283220320814 (code B ref 10191); Fri, 02 Dec 2011 13:24:01 +0000 Original-Received: (at 10191) by debbugs.gnu.org; 2 Dec 2011 13:23:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWT5H-0005Pe-2W for submit@debbugs.gnu.org; Fri, 02 Dec 2011 08:23:23 -0500 Original-Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWT5D-0005PU-QM for 10191@debbugs.gnu.org; Fri, 02 Dec 2011 08:23:21 -0500 Original-Received: by dadv40 with SMTP id v40so1566954dad.3 for <10191@debbugs.gnu.org>; Fri, 02 Dec 2011 05:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Rq0yMTk7614vZsEQMzG0mcGw2ZhLiv4FXfb0sIntM+s=; b=Ko9Qs1YTmEyKvWQ9z/Yn25wHjyQSK+dss/NOGDtgyhDequZkh8PmiOj9SGbNnyTDgw AaOZjz71Xlgk2RvbQZo0LxrvYyAg/Ua6SnCZQfI4p8r463N9ERNSl1MGBWBsmV6WFHpS w1S5KxT0oZ1YGCm02dcI/E/yEQoCaUvE3ieXs= Original-Received: by 10.68.2.138 with SMTP id 10mr14404859pbu.55.1322832184338; Fri, 02 Dec 2011 05:23:04 -0800 (PST) Original-Received: by 10.142.155.7 with HTTP; Fri, 2 Dec 2011 05:22:43 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 02 Dec 2011 08:24:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54608 Archived-At: --bcaec521559f71ea6e04b31bde50 Content-Type: text/plain; charset=ISO-8859-1 Hi Andreas, I understand that and tried to specifically address that point in my report. But I could have been clearer. I think that a change in this regard, even the minimal one I proposed, is worthwhile for at least two reasons. First, because setting help-char to ?\M-\C-h works in terms of its main functionality (acting as a help character), it seems unnecessary for it to break a dired operation because of the formatting of a string. Second, if the function is going to be doctrinaire about help-char's type, then it has an obligation, I think, to recognize that not everyone uses a help "char" and might use help-event-list instead. It should then still do a characterp to avoid an error in those cases, possibly using the car of help-event-list for the error message when the characterp call returns false. This is not that different from my proposed change, and I'd be happy with that. On the broader question, I would also argue that help-char should be "help-event" or "help-keyboard-event". This is an example of one of the things in emacs that are IMHO too closely tied to the default keymap. I set C-h to delete-backward-char, M-h to backward-kill-word, and C-M-h to help char. This is a quite efficient arrangement and should not cause breakage in simple services just because it deviates from the default. This is Emacs after all. (Also, from the naive user's viewpoint, there is not that much difference between specifying ?\M-\C-h and ?\C-h. They both *look* like characters.) -- Chris On Fri, Dec 2, 2011 at 03:36, Andreas Schwab wrote: > Christopher Genovese writes: > > > For example, I set my help-char to ?\M-\C-h, which works fine in general. > > But despite looking like a character, ?\M-\C-h does not satisfy > > #'characterp, which causes > > the problem. Technically perhaps, help-char should be a character but > from > > the user's point > > of view, both of these should qualify. > > ?\M-\C-h isn't a character, it is a character with modifiers, and as > such does not qualify. A character is something which can be inserted > in a buffer or string as-is, for example. > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." > --bcaec521559f71ea6e04b31bde50 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Andreas,

=A0=A0=A0 I understand that and tried to specifically ad= dress that point in my report.
But I could have been clearer.

= =A0=A0=A0 I think that a change in this regard, even the minimal one I prop= osed, is
worthwhile for at least two reasons. First, because setting help-char to ?\= M-\C-h works
in terms of its main functionality (acting as a help chara= cter), it seems unnecessary for
it to break a dired operation because o= f the formatting of a string. Second, if the function
is going to be doctrinaire about help-char's type, then it has an oblig= ation, I think, to recognize
that not everyone uses a help "char&qu= ot; and might use help-event-list instead. It should
then still do a cha= racterp to avoid an error in those cases, possibly using the car of
help-event-list for the error message when the characterp call returns fals= e.=A0
This is not that different from my proposed change, and I'd b= e happy with that.

=A0=A0=A0=A0 On the broader question, I would als= o argue that help-char should be "help-event"
or "help-keyboard-event".=A0 This is an example of one of the thi= ngs in emacs that are
IMHO too closely tied to the default keymap.=A0 I = set C-h to delete-backward-char,
M-h to backward-kill-word, and C-M-h to= help char. This is a quite efficient arrangement
and should not cause breakage in simple services just because it deviates f= rom
the default. This is Emacs after all. (Also, from the naive user'= ;s viewpoint, there
is not that much difference between specifying ?\M-\= C-h and ?\C-h.=A0 They both *look*
like characters.)

=A0=A0=A0 -- Chris


On Fri, Dec 2, 2011 at 03:36, Andreas Schwab <<= a href=3D"mailto:schwab@linux-m68k.org">schwab@linux-m68k.org> wrote:
Christopher Genovese <genovese.cr@gmail.com> writes:

> For example, I set my help-char to ?\M-\C-h, which works fine in gener= al.
> But despite looking like a character, ?\M-\C-h does not satisfy
> #'characterp, which causes
> the problem. Technically perhaps, help-char should be a character but = from
> the user's point
> of view, both of these should qualify.

?\M-\C-h isn't a character, it is a character with modifiers, and as such does not qualify. =A0A character is something which can be inserted in a buffer or string as-is, for example.

Andreas.

--
Andreas Schwab, schwab@linux-m68k.= org
GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 =A001D3 44D5 214B 8276 4ED= 5
"And now for something completely different."

--bcaec521559f71ea6e04b31bde50--