From: Narayanan Nellayi <n.a.narayanan@gmail.com>
To: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
Cc: 41348@debbugs.gnu.org
Subject: bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c
Date: Sun, 17 May 2020 21:31:29 +0530 [thread overview]
Message-ID: <CAPtqxFbMedMgKw66Dx=7nzwWfLV11kkakG0GDdiiE_K-8peQ9w@mail.gmail.com> (raw)
In-Reply-To: <871rnih8ti.fsf@turtle-trading.net>
Hi Benny,
Thanks, what you suggested works and is cleaner than what I had in
mind (which is commenting out FALLTHROUGH or using a goto).
diff --git a/lib-src/etags.c b/lib-src/etags.c
index eee2c59626..4672e3491d 100644
--- a/lib-src/etags.c
+++ b/lib-src/etags.c
@@ -4197,9 +4197,9 @@ C_entries (int c_ext, FILE *inf)
break;
}
FALLTHROUGH;
- resetfvdef:
case '#': case '~': case '&': case '%': case '/':
case '|': case '^': case '!': case '.': case '?':
+ resetfvdef:
if (definedef != dnone)
break;
/* These surely cannot follow a function tag in C. */
Thanks
Narayanan
On Sun, May 17, 2020 at 9:06 PM Benjamin Riefenstahl
<b.riefenstahl@turtle-trading.net> wrote:
>
> Eli Zaretskii writes:
> > Does this mean Clang doesn't support __attribute__ ((__fallthrough__))?
>
> It looks to like it does support it. But it complains, that there is a
> non-switch label "resetfvdef:" (for goto) between the annotation and the
> next "case". The correct fix is probably to move "resetfvdef:" after
> the "case" labels.
>
>
> benny
next prev parent reply other threads:[~2020-05-17 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 7:02 bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c Narayanan Nellayi
2020-05-17 15:24 ` Eli Zaretskii
2020-05-17 15:36 ` Benjamin Riefenstahl
2020-05-17 16:01 ` Narayanan Nellayi [this message]
2020-05-17 15:53 ` Narayanan Nellayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPtqxFbMedMgKw66Dx=7nzwWfLV11kkakG0GDdiiE_K-8peQ9w@mail.gmail.com' \
--to=n.a.narayanan@gmail.com \
--cc=41348@debbugs.gnu.org \
--cc=b.riefenstahl@turtle-trading.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.