From: Narayanan Nellayi <n.a.narayanan@gmail.com>
To: 41348@debbugs.gnu.org
Cc: "Narayanan N.A." <n.a.narayanan@gmail.com>
Subject: bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c
Date: Sun, 17 May 2020 12:32:39 +0530 [thread overview]
Message-ID: <CAPtqxFZtks=xrefX0XOAi=bSBEyRLvzbsHwkA895LZ18JNVKuw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
Hi,
emacs compilation with clang10 on Ubuntu 20.04 (focal release) fails with
an error in the file lib-src/etags.c. I am able to fix the issue with a
one-line change. This compilation failure is seen on the emacs src from
top-of-the-master-branch.
Pls see if this fix is appropriate and consider accordingly.
I have given below the details on the issue and a patch description.
Regards
Narayanan
clang --version
> clang version 10.0.0-4ubuntu1
> Target: x86_64-pc-linux-gnu
> Thread model: posix
> InstalledDir: /usr/bin
>
> make -C lib-src all
> make[1]: Entering directory
> '/mnt/myvg_fs/home/anarayan/sources/emacs/lib-src'
> CCLD etags
> error: fallthrough annotation does not directly precede switch label
> 1 error generated.
> make[1]: *** [Makefile:366: etags] Error 1
> make[1]: Leaving directory
> '/mnt/myvg_fs/home/anarayan/sources/emacs/lib-src'
> make: *** [Makefile:411: lib-src] Error 2
>
> diff --git a/lib-src/etags.c b/lib-src/etags.c
> index eee2c59626..b5f077007b 100644
> --- a/lib-src/etags.c
> +++ b/lib-src/etags.c
> @@ -4196,7 +4196,7 @@ C_entries (int c_ext, FILE *inf)
> objdef = omethodsign;
> break;
> }
> - FALLTHROUGH;
> + // FALLTHROUGH;
> resetfvdef:
> case '#': case '~': case '&': case '%': case '/':
> case '|': case '^': case '!': case '.': case '?':
>
>
[-- Attachment #2: Type: text/html, Size: 2192 bytes --]
next reply other threads:[~2020-05-17 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 7:02 Narayanan Nellayi [this message]
2020-05-17 15:24 ` bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c Eli Zaretskii
2020-05-17 15:36 ` Benjamin Riefenstahl
2020-05-17 16:01 ` Narayanan Nellayi
2020-05-17 15:53 ` Narayanan Nellayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPtqxFZtks=xrefX0XOAi=bSBEyRLvzbsHwkA895LZ18JNVKuw@mail.gmail.com' \
--to=n.a.narayanan@gmail.com \
--cc=41348@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.