From: Jan Synacek <jsynacek@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, 24656@debbugs.gnu.org
Subject: bug#24656: 25.1; Emacs leaves lock files on a CIFS share
Date: Tue, 11 Oct 2016 08:52:48 +0200 [thread overview]
Message-ID: <CAPsXM8W5ZtOkmMMfnkCgk1ToC9RAUrZ_tqWttO6wFb1n7ReUOA@mail.gmail.com> (raw)
In-Reply-To: <83pon7crcl.fsf@gnu.org>
On Tue, Oct 11, 2016 at 8:49 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jan Synacek <jsynacek@redhat.com>
>> Date: Tue, 11 Oct 2016 08:32:35 +0200
>> Cc: 24656@debbugs.gnu.org
>>
>> > Did you also patch current_lock_owner to account for the change from a
>> > colon to a comma?
>>
>> Aha! After patching current_lock_owner, the lock file is correctly
>> removed. I'm attaching the patch.
>>
>> Thank you!
>
> Thanks.
>
> Paul, do you see any reasons not to make this change? Could the comma
> be problematic in some cases? If so, can we try some other character,
> perhaps?
>
> If the change is okay, I'd like to make it on the emacs-25 branch.
> Any objections?
One thing I noticed after creating the patch. You probably also want
to fix the comments that mention colon.
--
Jan Synacek
Software Engineer, Red Hat
next prev parent reply other threads:[~2016-10-11 6:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 11:30 bug#24656: 25.1; Emacs leaves lock files on a CIFS share Jan Synáček
2016-10-10 12:14 ` Eli Zaretskii
2016-10-10 13:49 ` Jan Synacek
2016-10-10 15:49 ` Eli Zaretskii
2016-10-11 6:32 ` Jan Synacek
2016-10-11 6:49 ` Eli Zaretskii
2016-10-11 6:52 ` Jan Synacek [this message]
2016-10-11 15:59 ` Paul Eggert
2016-10-11 16:29 ` Eli Zaretskii
2016-10-11 16:53 ` Paul Eggert
2016-10-11 17:07 ` Eli Zaretskii
2016-10-11 20:15 ` Paul Eggert
2016-10-11 20:58 ` Eli Zaretskii
2016-10-11 22:46 ` Paul Eggert
2016-10-12 6:40 ` Eli Zaretskii
2016-10-12 16:21 ` Paul Eggert
2016-10-12 16:53 ` Eli Zaretskii
2016-10-11 17:43 ` Achim Gratz
2016-10-11 18:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPsXM8W5ZtOkmMMfnkCgk1ToC9RAUrZ_tqWttO6wFb1n7ReUOA@mail.gmail.com \
--to=jsynacek@redhat.com \
--cc=24656@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.