On Mon, Dec 16, 2024 at 8:54 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Juri Linkov <juri@linkov.net>
> Cc: nicolas.despres@gmail.comemacs-devel@gnu.org
> Date: Mon, 16 Dec 2024 21:14:46 +0200
>
> >> > If so, please augment the change by a user option which controls
> >> > whether windows are split as they were before or according to the new
> >> > algorithm.  We can then discuss whether the default will be the old
> >> > behavior or the new one.
> >>
> >> There is already the existing option 'split-window-preferred-function'.
> >> It could provide a choice of more values to select a predefined
> >> behavior.
> >
> > We cannot ask users to write a function in order to get back old
> > behavior.  Customizations via functions is not user-friendly enough
> > for such simple tasks.
>
> I meant a choice from predefined functions.

Which ones?  I don't see any.

And how will we advertise this in a way that users affected by this
change will discover it easily?  split-window-sensibly is not a
command that users could look up, and split-window-preferred-function
is called by display-buffer, so finding this information in order to
use it for restoring previous behavior will not be easy.

'split-window-preferred-function' is well suited for a completely different behavior.

Providing multiple functions for slightly different variants will most likely duplicate code.
This patch already factors the code a bit.
I am more in favor of an option to choose the behavior of `split-window-sensibly'.