From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: hermann sorgel Newsgroups: gmane.emacs.bugs Subject: bug#72230: 29.4; Cursor Disappears with Hebrew Text Date: Sun, 21 Jul 2024 20:31:54 +0300 Message-ID: References: <86o76qbvd9.fsf@gnu.org> <86ikwybuoq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a8404e061dc54ecc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11968"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72230@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 21 19:41:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVaYt-0002x1-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jul 2024 19:41:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVaYT-0005Cw-UM; Sun, 21 Jul 2024 13:41:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVaYP-0005Ch-4U for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 13:41:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVaYO-0000sH-SA for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 13:41:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVaYQ-0006VQ-OG for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: hermann sorgel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2024 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72230 X-GNU-PR-Package: emacs Original-Received: via spool by 72230-submit@debbugs.gnu.org id=B72230.172158363424958 (code B ref 72230); Sun, 21 Jul 2024 17:41:02 +0000 Original-Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 17:40:34 +0000 Original-Received: from localhost ([127.0.0.1]:55995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVaXx-0006UO-Un for submit@debbugs.gnu.org; Sun, 21 Jul 2024 13:40:34 -0400 Original-Received: from mail-oa1-f49.google.com ([209.85.160.49]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVaQr-0006JG-Bo for 72230@debbugs.gnu.org; Sun, 21 Jul 2024 13:33:14 -0400 Original-Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-25dfb580d1fso1451729fac.2 for <72230@debbugs.gnu.org>; Sun, 21 Jul 2024 10:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721583126; x=1722187926; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0o8UmXNUmemWFaHBcTt7ZI4sMapeuO8uPCm5TJU7pVQ=; b=DAvAGIvU5b/HcEaD0+j4MNINsKZeknsE1Co5HSpwE7JjtLXVVwX0MafPru2Z4cSKDB LRfGbqUSN5w9QmUZgM/PIOnX62/0/st8WYGq6CDGfbHt2nwQWSsmtH67LfrkV9UZg4np 9lWPTapB1N2mkbnazwgrTGgUi3+xCoaHgLWyeJBm7VwLSX6gw1Uel5Bvbasw8sKks2HX /RcIBC/GETnb8jXJM/w33uAWN8xyd4ZeDYSgPOf8P0YK9uZFXouParxOMMqmJcLEPqZ3 r/y8DzH3vUCqTVEllECHcQ0bhflEibBsp9sv6R02fIURuJbtIQHjD9YbuQUUtwct3je1 AGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721583126; x=1722187926; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0o8UmXNUmemWFaHBcTt7ZI4sMapeuO8uPCm5TJU7pVQ=; b=mhFkVAEceULbufuQPFbL3ndrIgr4tBu/szUC8ihZvrQ04w4excdTLPbgerYmAB1BjJ ZLdkrTSYO93FAwAuWq6hUUwN7xkMEphXwHEZMMUwcxODhPw1MW0XnfgcyyKTAsPDSewU ntiBtsDoJiVjQ+fVBytYauaMM02uY3a2FwrlFqjnJQGXICb84dL69q5iJEIK5qQc2NfU hcY6MFGGeIy8QCqsZ8LwlDbzXl2fAm4KUcIUSlNRdaNo0BuK0fY27u5LGqGGJ97W+KhN y8clg1xnwMwswiGZX8LDWoFaRQGjQI9d+r2JIpyRPVV+hkjmamca0/jimARlzX6xzHGv o3BA== X-Gm-Message-State: AOJu0YxiKkUVw3y5wtpy28P8et1agkZ1/+ZagB4YqJlzCbsyqjElfz8s nNkM/LhkJCkYWHBx/rED+KNwnBZv2ryIPns+UUjUIUswdNNhSpWhyuYKc3x/KVqnlQPIsYyaupt A1P3bmbO2JKkNkh8WT59rhvla5j/wg14mmVQ= X-Google-Smtp-Source: AGHT+IFIjLJcA8BKBFEzsZVcF+7rpEE8fstm1Km2HZ9yyuXHE3yXOhj6r+esWqqPoIWGrqMqn9PuSBfhdt0bIKQNQRs= X-Received: by 2002:a05:6871:722:b0:25e:65f:a530 with SMTP id 586e51a60fabf-263ab5d2b15mr4607462fac.41.1721583125673; Sun, 21 Jul 2024 10:32:05 -0700 (PDT) In-Reply-To: <86ikwybuoq.fsf@gnu.org> X-Mailman-Approved-At: Sun, 21 Jul 2024 13:40:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289085 Archived-At: --000000000000a8404e061dc54ecc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is the same code with s.size.width in the working fork. It does not look that anything has changed in 29.4. On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM Eli Zaretskii wrote: > > Cc: 72230@debbugs.gnu.org > > Date: Sun, 21 Jul 2024 18:46:58 +0300 > > From: Eli Zaretskii > > > > Thanks. I cannot reproduce this on my system, but I'm not on macOS. > > Maybe this is specific to macOS? Can a macOS user please try > > reproducing this? > > And I think I see the problem. This fragment of nsterm.m: > > case BAR_CURSOR: > s =3D r; > /* If the character under cursor is R2L, draw the bar cursor > on the right of its glyph, rather than on the left. */ > cursor_glyph =3D get_phys_cursor_glyph (w); > if ((cursor_glyph->resolved_level & 1) !=3D 0) > s.origin.x +=3D cursor_glyph->pixel_width - s.size.width; > > is incorrect: it should use the value of the cursor_width argument, > not s.size.width. Can someone who is capable of building Emacs on > macOS please try copying more closely the code from xterm.c or > w32term.c that draws the bar cursor, and see if that solves the > problem? > --000000000000a8404e061dc54ecc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here is the same code=C2=A0= =C2=A0with=C2=A0s.sizewidth in the working fork. It does not look that = anything has changed in 29.4.

On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM El= i Zaretskii <eliz@gnu.org> wrote:=
> Cc: 72230@debbugs.gnu.org<= /a>
> Date: Sun, 21 Jul 2024 18:46:58 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Thanks.=C2=A0 I cannot reproduce this on my system, but I'm not on= macOS.
> Maybe this is specific to macOS?=C2=A0 Can a macOS user please try
> reproducing this?

And I think I see the problem.=C2=A0 This fragment of nsterm.m:

=C2=A0 =C2=A0 case BAR_CURSOR:
=C2=A0 =C2=A0 =C2=A0 s =3D r;
=C2=A0 =C2=A0 =C2=A0 /* If the character under cursor is R2L, draw the bar = cursor
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0on the right of its glyph, rather than on= the left.=C2=A0 */
=C2=A0 =C2=A0 =C2=A0 cursor_glyph =3D get_phys_cursor_glyph (w);
=C2=A0 =C2=A0 =C2=A0 if ((cursor_glyph->resolved_level & 1) !=3D 0)<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 s.origin.x +=3D cursor_glyph->pixel_width - = s.size.width;

is incorrect: it should use the value of the cursor_width argument,
not s.size.width.=C2=A0 Can someone who is capable of building Emacs on
macOS please try copying more closely the code from xterm.c or
w32term.c that draws the bar cursor, and see if that solves the
problem?
--000000000000a8404e061dc54ecc--