From: Anthony Lander <anthony@landerfamily.ca>
To: Muchenxuan Tong <demon386@gmail.com>
Cc: "emacs-orgmode@gnu.org Mode" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-mac-link: Improve grabbing behavior for Chrome.
Date: Tue, 25 Mar 2014 11:19:32 -0400 [thread overview]
Message-ID: <CAPgrogd6VqzGAkRpOLJuMA8CXwQyuNbyvbxOZFofeEU4pB9RuQ@mail.gmail.com> (raw)
In-Reply-To: <1395534192-21594-1-git-send-email-demon386@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2857 bytes --]
Thanks for improving the link grabber!
-Anthony
On Sat, Mar 22, 2014 at 8:23 PM, Muchenxuan Tong <demon386@gmail.com> wrote:
> * contrib/lisp/org-mac-link.el (org-as-mac-chrome-get-frontmost-url):
> Improve AppleScript used for grabbing information from Chrome. Now
> it's shorter and doesn't require switching to the app. Also,
> starting and ending quote are trimmed only when necessary.
> ---
> contrib/lisp/org-mac-link.el | 32 ++++++++++++--------------------
> 1 file changed, 12 insertions(+), 20 deletions(-)
>
> diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
> index ef46171..d1687e0 100644
> --- a/contrib/lisp/org-mac-link.el
> +++ b/contrib/lisp/org-mac-link.el
> @@ -349,26 +349,18 @@ applications and inserting them in org documents"
>
> (defun org-as-mac-chrome-get-frontmost-url ()
> (let ((result (do-applescript
> - (concat
> - "set oldClipboard to the clipboard\n"
> - "set frontmostApplication to path to frontmost
> application\n"
> - "tell application \"Google Chrome\"\n"
> - " activate\n"
> - " delay 0.15\n"
> - " tell application \"System Events\"\n"
> - " keystroke \"l\" using command down\n"
> - " keystroke \"c\" using command down\n"
> - " end tell\n"
> - " delay 0.15\n"
> - " set theUrl to the clipboard\n"
> - " set the clipboard to oldClipboard\n"
> - " set theResult to (get theUrl) & \"::split::\" &
> (get name of window 1)\n"
> - "end tell\n"
> - "activate application (frontmostApplication as
> text)\n"
> - "set links to {}\n"
> - "copy theResult to the end of links\n"
> - "return links as string\n"))))
> - (substring (car (split-string result "[\r\n]+" t)) 1 -1)))
> + (concat
> + "set frontmostApplication to path to frontmost
> application\n"
> + "tell application \"Google Chrome\"\n"
> + " set theUrl to get URL of active tab of first
> window\n"
> + " set theResult to (get theUrl) & \"::split::\" &
> (get name of window 1)\n"
> + "end tell\n"
> + "activate application (frontmostApplication as text)\n"
> + "set links to {}\n"
> + "copy theResult to the end of links\n"
> + "return links as string\n"))))
> + (replace-regexp-in-string "^\"\\|\"$" ""
> + (car (split-string result "[\r\n]+" t)))))
>
> (defun org-mac-chrome-get-frontmost-url ()
> (interactive)
> --
> 1.9.1
>
>
>
[-- Attachment #2: Type: text/html, Size: 3813 bytes --]
prev parent reply other threads:[~2014-03-25 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-23 0:23 [PATCH] org-mac-link: Improve grabbing behavior for Chrome Muchenxuan Tong
2014-03-23 8:25 ` Bastien
2014-03-25 15:19 ` Anthony Lander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgrogd6VqzGAkRpOLJuMA8CXwQyuNbyvbxOZFofeEU4pB9RuQ@mail.gmail.com \
--to=anthony@landerfamily.ca \
--cc=demon386@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.