From: Jeff Norden <norden.jeff@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63956@debbugs.gnu.org, sds@gnu.org,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29
Date: Mon, 12 Jun 2023 11:41:34 -0500 [thread overview]
Message-ID: <CAPbFCn=oZqe4HifkVzGsjsKtM8UR2wJHq3_X-2HQi_7oiekA5Q@mail.gmail.com> (raw)
In-Reply-To: <83legoyk7i.fsf@gnu.org>
On Mon, Jun 12, 2023 at 6:48 AM Eli Zaretskii wrote:
> OK, thanks. But did you see any difference between doing this the way
> Emacs 28 did (without 2nd argument to pop-to-buffer) and the way the
> code now does on the emacs-29 branch? IOW, does this scenario produce
> reasonable results after my recent changes?
The default behavior in emacs-29 is now the same as it was in 28.2, so I
don't see any need to make further changes at this point.
---
If my (admittedly limited) understanding of display buffer actions is
correct, then calling display-buffer or pop-to-buffer with a
'reuse-window' action would only differ from a call without any action
if either:
(a) display-buffer-base-action has been customized, or
(b) the buffer name has been listed in same-window-buffer-names or
matches same-window-regexps
This assumes that display-buffer-fallback-action has its default
value, which it should since it is defined with defconst in window.el:
(defconst display-buffer-fallback-action
'((display-buffer--maybe-same-window ;FIXME: why isn't this redundant?
display-buffer-reuse-window
display-buffer--maybe-pop-up-frame-or-window
display-buffer-in-previous-window
display-buffer-use-some-window
;; If all else fails, pop up a new frame.
display-buffer-pop-up-frame))
Perhaps this answers the question in the above code, --maybe-same-window
seems to be for backwards compatibility to allow the use of the
same-window- variables, which pre-date window actions.
Using display-buffer-alist is the recommended way to do things now, and
gets first priority.
Thanks,
-Jeff
next prev parent reply other threads:[~2023-06-12 16:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 17:52 bug#63956: 29.0.91; tex-mode display problem in emacs-29 Jeff Norden
2023-06-08 9:15 ` Eli Zaretskii
2023-06-08 17:44 ` Sam Steingold
2023-06-08 18:34 ` Eli Zaretskii
2023-06-09 20:00 ` Sam Steingold
2023-06-10 5:56 ` Eli Zaretskii
2023-06-10 12:55 ` Gregory Heytings
2023-06-10 13:12 ` Eli Zaretskii
2023-06-10 13:20 ` Gregory Heytings
2023-06-11 6:22 ` Eli Zaretskii
2023-06-11 15:44 ` Jeff Norden
2023-06-11 16:01 ` Eli Zaretskii
2023-06-11 17:31 ` Jeff Norden
2023-06-11 18:14 ` Eli Zaretskii
2023-06-11 20:12 ` Jeff Norden
2023-06-12 11:49 ` Eli Zaretskii
2023-06-12 16:41 ` Jeff Norden [this message]
2023-06-12 16:44 ` Eli Zaretskii
2023-06-13 1:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-13 11:12 ` Eli Zaretskii
2023-06-09 16:30 ` Jeff Norden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPbFCn=oZqe4HifkVzGsjsKtM8UR2wJHq3_X-2HQi_7oiekA5Q@mail.gmail.com' \
--to=norden.jeff@gmail.com \
--cc=63956@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.