From: Yuri Khan <yuri.v.khan@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: i.lohmar@gmail.com, Emacs developers <emacs-devel@gnu.org>,
Phillip Lord <phillip.lord@russet.org.uk>
Subject: Re: Branches are Scary
Date: Fri, 18 Dec 2015 13:49:39 +0600 [thread overview]
Message-ID: <CAP_d_8XxoyaddXed_+B7P7Ui+AuCfRV8YX89rk5JTAQUcRJY6w@mail.gmail.com> (raw)
In-Reply-To: <83fuz0xlk9.fsf@gnu.org>
On Fri, Dec 18, 2015 at 1:28 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> > If you still plan substantial cleanup of your commits, just
>> > do not push them yet.
>>
>> Makes it hard to get comments on them, I think.
>
> How's that? Can you tell more details how getting comments requires
> squashing?
Getting comments doesn’t. Acting on comments sort of does.
Sure, you can push a follow-up commit with a “Post-review fix”
subject, but it makes history too detailed. Or you can squash fixes
into the commits that introduced the respective issues.
next prev parent reply other threads:[~2015-12-18 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 21:25 Branches are Scary Phillip Lord
2015-12-17 21:49 ` Ingo Lohmar
2015-12-17 22:20 ` Phillip Lord
2015-12-17 23:35 ` John Wiegley
2015-12-18 7:28 ` Eli Zaretskii
2015-12-18 7:49 ` Yuri Khan [this message]
2015-12-18 9:05 ` Eli Zaretskii
2015-12-18 10:43 ` Phillip Lord
2015-12-18 15:48 ` Random832
2015-12-18 16:10 ` Eli Zaretskii
2015-12-18 16:46 ` Phillip Lord
2015-12-18 7:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP_d_8XxoyaddXed_+B7P7Ui+AuCfRV8YX89rk5JTAQUcRJY6w@mail.gmail.com \
--to=yuri.v.khan@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=i.lohmar@gmail.com \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.