From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Yuri Khan Newsgroups: gmane.emacs.devel Subject: Re: Syntactic fontification of diff hunks Date: Fri, 17 Aug 2018 12:41:10 +0700 Message-ID: References: <87in4af29r.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1534484374 2190 195.159.176.226 (17 Aug 2018 05:39:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2018 05:39:34 +0000 (UTC) Cc: Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 07:39:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqXTu-0000UW-7i for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 07:39:30 +0200 Original-Received: from localhost ([::1]:60072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqXW0-0002KG-HN for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 01:41:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqXVn-0002Ju-Qm for emacs-devel@gnu.org; Fri, 17 Aug 2018 01:41:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqXVl-0007nU-Tu for emacs-devel@gnu.org; Fri, 17 Aug 2018 01:41:27 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:42334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqXVk-0007mV-54 for emacs-devel@gnu.org; Fri, 17 Aug 2018 01:41:25 -0400 Original-Received: by mail-oi0-x232.google.com with SMTP id b16-v6so12146747oic.9 for ; Thu, 16 Aug 2018 22:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0vy9t5mvmErlaLoQbQlAN/l5QCbFVguzy4d5SCeqQ1c=; b=qTt7C/t5+LXtzaSyk3m4eQs0efuxEIbDVwRGzUGc2xI9t3fjv06duI9gJayPZ2XKzb nnkq/YefhtCHtOeMjr3XYYZi9Q31vKBDh5dhMCH6C4Di7aLmaKHeCzLPUcxBW6FAryTx kF8EW0vqcKm2YKfdJkF0yxZvCxJpF95C4QJdWDvaHFohsHES6zf53ePkASUQ8+lAn0BT tY/w5jUt815jTXuDztEkktv0/ZWSZ5fFN/WbTIiDWD+qz8/LQ2r7FTF9SZfoHygQQaNq +rKSP5HHbSE1Qcg7IkQl9cxtU0qDgdpboCo4tmkmkKzIF/P6IsKokh+iK4RAf5+CgUCP Xtzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0vy9t5mvmErlaLoQbQlAN/l5QCbFVguzy4d5SCeqQ1c=; b=LPlrXAOKPQDQ+u/RqTri4J39g3qx+B5NdDt3ho4pueqRJWXCGr2O4h+hezg0X06p5o HWvNr9HFpI9dkEdBoSz13mCJgJULxlTMBD0HWg4/fa6KUatNR2N8jkC3GbFw1YDaq9Hw I/OwKcHeS03enUohnAdbkryDAXfZ+Y8NK/KOWQv5OZ1udG0sQ1HPFjjlyBLOPeIzReGl xeaB14oa42kw+1B9rlloRFAfbAGbvOdAFN792peuasazCKuBPJ2VUaPyvsZNoZ20FWv3 ZGous6TqWBql7Ou4tL4sZMRpmmy3lJIPbDLwJmyJSI9GKFRHUIzywebKjMMa0SBACN2o N5ag== X-Gm-Message-State: AOUpUlHDNumkNb0mGFRSmDYd+GpLvGZm/ZTOuw0JdoxNluLDW92i+IBC qIKuDg4wa0R21senrYCX9S7iAqsMKW25zNBmYHfYng== X-Google-Smtp-Source: AA+uWPyaCgL70r1+gYnq4WDLAS/obTNvSGzyc/bQGoC6KcVt2rQRtixZU3OwBtlP2TRTUWHR2Hrak88W149xC0SdcwY= X-Received: by 2002:aca:d0cc:: with SMTP id j73-v6mr1101304oiy.255.1534484482288; Thu, 16 Aug 2018 22:41:22 -0700 (PDT) In-Reply-To: <87in4af29r.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228621 Archived-At: On Fri, Aug 17, 2018 at 4:41 AM Juri Linkov wrote: > > Most version control sites like gitlab/github highlight syntax > in code snippets inside diff hunks, for example: > https://github.com/magit/magit/pull/2834/commits/95cacde4fcccc95c25d6fb99= 88d2aa097193f8c0 > > This is very helpful when looking at code changes. I missed this feature= in Emacs > for a long time. Oh yesss. > Then I realized that much simpler would be just to use the same approach > implemented by diff-mode refinement, i.e. to take each diff hunk one by > one, and like the diff refinement highlights more fine-grained changes, > do the same for syntax highlighting according to the language in > compared files/commits. I suppose some integration will be needed before this works in Magit, too? Also, it looks like it=E2=80=99s going to be somewhere between slightly and horribly inaccurate depending on where the hunk starts (e.g. in the middle of a string literal or comment)?