From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Yuri Khan Newsgroups: gmane.emacs.devel Subject: Re: Flymake, compilation-mode lighters very noisy Date: Wed, 21 Nov 2018 18:35:54 +0700 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1542800084 5150 195.159.176.226 (21 Nov 2018 11:34:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 11:34:44 +0000 (UTC) Cc: Emacs developers To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 21 12:34:40 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPQmE-0001C7-Ld for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2018 12:34:38 +0100 Original-Received: from localhost ([::1]:38602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPQoL-0004gE-3G for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2018 06:36:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPQng-0004Ni-2H for emacs-devel@gnu.org; Wed, 21 Nov 2018 06:36:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPQnf-0001Oh-8y for emacs-devel@gnu.org; Wed, 21 Nov 2018 06:36:08 -0500 Original-Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:45054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPQnf-0001OU-48 for emacs-devel@gnu.org; Wed, 21 Nov 2018 06:36:07 -0500 Original-Received: by mail-ot1-x32a.google.com with SMTP id f18so3056375otl.11 for ; Wed, 21 Nov 2018 03:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yxKMYAsRUbbTAzYc4iepv7k8bxF7DZz9SolP19LNH0E=; b=g7I3owcB0l5guUcFRcrbZkfx7nHSRUek352e0shjYw8OtLJRxs3oNznIWuYa5fg0wz fRwmiaF4fKYgsATsYc6dpTh37z6kZXmy+zrQlrJYx/7Y9nyzjEZlELK5F/u2OfwPBG9v dKRoO/xpsTKt3vYl14SiBNMN6uGYV4FuDXtVsOUMAKWhxiUO5okqTsRzNgLZuy6RUmaX q4EvpeOGFoj2r8/zjofJxfja195BkoLWX4saF0oto89BrOv+xFvjxnwMlrwgDJjKX7jv 6xvqvrIdZZGokLlpkI7wqM42NSsz8uByRtbMDbFJ3l+kqYqSqr0AvE3ekuvN5YYEo/cf qjxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yxKMYAsRUbbTAzYc4iepv7k8bxF7DZz9SolP19LNH0E=; b=Eczne7wXLdjJI8yoVn4dzMheEqkhzYsaQ+DvCqPfJdCysjiOQkIzFsiUGjZOHspVP6 AgjTaOCenQQWd1cY9YAI7RHxKT9Cr7gJHC5m4JuTwzdBy4Kjf+i2J6NOOzrEFAc5lVD6 R21fMwHXY0lidWTza0zIyuBM6MKl0j00nrxVHRyHiVzU+AVFdshFRc/YjfMmbiOCoCy5 CWhtZZ95T1SUnw348DAUVqA6i4UmnF4TjW3hkw9NNn1v8PlP8DJpBF66ExftME/MoYAp Mc5vuXx7SriFVhtOEMth1258db9pj7vY8dg5MIkyqVbv3C2L+paLXDep+y6Y3IoQAmfg mcqQ== X-Gm-Message-State: AA+aEWYknol5kKONrWDAY6vkkj17Y/rOA1jmHTAHPaLMr18N3lXiI1X+ gg0r6n8lDlZ/LNQKdKGs5tdVt8IHl3+hxjdbK+c= X-Google-Smtp-Source: AFSGD/UaLdtXqCAt2lj6EnWAP1yRH9cK2aKaSH9emZ+cLo6DIHwUNdbgFmmABj0KUmBAd4bLfxkTtFQLer4htAlLlR4= X-Received: by 2002:a9d:d23:: with SMTP id 32mr3364863oti.328.1542800166466; Wed, 21 Nov 2018 03:36:06 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231277 Archived-At: On Wed, Nov 21, 2018 at 5:39 PM Jo=C3=A3o T=C3=A1vora wrote: > > This is too long for me to read right now, sorry. Please take your time. No pressure. > The simple variable flymake-always-show-indicators-min-severity-level wou= ld fix the problem you reported yesterday, and it would be trivial to imple= ment, but you seem to be suggesting much more. I am suggesting a massive logic:presentation split-up, so that not only my problem would be fixed but also similar problems for different categories of other users, and because such a split-up is generally a good thing. > By the way, I only asked you to propose a break up of that function becau= se you talked about copying it to your init and tweaking it. I assumed thos= e tweaks would not be random... :) Okay, if we are talking about my tweaks only, then I would want to have a configuration where a red or yellow anything on my mode line means an actionable alert. That is, only display color if there is something I *can* and *should* fix immediately. * First, I would suppress zero counters of all severities. This would make it possible for me to work on projects that currently have no errors or warnings and where the policy is to keep errors and warnings at zero. * I could get involved in a project that has warnings, and where I cannot fix them all at the source. Then I would first attempt to see if I can customize the checker rules to silence those categories of errors or warnings. If that proved infeasible, then I would have to live with a non-zero error or warning counter; in that case I would want to tweak the indicator so that the counters were displayed in a normal face, not in red and yellow. =E2=80=A6And here I looked at where it gets the faces from and saw I could just (put 'flymake-error 'mode-line-face nil). Thank you, immediate problem solved, sorry for the panic :) > Propose those changes in a patch or a scratch branch! Or, alternatively, = propose only the new customization variable/interfaces you would like to se= e added, along with docstrings, and we can deal with the implementation lat= er after we settle on the user interface. As someone who has not assigned copyright to FSF, I think I can currently only propose ideas, and modest amounts of code.