From: Yuri Khan <yuri.v.khan@gmail.com>
To: Ergus <spacibba@aol.com>
Cc: Yuri D'Elia <wavexx@thregr.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow
Date: Mon, 24 Jun 2019 18:57:32 +0700 [thread overview]
Message-ID: <CAP_d_8UeyAaQ5QxFDwvR7WDnTY4nCT6xdXUo6+OCqc2h+Rg85g@mail.gmail.com> (raw)
In-Reply-To: <20190624111050.jindvg6j4hr5j226@Ergus>
On Mon, Jun 24, 2019 at 6:12 PM Ergus <spacibba@aol.com> wrote:
> 750| char* argv0 = realpath (argv[0], NULL);
> 751| if (!argv0)
> 752| fatal ("could not resolve realpath of \"%s\": %s",
> 752| argv0, strerror (errno));
This looks wrong. If we called realpath and it returned null, we’d
probably want the original argv[0] in the error message, not the null
result.
next prev parent reply other threads:[~2019-06-24 11:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 10:26 master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Yuri D'Elia
2019-06-24 11:10 ` Ergus
2019-06-24 11:57 ` Yuri Khan [this message]
2019-06-24 12:28 ` Ergus
2019-06-24 13:21 ` Daniel Colascione
2019-06-24 13:50 ` Ergus
2019-06-24 13:54 ` Daniel Colascione
2019-06-24 14:05 ` Ergus
2019-06-24 14:19 ` Ergus
2019-06-24 14:14 ` Andy Moreton
2019-06-24 14:52 ` Eli Zaretskii
2019-06-24 16:06 ` dancol
2019-06-24 17:23 ` Eli Zaretskii
2019-06-24 18:12 ` Daniel Colascione
2019-06-24 18:25 ` Eli Zaretskii
2019-06-24 17:12 ` Eli Zaretskii
2019-06-24 18:26 ` Andy Moreton
2019-06-24 18:44 ` Eli Zaretskii
2019-06-26 16:26 ` Eli Zaretskii
2019-06-26 16:58 ` Eli Zaretskii
2019-06-27 17:45 ` Ken Brown
2019-06-27 18:36 ` Eli Zaretskii
2019-06-27 19:56 ` Ken Brown
2019-06-24 15:01 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP_d_8UeyAaQ5QxFDwvR7WDnTY4nCT6xdXUo6+OCqc2h+Rg85g@mail.gmail.com \
--to=yuri.v.khan@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=spacibba@aol.com \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.