From: Yuri Khan <yuri.v.khan@gmail.com>
To: Filipe Silva <filipe.silva@gmail.com>
Cc: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>
Subject: Re: Seeking Advice about refactoring and advice snippet
Date: Fri, 10 Feb 2017 20:08:19 +0700 [thread overview]
Message-ID: <CAP_d_8UCVCh3iC509qOWguRxJ5Dx0MD7co1BwUcUx46Qugu17w@mail.gmail.com> (raw)
In-Reply-To: <CAEwkUWMyyUhBtdJ+vL=JmOR00N5MzzX84peqzPSyMy90hS0v=A@mail.gmail.com>
On Fri, Feb 10, 2017 at 6:43 PM, Filipe Silva <filipe.silva@gmail.com> wrote:
> The problem is that these lines:
>
> (message "DENIED! don't kill my precious *scratch*!!")
> (apply buffer-assassin arguments))))
>
> Are repeated in both functions, so I thought that I could apply the DRY
> principle
I cannot say anything useful regarding your approach, but I can’t help
noticing that you are trying to reduce duplication of two lines in two
functions. This is not likely to help maintainability significantly.
In Extreme Programming circles, there is a principle called Three
Strikes And You Refactor, which says that you only have enough data
for a meaningful refactoring when you see three instances of the same
pattern.
Until you encounter that third instance, you could follow the WET
principle instead: Write Everything Twice :)
next prev parent reply other threads:[~2017-02-10 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 11:43 Seeking Advice about refactoring and advice snippet Filipe Silva
2017-02-10 13:08 ` Yuri Khan [this message]
2017-02-10 16:22 ` Filipe Silva
2017-02-10 13:44 ` Narendra Joshi
2017-02-10 14:17 ` Chunyang Xu
2017-02-10 16:24 ` Filipe Silva
2017-02-10 17:02 ` Filipe Silva
2017-02-10 19:55 ` Stefan Monnier
2017-02-10 23:12 ` Filipe Silva
2017-02-11 0:01 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP_d_8UCVCh3iC509qOWguRxJ5Dx0MD7co1BwUcUx46Qugu17w@mail.gmail.com \
--to=yuri.v.khan@gmail.com \
--cc=filipe.silva@gmail.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.