From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Marcin Pajkowski Newsgroups: gmane.emacs.bugs Subject: bug#59465: Eglot does not advertise resolveSupport capabilities Date: Tue, 22 Nov 2022 21:24:39 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c6a02f05ee14f661" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32892"; mail-complaints-to="usenet@ciao.gmane.io" To: 59465@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 21:25:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxZpZ-0008KH-5W for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 21:25:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxZpI-0004Sg-3z; Tue, 22 Nov 2022 15:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxZpG-0004SN-RF for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxZpG-0001Vb-Ic for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxZpG-0001R9-8P for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Pajkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59465 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16691486975509 (code B ref -1); Tue, 22 Nov 2022 20:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Nov 2022 20:24:57 +0000 Original-Received: from localhost ([127.0.0.1]:52629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxZpB-0001Qn-6j for submit@debbugs.gnu.org; Tue, 22 Nov 2022 15:24:57 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxZp8-0001Qd-Cq for submit@debbugs.gnu.org; Tue, 22 Nov 2022 15:24:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxZp7-0004K0-Uz for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:24:53 -0500 Original-Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxZp6-0001TB-BZ for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:24:53 -0500 Original-Received: by mail-pj1-x102c.google.com with SMTP id b11so14192038pjp.2 for ; Tue, 22 Nov 2022 12:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=XgPZcKaIoS+PXSokSZQkeOEIC53USQxRcHjtv8Bs6hk=; b=MF5aHbuAmKvAZGcHTG/Z4Tu0Ov/SHXIDc0p22rboA/8sZYDS7jZj0a5vOVT0xduy8c oaSSf4UsO59hTIjZK7KFckyzEgD1QV8LSqPYjBRqK1Dm6iyJB/1EOozRilPv6Kg3SzUW uta6IPPFf1P0blE/AX+QNhTVWpejSvZ6zuLdeXSbk7Kf/6il9ZW3WS+xnaiOxPleJKP3 fLNySgQYTCvd7IPC3OtbK/98y+hRUQYL4Wje4BcKi/ydDskTg+THqUGbR2IXTgg3T1Ce plZJebEtUeqTOMP/2Wov0Zf/6ACgCw7nNIZ3j3Pp/zib7a2IiToM5ZDsgabr6DKIpn/E FZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XgPZcKaIoS+PXSokSZQkeOEIC53USQxRcHjtv8Bs6hk=; b=1YVSjDyLNsA89SdQkFSENVeqPjUEemdWfKabHBCnR/65mCnV6wlIiB05h5yEaGIFV/ /A/RXI9wISCZy1cyYVzRvVRQsuksqxurmVtjc6E5NZrkAGBgW+VvCyslmn6axGadfh09 WdNdGBE6qftlSrNzYPWHxoPOlAeNx//HEBgY5jqBKr1nzLL92JB9TrKz/7EhuTvFEdwZ d7utuTurZS5nPLq5AsjMiPM5KLBMZe9kFoss3w+ZQUmtM2NNFxTVI8qNBcwRkQ8mItFY xl8zh90rYZg9BX5FaKPPx10SKZ1ouuNs7tKoEhXzIKBEvxvA66B77F0sbdsOrJsrYo5C UPhA== X-Gm-Message-State: ANoB5pl37+B7ZZhURgDDlqK6ZaHo3L6rgoHaNalbW958yezxETFky8fg 0gcze5y5D+vgxvbDFUMI6y1KRbHzDPoEwD1ZG7Sn4lW7 X-Google-Smtp-Source: AA0mqf7s1CrpSN8GvC3nBfTdfXvY4GNX7hJSyVQN4GnPORcWH2pF2KeT/ufD6d5IHBWi3O9Oo+6mJiggYonIzDpcirE= X-Received: by 2002:a17:90a:7896:b0:218:6fd6:b693 with SMTP id x22-20020a17090a789600b002186fd6b693mr27468666pjk.29.1669148690479; Tue, 22 Nov 2022 12:24:50 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=marcin.pajkowski@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, THIS_AD=1.299 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248675 Archived-At: --000000000000c6a02f05ee14f661 Content-Type: multipart/alternative; boundary="000000000000c6a02905ee14f65f" --000000000000c6a02905ee14f65f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I added bug reference number to the commit message. Marcin pon., 21 lis 2022 o 22:04 Marcin Pajkowski napisa=C5=82(a): > Hi Emacs developers, > > I recently found that Eglot does not receive > completions with additional text edits from servers > that expect such capability to be advertised by client. > > This advertisement is required by rust-analyzer server > to provide completions for symbols that are not resolved > but can be automatically imported. > > This patch fixes this issue. > > Marcin > --000000000000c6a02905ee14f65f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I added bug reference nu= mber to the commit message.

Marcin
=
pon., = 21 lis 2022 o 22:04=C2=A0Marcin Pajkowski <marcin.pajkowski@gmail.com> napisa=C5=82(a):
Hi Em= acs developers,

I recently found that Eglot does not receive
comp= letions with additional text edits from servers
that expect such capabil= ity to be advertised by client.

This advertisement is required by ru= st-analyzer server
to provide completions for symbols that are not resol= ved
but can be automatically imported.

This patch fixes this issu= e.

Marcin
--000000000000c6a02905ee14f65f-- --000000000000c6a02f05ee14f661 Content-Type: text/x-patch; charset="US-ASCII"; name="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Disposition: attachment; filename="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lasnz96n0 RnJvbSBiMjkwZmFjZTI3OTJiMjU0YWQ5NTY3ZDAwNzIwNWU3MTVkYTQ4MjgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjaW4gUGFqa293c2tpIDxtYXJjaW4ucGFqa293c2tpQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAyMCBOb3YgMjAyMiAyMDowMzo1NyArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEVnbG90OiBBZHZlcnRpc2UgY29tcGxldGlvbi5yZXNvbHZlU3VwcG9ydCBjYXBhYmls aXRpZXMKClNvbWUgc2VydmVycyBhdm9pZCByZXBvcnRpbmcgY29tcGxldGlvbiBpdGVtcyB0aGF0 IHJlcXVpcmUKImFkZGl0aW9uYWxUZXh0RWRpdHMiIGNhcGFiaWxpdHkuIEFjdHVhbGx5IGVnbG90 LWNvbXBsZXRpb24tYXQtcG9pbnQKZnVuY3Rpb24gc3VwcG9ydHMgc3VjaCBmZWF0dXJlIHNvIGl0 IGNhbiBiZSBhZHZlcnRpc2VkIHRvIExTUCBzZXJ2ZXIuCgoqIGxpc3AvcHJvZ21vZGVzL2VnbG90 LmVsCiAgKGVnbG90LWNsaWVudC1jYXBhYmlsaXRpZXMpOiBBZHZlcnRpc2UgcmVzb2x2ZVN1cHBv cnQuICAoYnVnIzU5NDY1KQotLS0KIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgNCArKysrCiAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9k ZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCBiYmQ5MDJjMWM3Li5m YWIzYjFjYWMwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9lZ2xvdC5lbApAQCAtNzM3LDcgKzczNywxMCBAQCBlZ2xvdC1jbGllbnQtY2Fw YWJpbGl0aWVzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6anNvbi1mYWxzZSkKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmRlcHJlY2F0ZWRTdXBwb3J0IHQK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlc29sdmVTdXBwb3J0ICg6 cHJvcGVydGllcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFsiZG9jdW1lbnRhdGlvbiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgImRldGFpbHMiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsVGV4dEVkaXRz Il0pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDp0YWdTdXBwb3J0ICg6 dmFsdWVTZXQgWzFdKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpjb250 ZXh0U3VwcG9ydCB0KQogICAgICAgICAgICAgIDpob3ZlciAgICAgICAgICAgICAgKGxpc3QgOmR5 bmFtaWNSZWdpc3RyYXRpb24gOmpzb24tZmFsc2UKLS0KMi4zOC4xCg== --000000000000c6a02f05ee14f661--