Re: [elpa] master 9a3a508: Package transcribe added

Re: [elpa] master 9a3a508: Package transcribe added

[Stefan Monnier]

Thanks

> +;;;transcribe.el --- package for audio transcriptions
     ^^
The convention for ";;;" is to have a space between ";;;" and the rest.
If the package is only meant to be supported for Emacs>=24, I recommend
you add "-*- lexical-binding:t -*-".

> +;;Copyright 2014 David González Gándara

Oh and for ";;" as well.

> +(require 'emms-setup)

So your package only works with emms, in which case the pseudo-headers
should include

   ;; Package-Requires: ((emms "<version>")) 

or something like that.

> +;(require 'emms-player-mpd)
> +;(setq emms-player-mpd-server-name "localhost")
> +;(setq emms-player-mpd-server-port "6600")
> +
> +(emms-standard)
> +(emms-default-players)
> +(require 'emms-player-mpg321-remote)
> +(push 'emms-player-mpg321-remote emms-player-list)
> +
> +(require 'emms-mode-line)
> +(emms-mode-line 1)
> +(require 'emms-playing-time)
> +(emms-playing-time 1)
> +
> +(global-set-key (kbd "C-x C-p") 'emms-play-file)
> +
> +(global-set-key (kbd "<f5>") 'emms-pause)
> +
> +(global-set-key (kbd "C-x <down>") 'emms-stop)
> +
> +(global-set-key (kbd "C-x <right>") 'emms-seek-forward)
> +
> +(global-set-key (kbd "C-x <left>") 'emms-seek-backward)
> +
> +(global-set-key (kbd "<f8>") 'emms-seek)

I think those settings should be moved to a function: loading
transcribe.el should not make such global changes.  Instead they should
be made via a function.  Activating a mode/feature should never be made
with "require" or "load" but by calling a function (or setting a custom
var) which internally will load the file, if needed.

> +(defun analyze-episode (episode person)
> +  (interactive "sepisode: \nsperson:")

All definitions should use a package prefix, e.g. "transcribe-", so as
to avoid conflicts with other packages.

> +  (shell-command (concat (expand-file-name  "analyze_episodes2.py") " -e " episode " -p " person " -i " buffer-file-name )))

If your file is called "hello; rm -rf ~/." the above command will not do
what you wanted.  You can fix that by quoting the various parts with
shell-quote-argument, but I recommend you just use `call-process'
instead of `shell-command', since you don't make use of any
functionality of the shell, so the use of shell here only introduces
overheads and bugs.


        Stefan

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <dggandara-IGUgQLVVQiRCV4ILt04nZQ@public.gmane.org>
wrote:
>     Package transcribe added

Thanks for the package, David.

Besides the comments already made by Stefan, I just wanted to point out
that we now announce on emacs-devel before adding new packages to Elpa.
There's more information on the readme.
It's just a way of keeping everybody informed about new additions.

[-- Attachment #2: Type: text/html, Size: 588 bytes --]

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

> > +
> > +(global-set-key (kbd "C-x C-p") 'emms-play-file)
> > +
> > +(global-set-key (kbd "<f5>") 'emms-pause)
> > +
> > +(global-set-key (kbd "C-x <down>") 'emms-stop)
> > +
> > +(global-set-key (kbd "C-x <right>") 'emms-seek-forward)
> > +
> > +(global-set-key (kbd "C-x <left>") 'emms-seek-backward)
> > +
> > +(global-set-key (kbd "<f8>") 'emms-seek)
>
> I think those settings should be moved to a function:

Ideally to a minor-mode.

[-- Attachment #2: Type: text/html, Size: 712 bytes --]

Re: [elpa] master 9a3a508: Package transcribe added

[Artur Malabarba]

Artur Malabarba <bruce.connor.am-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <
> dggandara-IGUgQLVVQiRCV4ILt04nZQ@public.gmane.org> wrote:
>>     Package transcribe added
>
> I just wanted to point
> out that we now announce on emacs-devel before adding new packages to
> Elpa.

Oh wait. I see you did announce it. I kinda missed it because you wrote
Packed instead of Package. :-)

Re: [elpa] master 9a3a508: Package transcribe added

[David González Gándara]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Thanks for your patience and your suggestions with newbies. I tried to
apply all your advice. I am still fighting with git, I hope I don't break
anything.

On 30 November 2015 at 11:19, Artur Malabarba <bruce.connor.am@gmail.com>
wrote:

> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> > On 29 Nov 2015 12:38 pm, "David Gonzalez Gandara" <
> > dggandara@member.fsf.org> wrote:
> >>     Package transcribe added
> >
> > I just wanted to point
> > out that we now announce on emacs-devel before adding new packages to
> > Elpa.
>
> Oh wait. I see you did announce it. I kinda missed it because you wrote
> Packed instead of Package. :-)
>

[-- Attachment #2: Type: text/html, Size: 1176 bytes --]

Re: [elpa] master 9a3a508: Package transcribe added

[David González Gándara]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Thanks for your patience and your suggestions with newbies. I tried to
apply all your advice. I am still fighting with git, I hope I don't break
anything.

[-- Attachment #2: Type: text/html, Size: 182 bytes --]