From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Donovan via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70193: eglot: RFE: recenter buffer upon showDocument request Date: Thu, 4 Apr 2024 09:17:13 -0400 Message-ID: Reply-To: Alan Donovan Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3766"; mail-complaints-to="usenet@ciao.gmane.io" To: 70193@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 04 15:18:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsMyl-0000m8-K7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Apr 2024 15:18:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsMyf-0008Hm-QG; Thu, 04 Apr 2024 09:18:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsMyc-0008H7-Pq for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsMyb-0007V9-Ek for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsMyg-0004ZK-BQ for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Donovan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2024 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70193 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171223666917509 (code B ref -1); Thu, 04 Apr 2024 13:18:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Apr 2024 13:17:49 +0000 Original-Received: from localhost ([127.0.0.1]:60832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMyT-0004YL-Br for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:17:49 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:35794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMyQ-0004XS-TQ for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:17:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsMyF-000863-Kh for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:35 -0400 Original-Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsMyA-0007N3-DX for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:33 -0400 Original-Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e2add0b990so112405ad.0 for ; Thu, 04 Apr 2024 06:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712236647; x=1712841447; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Yirw83qEKFLjPIFTag5/4dGsiBHnfqbUeDEBhpn2TVY=; b=Kr3c1JPI4RQ1bFKLsB9vBu97MaRK1kU2MphbTrYdidGhib4LM8+eVd26+9/w46apKR eLxf6Tsb9/mF4clCS3nEquwY8hlyNR87NszCn7I8JwQwvNEPxCaP9ZAAa7gTLA34UJub QvL0UhEMjmj92Epm9fXDFGA4Zt+vyv1BQD9+uGg429JRaT8rXFjJL4iJJonSk42TkWUD jCg4vzDuewD9oDrRLjzv/aQVTOq1+qsXJ/U7Fa9QEHc9OQJH2Uqx44hXX3EOJ1UMRcfA nDHlBDRKMBjcOfdFHj5pRVZrlqD4YkJXtSXStPytod93DYU0bIPIKCsCnuL5zAmxTZqH vbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712236647; x=1712841447; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yirw83qEKFLjPIFTag5/4dGsiBHnfqbUeDEBhpn2TVY=; b=C8MSHRPiQOZiWMc8sBv2wWE9XGMhLDXd+FGcKkZfBDQ9FBMUiYat7r0MFb4WyBOedt R2LVtrvfPK971Jepz/0Ft4mghWbSHWxFT0FpM3cvCVYGYd7Ooa1pEXtad0kqOASA1fe7 FNKCW7obyhQTj6l243m+5fQeJCb1DmDkAJHy/MxMedT7/x657VF5T7+Vw5YM5mm3uHje fBC3prKAPyAbGx6GhUOUmZyiG7JAMBb4QNUu2vzTW5TCst4kx/ZSpHSrWPJz86aNguSQ QjRL0ME0huoPql9jBlM+7JQUfRglY8J4zJpRatW+zMY0XgVSuDrEwgEOXFUE/aD8HIsr hp4Q== X-Gm-Message-State: AOJu0YzGHkC+oq9NQazTzbcxSh8n+MvGFBGGxFsg/ehhz2E4TFovcam9 n4zVfrcKU4Y492s69eDVi/C+mzm4UGyoijdHhAhKIAkWSu1FGntJ+9PfUserDs04NlT7wmv0Ng6 h38VSPSJBkx1lBcA8icyIv4Qr5W6YaoiL79c6RZEBk7H0B+yy38Ad X-Google-Smtp-Source: AGHT+IGmgbQXLvW/ZIq65Awk2ljjU2+S0jEDTAMHlVLniDHFUHBy36gP3NBio6jKzIozUNYCnll84GIA7hO9VFj3CVA= X-Received: by 2002:a17:903:1d1:b0:1e0:b385:838f with SMTP id e17-20020a17090301d100b001e0b385838fmr79279plh.1.1712236646740; Thu, 04 Apr 2024 06:17:26 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=adonovan@google.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282646 Archived-At: In eglot 1.17, the LSP showDocument downcall opens the designated file, moves the cursor to the designated position, and raises the frame. One other thing it could do to make it easier to see where the cursor is would be to recenter the buffer. The patch below is a minimal fix; the discussion at https://github.com/joaotavora/eglot/discussions/1382 suggests a couple of possible refinements. xtools$ git diff ~/.emacs.d/elpa/eglot-1.17/eglot.el{.bak,} --- elpa/eglot-1.17/eglot.el.orig +++ elpa/eglot-1.17/eglot.el @@ -2460,6 +2460,7 @@ THINGS are either registrations or unregisterations (sic)." ;; function, but `xref--goto-char' happens to have ;; exactly the semantics we want vis-a-vis widening. (xref--goto-char beg) + (recenter) (pulse-momentary-highlight-region beg end 'highlight))))))) (t (setq success :json-false))) `(:success ,success)))