* [PATCH] org.el: Inhibit insertion of superfluous space character in org-add-planning-info.
@ 2011-08-08 13:48 Valentin Wüstholz
2011-08-16 17:05 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Wüstholz @ 2011-08-08 13:48 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
Hi,
I've noticed that org-add-planning-info adds a superfluous space
character when a repeated task is marked as DONE and gets rescheduled.
Example:
* TODO foo
SCHEDULED: <2011-08-08 Mon +1d>
This becomes (after pressing Shift-Right a few times):
* TODO foo
SCHEDULED: <2011-08-09 Tue +1d>
:LOGBOOK:
- State "DONE" from "WAITING" [2011-08-08 Mon 15:33]
:END:
:PROPERTIES:
:LAST_REPEAT: [2011-08-08 Mon 15:33]
:END:
Note the additional space character before "SCHEDULED".
I've attached a patch that seems to fix this issue.
Best regards,
Valentin
[-- Attachment #2: org.el.diff.txt --]
[-- Type: text/plain, Size: 500 bytes --]
diff --git a/lisp/org.el b/lisp/org.el
index 11eaf78..d2fb343 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11914,7 +11914,7 @@ be removed."
(re-search-forward org-closed-time-regexp nil t)))
(replace-match "")
(if (looking-at "--+<[^>]+>") (replace-match ""))))
- (and (looking-at "^[ \t]+") (replace-match ""))
+ (and (looking-at "[ \t]+") (replace-match ""))
(and org-adapt-indentation (bolp) (org-indent-to-column col))
(when what
(insert
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] org.el: Inhibit insertion of superfluous space character in org-add-planning-info.
2011-08-08 13:48 [PATCH] org.el: Inhibit insertion of superfluous space character in org-add-planning-info Valentin Wüstholz
@ 2011-08-16 17:05 ` Bastien
2011-08-16 21:25 ` Valentin Wüstholz
0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2011-08-16 17:05 UTC (permalink / raw)
To: Valentin Wüstholz; +Cc: emacs-orgmode
Hi Valentin,
Valentin Wüstholz <wuestholz@gmail.com> writes:
> I've noticed that org-add-planning-info adds a superfluous space
> character when a repeated task is marked as DONE and gets rescheduled.
Patch applied, thanks.
For the next patch, can you include the ChangeLog entry?
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] org.el: Inhibit insertion of superfluous space character in org-add-planning-info.
2011-08-16 17:05 ` Bastien
@ 2011-08-16 21:25 ` Valentin Wüstholz
0 siblings, 0 replies; 3+ messages in thread
From: Valentin Wüstholz @ 2011-08-16 21:25 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
Hi Bastien.
On Tue, Aug 16, 2011 at 7:05 PM, Bastien <bzg@altern.org> wrote:
> Hi Valentin,
>
> Valentin Wüstholz <wuestholz@gmail.com> writes:
>
>> I've noticed that org-add-planning-info adds a superfluous space
>> character when a repeated task is marked as DONE and gets rescheduled.
>
> Patch applied, thanks.
>
> For the next patch, can you include the ChangeLog entry?
Sure! I had thought that that wasn't necessary for very small changes.
Thanks,
Valentin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-16 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 13:48 [PATCH] org.el: Inhibit insertion of superfluous space character in org-add-planning-info Valentin Wüstholz
2011-08-16 17:05 ` Bastien
2011-08-16 21:25 ` Valentin Wüstholz
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.