* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
@ 2023-11-24 15:25 Noah Peart
2023-11-24 18:43 ` Eli Zaretskii
2023-11-24 18:47 ` Dmitry Gutov
0 siblings, 2 replies; 6+ messages in thread
From: Noah Peart @ 2023-11-24 15:25 UTC (permalink / raw)
To: 67433
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
Tags: patch
* lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
to treesit-font-lock-feature-list in typescript-ts-mode.
Bug: `typescript-ts-mode` defines `operator` font-locking feature but
doesn't add
it to `treesit-font-lock-feature-list`.
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-24 built on noah-X580VD
Repository revision: 0858d10aebed44f7d66548d061af03b3cb136d04
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[-- Attachment #1.2: Type: text/html, Size: 1007 bytes --]
[-- Attachment #2: typescript-ts-mode-operator.patch --]
[-- Type: text/x-patch, Size: 982 bytes --]
From 109231f729afdd51b32838414c477d0a56dfccb1 Mon Sep 17 00:00:00 2001
From: nverno <noah.v.peart@gmail.com>
Date: Fri, 24 Nov 2023 07:18:26 -0800
Subject: [PATCH] Fix typescript-ts-mode add missing operator font-lock feature
---
lisp/progmodes/typescript-ts-mode.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
index b6d5495adbb..0503c724d36 100644
--- a/lisp/progmodes/typescript-ts-mode.el
+++ b/lisp/progmodes/typescript-ts-mode.el
@@ -483,7 +483,7 @@ typescript-ts-mode
'((comment declaration)
(keyword string escape-sequence)
(constant expression identifier number pattern property)
- (function bracket delimiter)))
+ (operator function bracket delimiter)))
(setq-local syntax-propertize-function #'typescript-ts--syntax-propertize)
(treesit-major-mode-setup)))
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
2023-11-24 15:25 bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list Noah Peart
@ 2023-11-24 18:43 ` Eli Zaretskii
2023-11-24 18:51 ` Dmitry Gutov
2023-11-24 18:47 ` Dmitry Gutov
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-11-24 18:43 UTC (permalink / raw)
To: Noah Peart, Yuan Fu; +Cc: 67433
> From: Noah Peart <noah.v.peart@gmail.com>
> Date: Fri, 24 Nov 2023 07:25:17 -0800
>
> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> to treesit-font-lock-feature-list in typescript-ts-mode.
>
> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
> it to `treesit-font-lock-feature-list`.
>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
Thanks, but please always try to test in Emacs 29 and tell if the
problem happens there as well. It is important for us to know on
which branch to fix the problem.
Yuan, any comments?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
2023-11-24 18:43 ` Eli Zaretskii
@ 2023-11-24 18:51 ` Dmitry Gutov
2023-11-25 7:04 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2023-11-24 18:51 UTC (permalink / raw)
To: Eli Zaretskii, Noah Peart, Yuan Fu; +Cc: 67433
On 24/11/2023 20:43, Eli Zaretskii wrote:
>> From: Noah Peart<noah.v.peart@gmail.com>
>> Date: Fri, 24 Nov 2023 07:25:17 -0800
>>
>> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
>> to treesit-font-lock-feature-list in typescript-ts-mode.
>>
>> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
>> it to `treesit-font-lock-feature-list`.
>>
>> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> Thanks, but please always try to test in Emacs 29 and tell if the
> problem happens there as well. It is important for us to know on
> which branch to fix the problem.
>
> Yuan, any comments?
Sorry, I've already installed the patch.
The setting was missing from the very beginning, so the problem was in
emacs-29.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
2023-11-24 18:51 ` Dmitry Gutov
@ 2023-11-25 7:04 ` Eli Zaretskii
2023-11-25 12:20 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-11-25 7:04 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: noah.v.peart, casouri, 67433
> Date: Fri, 24 Nov 2023 20:51:19 +0200
> Cc: 67433@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 24/11/2023 20:43, Eli Zaretskii wrote:
> >> From: Noah Peart<noah.v.peart@gmail.com>
> >> Date: Fri, 24 Nov 2023 07:25:17 -0800
> >>
> >> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> >> to treesit-font-lock-feature-list in typescript-ts-mode.
> >>
> >> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
> >> it to `treesit-font-lock-feature-list`.
> >>
> >> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > Thanks, but please always try to test in Emacs 29 and tell if the
> > problem happens there as well. It is important for us to know on
> > which branch to fix the problem.
> >
> > Yuan, any comments?
>
> Sorry, I've already installed the patch.
Thanks, but please in the future wait for a little longer, unless the
problem is obvious (like a typo or a syntax error).
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
2023-11-25 7:04 ` Eli Zaretskii
@ 2023-11-25 12:20 ` Dmitry Gutov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Gutov @ 2023-11-25 12:20 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: noah.v.peart, casouri, 67433
On 25/11/2023 09:04, Eli Zaretskii wrote:
>> Date: Fri, 24 Nov 2023 20:51:19 +0200
>> Cc:67433@debbugs.gnu.org
>> From: Dmitry Gutov<dmitry@gutov.dev>
>>
>> On 24/11/2023 20:43, Eli Zaretskii wrote:
>>>> From: Noah Peart<noah.v.peart@gmail.com>
>>>> Date: Fri, 24 Nov 2023 07:25:17 -0800
>>>>
>>>> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
>>>> to treesit-font-lock-feature-list in typescript-ts-mode.
>>>>
>>>> Bug: `typescript-ts-mode` defines `operator` font-locking feature but doesn't add
>>>> it to `treesit-font-lock-feature-list`.
>>>>
>>>> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
>>> Thanks, but please always try to test in Emacs 29 and tell if the
>>> problem happens there as well. It is important for us to know on
>>> which branch to fix the problem.
>>>
>>> Yuan, any comments?
>> Sorry, I've already installed the patch.
> Thanks, but please in the future wait for a little longer, unless the
> problem is obvious (like a typo or a syntax error).
Ok, I will. But it was pretty obvious to me (unused font-lock rules).
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list
2023-11-24 15:25 bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list Noah Peart
2023-11-24 18:43 ` Eli Zaretskii
@ 2023-11-24 18:47 ` Dmitry Gutov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Gutov @ 2023-11-24 18:47 UTC (permalink / raw)
To: Noah Peart, 67433-done
Version: 29.2
On 24/11/2023 17:25, Noah Peart wrote:
> Tags: patch
>
>
> * lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add operator
> to treesit-font-lock-feature-list in typescript-ts-mode.
>
> Bug: `typescript-ts-mode` defines `operator` font-locking feature but
> doesn't add
> it to `treesit-font-lock-feature-list`.
Thanks! Installed.
Suggestion for the future: it would be a bit more helpful when the
commit message are inside the patch file already. So 'git am' puts it in
the commit without additional copying required.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-25 12:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-24 15:25 bug#67433: [PATCH] Fix typescript-ts-mode add operator to treesit-font-lock-feature-list Noah Peart
2023-11-24 18:43 ` Eli Zaretskii
2023-11-24 18:51 ` Dmitry Gutov
2023-11-25 7:04 ` Eli Zaretskii
2023-11-25 12:20 ` Dmitry Gutov
2023-11-24 18:47 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.