From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noah Peart Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Thu, 27 Jun 2024 05:29:21 -0400 Message-ID: References: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> <8634pewsej.fsf@gnu.org> <8634oy7s3s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b946be061bdbc44c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 11:31:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMlTA-0002xi-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 11:31:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMlT4-0004aA-0j; Thu, 27 Jun 2024 05:31:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMlT1-0004ZQ-Vd for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:31:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMlT1-0006xX-Hj for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:30:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMlT4-0000Xf-AF for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noah Peart Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.17194806432058 (code B ref 71209); Thu, 27 Jun 2024 09:31:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 27 Jun 2024 09:30:43 +0000 Original-Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMlSl-0000X8-8t for submit@debbugs.gnu.org; Thu, 27 Jun 2024 05:30:43 -0400 Original-Received: from mail-oa1-f50.google.com ([209.85.160.50]:45548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMlSj-0000Wv-99 for 71209@debbugs.gnu.org; Thu, 27 Jun 2024 05:30:42 -0400 Original-Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-25c95299166so3882223fac.3 for <71209@debbugs.gnu.org>; Thu, 27 Jun 2024 02:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719480573; x=1720085373; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uu9URVVf2zfw8ZH72aZLjeuYKiosdBUzYW5BbAjmWtw=; b=iMBypmeznzVrdshp98YgXuXvc1lIhbDnh2CFzGXpuPaU1s1oDNEt1/i76aY3cn9he1 pNZk7qpcx6oZ3w6ReQDLbCtBZu2Xc/0ayWTiT5ex7qATqryEw4clRGBCqt8WaGgGAMnr hEf8SyBoBSHwJSPmSDT7xaCfXVxT6eju5M5D5VeyoIon3wYPP8zDJt+RI8RdK9AsDF/9 IaeogS7iIRFbzoFgpvX//B1DfkfnR2aJuOlsXEBvszrDpN1QrFchqmICNw6JQMVg6dDJ yyFQzr0aMkBgN3QdfJ0EnkwVJCedHBIfJEAl/bZzdoa1Jp5nA2MV89Z/nREL79JwLPOX fSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719480573; x=1720085373; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uu9URVVf2zfw8ZH72aZLjeuYKiosdBUzYW5BbAjmWtw=; b=dECw6Tqbqc9rc2mgwO2U1j0OL0sVqTKr/k4KcrlekMady37ObOJxJ9PMmsGyQvVRDA Rvo4sTeDed83pYQ5YFUmXlK+aBMLC74B+4yBcp38ZGmz/vQbC9IXTcNqAmiOpTRBMfGG TpPftG+SGa79saZrTl/LmJSEKvxzeQqBdI6OC8MoYZz0zs4/Ba9crFA+N6LoydxmceVE XdxVDnQWp5cdFRMeZw39SkaU1a4rY0Wdn3gQdXatubgWHnFUw6If5DDJiOWMPtag2OJs hVCKoZlLdhXAO+dpqQHPlAJCBIW1ix7h9DzRFvsmZf2PLpLlZsKw8KbovhThIB0lQPSe FqGg== X-Forwarded-Encrypted: i=1; AJvYcCX9vpnfy7oaXsKnSyAETko2oC717yHqPm6TdKHEWtcer4RK7LHInfgFYBAsInltu1r/FQVKjJNMwWPKtOhXdqcgnWvSOuM= X-Gm-Message-State: AOJu0Yzruk4OX0opMAwAqwVlEZIv/LK+n7L8z4QtEUgRUzuGz7bnHHwb NNChrYY8zH2vWVdpOisQ3GhScO0EGt/l0UW+3x5rng0OpU0BdGA69ZXsezLNHYf3JMWQIs49psK gENdiGTqdc0/E6553/knpPVmDh1k= X-Google-Smtp-Source: AGHT+IEFAA8LDXtHGaniBqAYQ9kebzptGEDO2gdraPZGyEUawgxPnBNMn0P+RPPJSuKC3w5EWrA12n+rv5LykT71gN8= X-Received: by 2002:a05:6870:5a90:b0:258:42c8:867f with SMTP id 586e51a60fabf-25cfce0118dmr9791743fac.20.1719480572525; Thu, 27 Jun 2024 02:29:32 -0700 (PDT) In-Reply-To: <8634oy7s3s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288004 Archived-At: --000000000000b946be061bdbc44c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! On Thu, Jun 27, 2024 at 3:38=E2=80=AFAM Eli Zaretskii wrote: > Ping! Ping! Noah, are you still interested in working on this? > > > Cc: 71209@debbugs.gnu.org, dev@rjt.dev > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > From: Eli Zaretskii > > > > Ping! Noah, would you please answer Dmitry? > > > > > Cc: 71209@debbugs.gnu.org > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > From: Dmitry Gutov > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > ;; for (auto x: ...) > > > > (for_range_loop > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > ;; auto& x > > > > (reference_declarator > > > > (identifier) @font-lock-variable-name-face) > > > > ;; auto[&] [x, y] > > > > (structured_binding_declarator > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > I suppose most people keep the default font-locking for variable-na= me > > > > and variable-use, so these missing rules go unnoticed. > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > --000000000000b946be061bdbc44c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ah yes, sorry to=C2=A0be slow, I can submit a patch for th= ose settings.=C2=A0 I'll take a look today!

On Thu, Jun 27, 2024 at 3:38= =E2=80=AFAM Eli Zaretskii <eliz@gnu.org<= /a>> wrote:
P= ing! Ping!=C2=A0 Noah, are you still interested in working on this?

> Cc: 71209@d= ebbugs.gnu.org, dev@rj= t.dev
> Date: Sat, 15 Jun 2024 10:56:36 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Ping!=C2=A0 Noah, would you please answer Dmitry?
>
> > Cc: 71= 209@debbugs.gnu.org
> > Date: Sat, 1 Jun 2024 17:13:57 +0300
> > From: Dmitry Gutov <dmitry@gutov.dev>
> >
> > On 01/06/2024 04:42, Noah Peart wrote:
> > >
> > > I've been using these for c++, I think they are still mi= ssing
> > >
> > >=C2=A0 =C2=A0 =C2=A0 ;; for (auto x: ...)
> > >=C2=A0 =C2=A0 =C2=A0 (for_range_loop
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0declarator: (identifier) @font-loc= k-variable-name-face)
> > >=C2=A0 =C2=A0 =C2=A0 ;; auto& x
> > >=C2=A0 =C2=A0 =C2=A0 (reference_declarator
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0(identifier) @font-lock-variable-n= ame-face)
> > >=C2=A0 =C2=A0 =C2=A0 ;; auto[&] [x, y]
> > >=C2=A0 =C2=A0 =C2=A0 (structured_binding_declarator
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0_ [(identifier)] @font-lock-variab= le-name-face)
> > >
> > > I suppose most people keep the default font-locking for vari= able-name
> > > and variable-use, so these missing rules go unnoticed.
> >
> > Do you want to submit a full patch with these as well?
> >
> >
> >
> >
>
>
>
>
--000000000000b946be061bdbc44c--