From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: nvp Newsgroups: gmane.emacs.bugs Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed Date: Mon, 9 Oct 2023 23:02:48 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000007220cf06075675ae" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5788"; mail-complaints-to="usenet@ciao.gmane.io" To: 66431@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 10 08:04:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qq5qi-0001HE-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Oct 2023 08:04:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qq5qK-0001Q9-Ac; Tue, 10 Oct 2023 02:03:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qq5qI-0001Pg-D9 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 02:03:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qq5qI-0004mk-5H for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 02:03:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qq5qc-0006FV-Ko for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 02:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: nvp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2023 06:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169691783223994 (code B ref -1); Tue, 10 Oct 2023 06:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Oct 2023 06:03:52 +0000 Original-Received: from localhost ([127.0.0.1]:33833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq5qR-0006Ew-VC for submit@debbugs.gnu.org; Tue, 10 Oct 2023 02:03:52 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:53520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq5qN-0006Ef-NK for submit@debbugs.gnu.org; Tue, 10 Oct 2023 02:03:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qq5px-0001Nz-4E for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 02:03:21 -0400 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qq5pd-0004b5-C0 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 02:03:17 -0400 Original-Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6c0b8f42409so3638966a34.0 for ; Mon, 09 Oct 2023 23:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696917779; x=1697522579; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=NE5mT8SpCb3XS2f1MaUiu3w3F+JEVxC9drOHRiiGe74=; b=jF720ANLV/m8D6KBiRVHGV7kaVvkTipiX5xC5jPCNSL/zmMyGd7/2ikTs0ZTBmgz+w snqJ1D1azKarlNd6MD0+sYUGHD5WyMjbZKTKeq84qtSxQBfpzPc0mQbcCBMZQuf8BHpz Lq8b9VqFCG/NIDNo0N98/ArrDqFPQvBOI4znuGjYTkpHtXp1q/kDq3/KSfMafUWT8p3B QiiRGdTtaTPDqKA6jUF+slQEj4o5Zm+YUHFGYCI7YvffI+KHrxi/4terQjO9PRsh3sEG w7s28f8djB227y6FNdnmz/KQizaYJ9juBrj2nV8jpB2NMQU7Y8RzRqhMbmCWeD0i4df6 zHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696917779; x=1697522579; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NE5mT8SpCb3XS2f1MaUiu3w3F+JEVxC9drOHRiiGe74=; b=AGNfftUO9R+wi2vBY3eyBWyALb9Q0kqUhsqbhB5Vy+yU468z/4n7hQdgzGpTBcpN3c Xn92IUtSwC20sYY7GWEwtQG/Ad+gekfuYqCK9wMJfXjk9LLPnqTp2Gkr2NyybpmMMHrZ 3UnSH83Y5bzEeVQgRpsRbiIZmlYep12K7Nm0oz/x9z3EhrfMxTgActWamUaxxCnZQmd9 NEXMFL/hoGQeDIEA4CHGcV7WuVWJ5VsAxL2sQ3WAgQpwthWuWq3OVwEva7IavH6hU3eG +d/iH4tPOc9kuryJmdnSHQEfWMjAXxFbKlOn+Km6bmKI1Fw26rc2zv8sH4FKO2/wxqo/ CmOg== X-Gm-Message-State: AOJu0YzO7rLgGTQxfdh66DJZO40tVwLoJcNOPnwxWlT2QNOjNoGM/E0Y sndINSHOrdGRopJ6cyFQWlrgMJ0PYhe+T9HoXZYK7UL4LeMzd/Id X-Google-Smtp-Source: AGHT+IFWS/MNm6N9W8BFtOMAR3bH1jTnRLqnCEDQriBvwf7vsqPPQYSi4+oPRVrlxOJdgiK6o+Bmu/Mz7Fg5oUwLWtE= X-Received: by 2002:a05:6871:ae81:b0:1e9:732e:d6ba with SMTP id zs1-20020a056871ae8100b001e9732ed6bamr81225oab.15.1696917779253; Mon, 09 Oct 2023 23:02:59 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=noah.v.peart@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272182 Archived-At: --0000000000007220cf06075675ae Content-Type: multipart/alternative; boundary="0000000000007220cd06075675ac" --0000000000007220cd06075675ac Content-Type: text/plain; charset="UTF-8" Tags: patch Bug: After `treesit-explorer-mode` is enabled in a buffer and its associated `treesit--explorer-buffer` is killed, a subsequent call to `treesit-explorer-mode` initially displays an empty explorer buffer b/c `treesit--explorer-refresh` sees old value for `treesit--explorer-last-node`. * lisp/treesit.el (treesit-explorer-mode): reset `treesit--explorer-last-node` when `treesit--explorer-buffer` was killed In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --0000000000007220cd06075675ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch


Bug: After `treesit-explorer-m= ode` is enabled in a buffer and its
associated `treesit--explorer-buffer= ` is killed, a subsequent call
to `treesit-explorer-mode` initially disp= lays an empty explorer
buffer b/c `treesit--explorer-refresh` sees old v= alue for
`treesit--explorer-last-node`.

* lisp/treesit.el (treesi= t-explorer-mode): reset
`treesit--explorer-last-node` when `treesit--exp= lorer-buffer` was killed

In GNU Emacs 30.0.50 (build 1, x86_64-pc-li= nux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-05 built= on noah-X580VD
Repository revision: 505c80623049d9e181918acdac8229c9a20= 41b1e
Repository branch: master
Windowing system distributor 'The= X.Org Foundation', version 11.0.12101004
System Description: Ubuntu= 22.04.3 LTS

Configured using:
=C2=A0'configure --prefix=3D/u= sr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolk= it=3Dgtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --w= ith-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --wit= h-imagemagick CC=3Dgcc-12
CXX=3Dgcc-12'

--0000000000007220cd06075675ac-- --0000000000007220cf06075675ae Content-Type: text/x-patch; charset="US-ASCII"; name="fix-treesit-explorer-last-node.patch" Content-Disposition: attachment; filename="fix-treesit-explorer-last-node.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnjwzeur0 RnJvbSBmMGQ0MjAxMzNiNThkMDUwNjE3M2YyZjE1Mzk4NjdiMmQ5ZTdmMDE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgOSBPY3QgMjAyMyAyMjo1MjozOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCByZXNl dCB0cmVlc2l0LS1leHBsb3Jlci1sYXN0LW5vZGUKCi0tLQogbGlzcC90cmVlc2l0LmVsIHwgMSAr CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saXNwL3RyZWVz aXQuZWwgYi9saXNwL3RyZWVzaXQuZWwKaW5kZXggNDAyNDE3YzZjYTkuLmU3OThhYmFjMDc5IDEw MDY0NAotLS0gYS9saXNwL3RyZWVzaXQuZWwKKysrIGIvbGlzcC90cmVlc2l0LmVsCkBAIC0zMTky LDYgKzMxOTIsNyBAQCB0cmVlc2l0LWV4cGxvcmUtbW9kZQogICAgICAgICAgICAgICAgICAgICAg ICAgIChmb3JtYXQgIip0cmVlLXNpdHRlciBleHBsb3JlciBmb3IgJXMqIgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGJ1ZmZlci1uYW1lKSkpKQogICAgICAgICAgICAgKHNldHEt bG9jYWwgdHJlZXNpdC0tZXhwbG9yZXItbGFuZ3VhZ2UgbGFuZ3VhZ2UpCisgICAgICAgICAgICAo c2V0cS1sb2NhbCB0cmVlc2l0LS1leHBsb3Jlci1sYXN0LW5vZGUgbmlsKQogICAgICAgICAgICAg KHdpdGgtY3VycmVudC1idWZmZXIgdHJlZXNpdC0tZXhwbG9yZXItYnVmZmVyCiAgICAgICAgICAg ICAgICh0cmVlc2l0LS1leHBsb3Jlci10cmVlLW1vZGUpKSkKICAgICAgICAgICAoZGlzcGxheS1i dWZmZXIgdHJlZXNpdC0tZXhwbG9yZXItYnVmZmVyCi0tIAoyLjM0LjEKCg== --0000000000007220cf06075675ae--