From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noah Peart Newsgroups: gmane.emacs.bugs Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Sat, 13 Apr 2024 00:40:38 -0700 Message-ID: References: <86plutraj0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d1342a0615f5817c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4974"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70362@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 09:42:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvY1W-00017H-O9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 09:42:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvY1N-0001kD-QF; Sat, 13 Apr 2024 03:41:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvY1L-0001jo-FA for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:41:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvY1I-00036q-UP for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:41:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvY1T-0004EZ-7b for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:42:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noah Peart Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 07:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70362-submit@debbugs.gnu.org id=B70362.171299406815769 (code B ref 70362); Sat, 13 Apr 2024 07:42:03 +0000 Original-Received: (at 70362) by debbugs.gnu.org; 13 Apr 2024 07:41:08 +0000 Original-Received: from localhost ([127.0.0.1]:59992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY0a-00046H-2L for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:41:08 -0400 Original-Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]:48277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY0X-00044I-HM for 70362@debbugs.gnu.org; Sat, 13 Apr 2024 03:41:06 -0400 Original-Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-22fa18566adso724499fac.0 for <70362@debbugs.gnu.org>; Sat, 13 Apr 2024 00:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712994049; x=1713598849; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5jJ0Rk8g3hrLmyRqEtVJpcDYQ4mQxoM5Ge7wSVhgvxw=; b=DCtQ5GyoR1zqQOdKNWZnr2kJjcjziyDu2FKvVxl2J1ZTpnIUjF7YLeMAgEttx5J6qS kLV4sU4NCb8pm5xAx7qJ5JPvFcu5YR3H8AR6p3A2K2rlPBFDBjaQx0OlQNpIXcn3ynka 98xtRe8EkbaE4lmfO9Q7uw0AyoJQlbe3v5hfRYBm6GxoYZqgCZZjUKqZ4Rdv8Y9462af xI24XYkEgeAcGzdywlRIhaiOrus5r8b16aqF+y+vILRD/EuBjUu4HmBnP8/dlgU+Dav0 OodDeiCRAfwZablI1X3vGUKIzo5dDq4AL9j/L1yU/uc9Htv35Ybx8xbgN2cLWGXVOowr 1QiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712994049; x=1713598849; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5jJ0Rk8g3hrLmyRqEtVJpcDYQ4mQxoM5Ge7wSVhgvxw=; b=hqCrQJmpcFDOrmw7Buz51tyz++wW+82kpaCRQ/+jPRVswLDcXEpukU4sHuae2rDS6L 1ByJsyltPiNMpwUdKWkSM2PRT/0V9x/ttUUtIn1yVcUvX1il7iLamGV12EjmrqB1gdg6 8k+8B2uB7GdE95S9fMtOx+uc91kkItACyJHHHriSRW5rUq6RyvFkwfVYX2wLhBQGMF/5 D65z3XwiNGToPUvycGYsEyx8VPp+fn8frAf9IbYt77daEgac6xq7oaHsroAeoTwL2s2S stCohntHik9jbR17CoFy6Nhlm6sRMUjwoGU6k9lUQ7JORmcCyEU2deFysh8IbyFeKPMF QYXw== X-Gm-Message-State: AOJu0YzB0OV8mHb2y61eH4NckKgfsc41ehZxj0m4cuvIC5BzeNM4EKnV YHV6eSCUHL6MJ4YB2XKDBxcS0p4UKrLyhHzeBoBdlJh2R4VSdXtZdBkPaXOSa7fv0MxuZS23Bc8 DbejfGaPHSFqwFtLqpI/WtCePccdxIXB8xhM= X-Google-Smtp-Source: AGHT+IHkPhtpn9bHVLVz/oc2hStFDIktA2b5cah7J3wS4DmozJOpPFbuRgWOFIrjU70VT8mdr7Peu4CQSJJovuIidCQ= X-Received: by 2002:a05:6870:f613:b0:22e:caed:bc2 with SMTP id ek19-20020a056870f61300b0022ecaed0bc2mr5501865oab.8.1712994049403; Sat, 13 Apr 2024 00:40:49 -0700 (PDT) In-Reply-To: <86plutraj0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283175 Archived-At: --000000000000d1342a0615f5817c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I put it at level 3 following the conventions in other treesit modes I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put builtins at level 3. But, I haven't done a full census of the ts modes so there might be variability. On Sat, Apr 13, 2024 at 12:23=E2=80=AFAM Eli Zaretskii wrote= : > > From: Noah Peart > > Date: Fri, 12 Apr 2024 22:47:37 -0700 > > > > This patch adds a new `builtin` feature to > > `treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding > > rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in > functions. > > Thanks. > > I will ask here as well: at what level of font-lock will this be > fontified? I think it should be fontified only on level 4. > --000000000000d1342a0615f5817c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I put it at level 3 following the conventions in other tre= esit modes
I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all pu= t builtins at level 3.
But, I haven't done a full census of t= he ts modes so there might be variability.

On Sat, Apr 13, 2024 at 12:= 23=E2=80=AFAM Eli Zaretskii <eliz@gnu.or= g> wrote:
> From: Noah Peart <noah.v.peart@gmail.com>
> Date: Fri, 12 Apr 2024 22:47:37 -0700
>
> This patch adds a new `builtin` feature to
> `treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding > rule to `go-ts-mode--font-lock-settings` to highlight Go's built-i= n functions.

Thanks.

I will ask here as well: at what level of font-lock will this be
fontified?=C2=A0 I think it should be fontified only on level 4.
--000000000000d1342a0615f5817c--