all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noah Peart <noah.v.peart@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70361@debbugs.gnu.org
Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode.
Date: Sat, 13 Apr 2024 00:32:59 -0700	[thread overview]
Message-ID: <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@mail.gmail.com> (raw)
In-Reply-To: <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

On a somewhat related note, I was wondering why the treesit modes in emacs
define their `treesit-font-lock-feature-list`s in the mode definitions.

Wouldn't it be more user-friendly to `defvar` the feature list?

On Sat, Apr 13, 2024 at 12:27 AM Noah Peart <noah.v.peart@gmail.com> wrote:

> > The operators will be fontified only if treesit-font-lock-level is 4,
> right?
>
> Yea, operator is at level 4 - I didn't change the
> treesit-font-lock-feature-list.
>
>
>
> On Sat, Apr 13, 2024 at 12:20 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > From: Noah Peart <noah.v.peart@gmail.com>
>> > Date: Fri, 12 Apr 2024 22:23:05 -0700
>> >
>> > Adds font-locking for Go operators in `go-ts-mode'. The operator feature
>> > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` -
>> this
>> > just adds the missing rule to `go-ts-mode--font-lock-settings'.
>>
>> Thanks.
>>
>> The operators will be fontified only if treesit-font-lock-level is 4,
>> right?  That's the level at which we decided to fontify operators.
>>
>

[-- Attachment #2: Type: text/html, Size: 1809 bytes --]

  reply	other threads:[~2024-04-13  7:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  5:23 bug#70361: [PATCH] Add font-locking for operators in go-ts-mode Noah Peart
2024-04-13  7:20 ` Eli Zaretskii
2024-04-13  7:27   ` Noah Peart
2024-04-13  7:32     ` Noah Peart [this message]
2024-04-13  7:40       ` Eli Zaretskii
2024-04-13  7:53         ` Noah Peart
2024-04-13  9:33           ` Eli Zaretskii
2024-04-14 23:25 ` Yuan Fu
2024-04-14 23:34 ` Yuan Fu
2024-04-15 12:05   ` Noah Peart
2024-04-16  1:49 ` Randy Taylor
2024-04-16  5:57 ` Yuan Fu
2024-04-16  5:58 ` Yuan Fu
2024-04-16 12:34   ` Eli Zaretskii
2024-04-17  2:47 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@mail.gmail.com \
    --to=noah.v.peart@gmail.com \
    --cc=70361@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.