From: Noah Peart <noah.v.peart@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: 70361@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode.
Date: Mon, 15 Apr 2024 05:05:17 -0700 [thread overview]
Message-ID: <CAPVBTSdYzbV7vdXAH3Zzcqu0E7XLwx=+x+zUmr6izxEAQ9y4bQ@mail.gmail.com> (raw)
In-Reply-To: <F1B36231-4F75-49E8-9194-4DEC22F3EC43@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2516 bytes --]
Thankyou, this all makes sense. I do think it would be nice if it was
easier to somehow
add user customizations to the font-locking, especially since it is so easy
to write tree-sitter
font-locking rules.
> We just don’t want a central tree-sitter-font-lock-feature-list that
controls
the feature list of every major mode in a single place.
What would you think of something like a `user` feature that could be
enabled
globally and users could add their mode-specific rules there? Eg.
(defvar my-treesit-font-lock-rules
(treesit-font-lock-rules
:language 'go
:feature 'user
'((identifier))
:language 'typescript
:feature 'user
'((identifier))
;; ...
))
This wouldn't work very well in certain cases where ordering of the rules
was important, however.
On Sun, Apr 14, 2024 at 4:34 PM Yuan Fu <casouri@gmail.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Noah Peart <noah.v.peart@gmail.com>
> >> Date: Sat, 13 Apr 2024 00:32:59 -0700
> >> Cc: 70361@debbugs.gnu.org
> >>
> >> On a somewhat related note, I was wondering why the treesit modes in
> emacs
> >> define their `treesit-font-lock-feature-list`s in the mode definitions.
> >>
> >> Wouldn't it be more user-friendly to `defvar` the feature list?
> >
> > AFAIR, we do that in the mode's settings because the translation of
> > general categories into mode-specific settings is not easy, and
> > because we want users to control that via the fontification level, not
> > below that.
> >
> > What problems do you see with the current approach that would require
> > more fine-grained user control? And why do you think a defvar is the
> > proper way of providing such control?
>
> Replying to Noah, I don’t think there’s anything wrong for a major mode
> to define a xxx-mode-feature-list and assign it to
> treesit-font-lock-feature-list when setting up the major mode. We just
> don’t want a central tree-sitter-font-lock-feature-list that controls
> the feature list of every major mode in a single place.
>
> But again, even if a xxx-mode defines xxx-mode-feature-list, it would be
> a bit of a hassle to take out or remove a single feature from the list,
> since it’s a list of list. (You can just setq the whole list, but then
> you need to keep it in sync with upstream.) It’s probably easier to call
> treesit-font-lock-recompute-features in the major mode hook anyway.
>
> Yuan
>
[-- Attachment #2: Type: text/html, Size: 3348 bytes --]
next prev parent reply other threads:[~2024-04-15 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 5:23 bug#70361: [PATCH] Add font-locking for operators in go-ts-mode Noah Peart
2024-04-13 7:20 ` Eli Zaretskii
2024-04-13 7:27 ` Noah Peart
2024-04-13 7:32 ` Noah Peart
2024-04-13 7:40 ` Eli Zaretskii
2024-04-13 7:53 ` Noah Peart
2024-04-13 9:33 ` Eli Zaretskii
2024-04-14 23:25 ` Yuan Fu
2024-04-14 23:34 ` Yuan Fu
2024-04-15 12:05 ` Noah Peart [this message]
2024-04-16 1:49 ` Randy Taylor
2024-04-16 5:57 ` Yuan Fu
2024-04-16 5:58 ` Yuan Fu
2024-04-16 12:34 ` Eli Zaretskii
2024-04-17 2:47 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPVBTSdYzbV7vdXAH3Zzcqu0E7XLwx=+x+zUmr6izxEAQ9y4bQ@mail.gmail.com' \
--to=noah.v.peart@gmail.com \
--cc=70361@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.