From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noah Peart Newsgroups: gmane.emacs.bugs Subject: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Date: Mon, 20 Nov 2023 04:55:26 -0800 Message-ID: References: <83pm0bqgm7.fsf@gnu.org> <98ce09c9-00a1-f5ad-79ad-ed4b8328ac31@gutov.dev> <83pm07ml54.fsf@gnu.org> <475bca51-dd02-46c5-0114-9588b43b756b@gutov.dev> <83sf52l1gs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a423ff060a95005f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11957"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 67031@debbugs.gnu.org, casouri@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 13:56:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r53pM-0002tm-8f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 13:56:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r53p0-0007qo-J2; Mon, 20 Nov 2023 07:56:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r53om-0007jt-Vs for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 07:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r53om-000810-Ii for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 07:56:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r53oo-0000XP-8k for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 07:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noah Peart Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2023 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67031 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67031-submit@debbugs.gnu.org id=B67031.17004849512044 (code B ref 67031); Mon, 20 Nov 2023 12:56:02 +0000 Original-Received: (at 67031) by debbugs.gnu.org; 20 Nov 2023 12:55:51 +0000 Original-Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r53od-0000Wu-AT for submit@debbugs.gnu.org; Mon, 20 Nov 2023 07:55:51 -0500 Original-Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:50548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r53oX-0000Wd-Ak for 67031@debbugs.gnu.org; Mon, 20 Nov 2023 07:55:49 -0500 Original-Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6d2fedd836fso2703679a34.1 for <67031@debbugs.gnu.org>; Mon, 20 Nov 2023 04:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700484937; x=1701089737; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AsxBjWyV0gEDBIEEDGxhWnHqItEBDau/t7cM+JbRwO8=; b=JBu9vE0Sf72X8w+iVOByTT8J83g1M2Q1AHNjBJzHui/qaRfyUKjVIaP6hPHKxkKAWY mH/q3VlY7NLYRUS0dTRGoUgSojNGozaH5dCthVaK4hCBhlvwaFnDFeIzt+pF8KRS9sFs eTmkv3BCgowy4wPVS/2NGa5j/0rcJfgE3fi1ehjXKPEWzWFWRMdd1s+joQ8U9W1px7f/ cCuCOw6RIr+ro5YvUS4VOxoIY9PSBrJjtIw1p8g7SndSWyU8ippz4DxB4l+D+AMloVkj vkzsdqxhG212cudum9B8tcBz77Mi3vgvrMo+4TvvClwm3tsLGU2gCPAkHZaOUaeTwvHM Vwnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700484937; x=1701089737; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsxBjWyV0gEDBIEEDGxhWnHqItEBDau/t7cM+JbRwO8=; b=J4vxnFUXVNMIWvkBsilX9Xgh8+yJ4qUObDANic5B+nCiz5x+nvW6SFwCIK/JvpA91O V2AnyJsU4Z4xlaDjcc2WbUIAgor94QsXEOOZ8GEJJFEUKA1SBc44cAnPU2//xsgHkOfs lMofVt1N34arjUWwA1WXD19PbGI/tXH06T/r9fC2pgsuD/jcBtodDM66vewzvyhsZAky CjcJQ944O+tL5uVV5ufAFWTDe+0K6wSKarKfBGtUR5cBQObpf2Mo+ye2hfvEp45/HqVl Mz8BvOejy/J4EeRcYQ+30xMY12F+8XG59RXuPDSv05YjcZcTrVE+FxeiGZtdYFShNf0j kkGw== X-Gm-Message-State: AOJu0YzbM242nopPV5IA6osTN33rOgmGOIlUomGgk4siIpYzvy9rUBvx olAroh7KPY7QbtuzJxKNN05U29nuWDyKzYgF6fs= X-Google-Smtp-Source: AGHT+IH36OrUcRYC7lnseMhyjWtAuT3cjvTPVkqsT9sjFip+SYR0lHYcsyAhdNfYtxN1rZXZA6HZ4cdsLvOje1erlBA= X-Received: by 2002:a05:6870:c1d2:b0:1ef:62fc:d51c with SMTP id i18-20020a056870c1d200b001ef62fcd51cmr9092963oad.51.1700484937424; Mon, 20 Nov 2023 04:55:37 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274662 Archived-At: --000000000000a423ff060a95005f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yea, I'm using the same. But, would it be useful to have a way to set that when running tests without needing to temporarily add set `treesit-extra-load-path` in the test file? On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov wro= te: > On 19/11/2023 08:08, Eli Zaretskii wrote: > >> Date: Sun, 19 Nov 2023 03:24:49 +0200 > >> Cc:casouri@gmail.com,67031@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 19/11/2023 02:12, Noah Peart wrote: > >>> Yea, I can do that. > >>> > >>> Is there a recipe for running the tests with a tree-sitter library > path? > >> You mean with the default tree-sitter librayr path overridden? I'm not > sure. > > Why would an ERT test need that? We are supposed to test Emacs with > > the otherwise installed system features. As tree-sitter grammars are > > not part of Emacs, there should be no need to tell Emacs to use a > > grammar library other than the one installed on the system. Right? > > We have a way to override that with the variable > treesit-extra-load-path, so it follows that some users will take > advantage of it to add extra directories. > > I'm using ~/.emacs.d/tree-sitter/ myself. > --000000000000a423ff060a95005f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yea, I'm using the same.=C2=A0 But, would it be useful= to have a way to set that when=C2=A0
running tests without needing to = temporarily add set `treesit-extra-load-path` in=C2=A0
the test f= ile?

On Sun, Nov 19, 2023 at 5:38=E2=80=AFAM Dmitry Gutov <dmitry@gutov.dev> wrote:
On 19/11/2023 08:08, Eli Zaret= skii wrote:
>> Date: Sun, 19 Nov 2023 03:24:49 +0200
>> Cc:cas= ouri@gmail.com,67031@debbugs.gnu.org
>> From: Dmitry Gutov<dmitry@gutov.dev>
>>
>> On 19/11/2023 02:12, Noah Peart wrote:
>>> Yea, I can=C2=A0do that.
>>>
>>> Is there a recipe for running the tests with a tree-sitter lib= rary path?
>> You mean with the default tree-sitter librayr path overridden? I&#= 39;m not sure.
> Why would an ERT test need that?=C2=A0 We are supposed to test Emacs w= ith
> the otherwise installed system features.=C2=A0 As tree-sitter grammars= are
> not part of Emacs, there should be no need to tell Emacs to use a
> grammar library other than the one installed on the system.=C2=A0 Righ= t?

We have a way to override that with the variable
treesit-extra-load-path, so it follows that some users will take
advantage of it to add extra directories.

I'm using ~/.emacs.d/tree-sitter/ myself.
--000000000000a423ff060a95005f--