Re: [Emacs-diffs] trunk r117334: Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not

Re: [Emacs-diffs] trunk r117334: Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not

[Stefan Monnier]

> +2014-06-14  Ron Schnell  <ronnie@driver-aces.com>
> +	* play/dunnet.el If a lamp is in the room, you won't be eaten by a grue.

There should be an empty line between those two lines.  Then a colon
after "play/dunnet.el" and then the name of the affect function(s)
between parentheses.  Using "C-x 4 a" from the location of the change
(or from the *vc-diff* buffer) is a good way to let Emacs take care of
all of that.

> message:
>   Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not
>   be eaten by a grue.

The commit message should be identical to the ChangeLog text (tho
removing the leanding spaces/tabs is a good idea).  If you commit with
VC, C-c C-a from the *vc-log* buffer can automatically fill this buffer
by copying the text from the ChangeLog entry you wrote.


        Stefan

Re: [Emacs-diffs] trunk r117334: Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not

[Ron Schnell]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

All understood.  Is the right course of action to "uncommit" and fix?


On Sat, Jun 14, 2014 at 10:32 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > +2014-06-14  Ron Schnell  <ronnie@driver-aces.com>
> > +     * play/dunnet.el If a lamp is in the room, you won't be eaten by a
> grue.
>
> There should be an empty line between those two lines.  Then a colon
> after "play/dunnet.el" and then the name of the affect function(s)
> between parentheses.  Using "C-x 4 a" from the location of the change
> (or from the *vc-diff* buffer) is a good way to let Emacs take care of
> all of that.
>
> > message:
> >   Changed Dunnet so that if a lamp is in the room that would otherwise
> be dark, the player will not
> >   be eaten by a grue.
>
> The commit message should be identical to the ChangeLog text (tho
> removing the leanding spaces/tabs is a good idea).  If you commit with
> VC, C-c C-a from the *vc-log* buffer can automatically fill this buffer
> by copying the text from the ChangeLog entry you wrote.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

Re: [Emacs-diffs] trunk r117334: Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not

[Stefan Monnier]

> All understood.  Is the right course of action to "uncommit" and fix?

No, the right course is to remember it for next time.


        Stefan

Re: [Emacs-diffs] trunk r117334: Changed Dunnet so that if a lamp is in the room that would otherwise be dark, the player will not

[Ron Schnell]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Will do

Sent by my android.
On Jun 15, 2014 12:12 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:

> > All understood.  Is the right course of action to "uncommit" and fix?
>
> No, the right course is to remember it for next time.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 569 bytes --]