From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Brown Newsgroups: gmane.emacs.bugs Subject: bug#59138: Eglot support for java-language-server Date: Wed, 9 Nov 2022 11:25:40 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000c667605ed0c1c30" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2670"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59138@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 09 17:26:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osnu2-0000Sq-Nb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Nov 2022 17:26:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osntr-00055d-Vu; Wed, 09 Nov 2022 11:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osntq-00050g-7s for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osntp-0004wX-Ti for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:26:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osntp-0001XA-P7 for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59138 X-GNU-PR-Package: emacs Original-Received: via spool by 59138-submit@debbugs.gnu.org id=B59138.16680111585887 (code B ref 59138); Wed, 09 Nov 2022 16:26:01 +0000 Original-Received: (at 59138) by debbugs.gnu.org; 9 Nov 2022 16:25:58 +0000 Original-Received: from localhost ([127.0.0.1]:40687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osntl-0001Wt-Mg for submit@debbugs.gnu.org; Wed, 09 Nov 2022 11:25:58 -0500 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:46680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osntk-0001Wg-Hr for 59138@debbugs.gnu.org; Wed, 09 Nov 2022 11:25:56 -0500 Original-Received: by mail-ej1-f45.google.com with SMTP id bj12so48043023ejb.13 for <59138@debbugs.gnu.org>; Wed, 09 Nov 2022 08:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ITedWqBu3ZQ8Hu6zxP1UQH9I0Swpvv8yiWOiFsqMgKw=; b=lgji7MgsnaeT0wlh59EhtpO0g8WpzBXQyKdcZ2nsCa+oJHb3A5Vt3V0eY02Bw16jJe BHW6EoYZEioumfbEkuSV259xcmEj09kyPyJyGRNgD6JWb9bBOMgrn2QuXRkJumtbAt8t D2v13nLSjXkx3gGo+fSORddq+jhxqHQ9WOyVQMLgYhQt/Q4qS8XvrToxhKLM64QA+jwg eqshY+btmOi6z/ECTIYq4WmO2lxbw+Dnv4masQkue8JKkT8L4UZFusDrB5h6TubhxB/t FwfH6lzo370rFpWy8dVdXzm4FTB+srTwnxozJb9xUl126VVTmeVwxdOAbZFHwCi2Qlc3 s3jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ITedWqBu3ZQ8Hu6zxP1UQH9I0Swpvv8yiWOiFsqMgKw=; b=zWkxFqss4B2m5V35YxR/2U8rECqjexr6MTuSkAGcH4zAwzffoL9fMXw5AY3iidFXyY Y/N0NL+i+0TfjuRHz18qS0A+mRAHE1kk5g9tO+R7+f9vZHU9vfknS12LOEcNeuGvNMEC DQ3wjs9Sk5zfbAubS2oiVNpojcIENLMsEM3+IaSEr7Bj5jaiSKEFbGEwlaYybuJvwFfh Eh6M8GiJ5Et7mjs9pXP1bh97K5Qw7o4s2/5qZW0YbKI7degTmbBBhzXgFD1NcuwymbUG kwjmnJiqRt71E10IRyTCQpS5j1fBuX3SMKFur1cGsgVFM6b0xZKqjUHOv/twhxzr3xyX f6sw== X-Gm-Message-State: ANoB5pnOvO+pU4mBPSFLzw2ZloRLh2963xqg/WS7XS33QGu5QzRZszc8 GBzGE/WNil467+yaiWUf+qaQaObGLKop3G+5fj4= X-Google-Smtp-Source: AA0mqf5Lzc0FBc5lxJ7OL1hARLt0VAzezX3z3p8+HEhe9l8U1oLdDfDht8DXVzi6/OdNFDYhAZIZjXcXB2i9YdR21ts= X-Received: by 2002:a17:906:d287:b0:7ae:72ae:1f85 with SMTP id ay7-20020a170906d28700b007ae72ae1f85mr638168ejb.133.1668011149516; Wed, 09 Nov 2022 08:25:49 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247439 Archived-At: --0000000000000c667605ed0c1c30 Content-Type: text/plain; charset="UTF-8" Not sure if I have signed a copyright assignment. Would have been a long time ago. My email address would have been @bibliotech.com. On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas wrote: > [Please use "Reply to all" so that the discussion is recorded in the bug > tracker.] > > Robert Brown writes: > > > I don't know what the relative popularity is. I found j-l-s to be > > easier to compile and configure for environments that are not Maven or > > Gradle. I think jdtls may have more features. > > Thanks, that's good enough for me. > > Have you signed the copyright assignment? I see one previous change > from you, so I'm not sure if this latest patch would take us over the > limit for what we could accept without one. Eli, any comments? > > commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd > Author: Robert Brown (tiny change) > Date: Thu Jun 19 10:03:45 2014 -0400 > > * etc/NEWS: New Tramp method "nc". > > * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New > fun. > (lisp-string-in-doc-position-p): New function, extracted from > lisp-font-lock-syntactic-face-function. > (lisp-font-lock-syntactic-face-function): Use them. > > Fixes: debbugs:9130 > > etc/NEWS | 3 +++ > lisp/ChangeLog | 7 +++++++ > lisp/emacs-lisp/lisp-mode.el | 64 > ++++++++++++++++++++++++++++++++++++++-------------------------- > 3 files changed, 48 insertions(+), 26 deletions(-) > --0000000000000c667605ed0c1c30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Not sure if I have signed a copyright assignment.=C2=A0 W= ould have been a long time ago.=C2=A0 My email address would have been @bibliotech.com.


On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas@gmail.com> wrote:
[Please use "Reply to all" so that the discu= ssion is recorded in the bug
tracker.]

Robert Brown <robert.brown@gmail.com> writes:

> I don't know what the relative popularity is.=C2=A0 I found j-l-s = to be
> easier to compile and configure for environments that are not Maven or=
> Gradle.=C2=A0 I think jdtls may have more features.

Thanks, that's good enough for me.

Have you signed the copyright assignment?=C2=A0 I see one previous change from you, so I'm not sure if this latest patch would take us over the limit for what we could accept without one.=C2=A0 Eli, any comments?

commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
Author: Robert Brown (tiny change) <robert.brown@gmail.com> Date:=C2=A0 =C2=A0Thu Jun 19 10:03:45 2014 -0400

=C2=A0 =C2=A0 * etc/NEWS: New Tramp method "nc".

=C2=A0 =C2=A0 * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword= -p): New fun.
=C2=A0 =C2=A0 (lisp-string-in-doc-position-p): New function, extracted from=
=C2=A0 =C2=A0 lisp-font-lock-syntactic-face-function.
=C2=A0 =C2=A0 (lisp-font-lock-syntactic-face-function): Use them.

=C2=A0 =C2=A0 Fixes: debbugs:9130

=C2=A0etc/NEWS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 3 +++
=C2=A0lisp/ChangeLog=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 7 +++++++
=C2=A0lisp/emacs-lisp/lisp-mode.el | 64
++++++++++++++++++++++++++++++++++++++--------------------------
=C2=A03 files changed, 48 insertions(+), 26 deletions(-)
--0000000000000c667605ed0c1c30--