From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Petrofsky Newsgroups: gmane.emacs.bugs Subject: bug#64075: 28.2; ispell broken on uncolored terminals Date: Wed, 14 Jun 2023 19:13:14 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000068198905fe1f19a9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25238"; mail-complaints-to="usenet@ciao.gmane.io" To: 64075@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 01:14:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9Zgr-0006Pw-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 01:14:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Zgi-0007T3-Qx; Wed, 14 Jun 2023 19:14:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Zgg-0007SO-HR for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Zgg-0003zO-9y for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9Zgg-0004n9-4M for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Petrofsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 23:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64075 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168678441218373 (code B ref -1); Wed, 14 Jun 2023 23:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jun 2023 23:13:32 +0000 Original-Received: from localhost ([127.0.0.1]:45765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ZgC-0004mH-IC for submit@debbugs.gnu.org; Wed, 14 Jun 2023 19:13:32 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ZgB-0004m9-6S for submit@debbugs.gnu.org; Wed, 14 Jun 2023 19:13:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ZgA-0007My-Vu for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:13:30 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Zg9-0003x0-EA for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:13:30 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-25bd8d52f24so859508a91.0 for ; Wed, 14 Jun 2023 16:13:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686784407; x=1689376407; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ymgnVRUHKlgU3uX1ysT4ivziSVzV7UqiHxvgjkz4Zmw=; b=ebHfLGoXaD3XrnIvJwNVdnSwXMjXOYAAwyLCSyn+T/lFpc5b0upkW0BFKx5O3Xwmvq mDBx3Vws0Q/lvVOXaKimaARqsnLidp0bKbMedeKbAshvpj88D/v7uA0WUQqm9uLiZ2Oa OnZ5zHFxUl3ucJj3fUBPv6MIXYIgYe/YXONDn59V4/urlMdg4005mSGOo8O3q3mx20Rd VV68mfAJHpyT0v/0T6AuqIT5ADYGOQgF6/VRZeY9Iuaf0AJK2+xUHjc4P6oaVCWyOau4 mpYp8PIWMiYvNS+qHVJAMn7uYCnBIDkpXL+vaDV7bDQVy1bcVzhKfpv2ohPzk2ZzZ/gg ei8w== X-Gm-Message-State: AC+VfDzik4EaPbF6rrq2uBt0MtKcfiF7nlTV214L3BqJ8eWtMK2jw05k mxU2dnPU0RZ1Cr9+N5Y9sgrcL1elY5xggktO2LoKO93k1TE= X-Google-Smtp-Source: ACHHUZ6EgzIYUatyphb5AG3+dSVpVYMKyTQMsxlMY7CCwh438EyLjqzkBsmjuLRjMO8hdXpFgGc7x1IximYlQNpK9WA= X-Received: by 2002:a17:90b:1b0c:b0:25b:e057:7526 with SMTP id nu12-20020a17090b1b0c00b0025be0577526mr12199502pjb.4.1686784407245; Wed, 14 Jun 2023 16:13:27 -0700 (PDT) Received-SPF: pass client-ip=209.85.216.47; envelope-from=al.petrofsky@gmail.com; helo=mail-pj1-f47.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263385 Archived-At: --00000000000068198905fe1f19a9 Content-Type: text/plain; charset="UTF-8" emacs-28.2 -Q -nw --color=no s t o n k s M-$ 1 At this point, I expect to see the word "stonks" replaced with "stocks", but it is instead replaced with "stockstonks". The problem seems to be in ispell-highlight-spelling-error-generic, a 20th-century kludge from before face support for ttys was added in emacs-21 in 2001. It's been unnecessary since then, and it looks like it's been breaking ispell on colorless ttys since at least emacs-23. Changing "(display-color-p)" to "t" in ispell-highlight-spelling-error suffices to fix the bug. --00000000000068198905fe1f19a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

=C2=A0 =C2=A0emacs-28.2 -Q -nw --color=3Dno
=C2=A0 = =C2=A0s t o n k s M-$ 1

At this point, I expect to see the word &quo= t;stonks" replaced with
"stocks", but it is instead repla= ced with "stockstonks".

The problem seems to be in ispell-= highlight-spelling-error-generic, a
20th-century kludge from before face= support for ttys was added in
emacs-21 in 2001.=C2=A0 It's been unn= ecessary since then, and it looks like
it's been breaking ispell on = colorless ttys since at least emacs-23.

Changing "(display= -color-p)" to "t" in ispell-highlight-spelling-error
suff= ices to fix the bug.

--00000000000068198905fe1f19a9--