From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: C warning in MSYS2 build Date: Fri, 6 Oct 2017 18:23:04 +0100 Message-ID: References: <83inftwhlb.fsf@gnu.org> <281d43c7-b3a9-be40-a8e7-c8021c286f59@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1507310677 25207 195.159.176.226 (6 Oct 2017 17:24:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 17:24:37 +0000 (UTC) Cc: Eli Zaretskii , Paul Eggert , Emacs Development To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 19:24:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0WML-00058M-77 for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 19:24:25 +0200 Original-Received: from localhost ([::1]:46218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0WMS-00064r-JV for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 13:24:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0WLa-00063g-7m for emacs-devel@gnu.org; Fri, 06 Oct 2017 13:23:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0WLZ-0001vb-EP for emacs-devel@gnu.org; Fri, 06 Oct 2017 13:23:38 -0400 Original-Received: from mail-ua0-x232.google.com ([2607:f8b0:400c:c08::232]:44866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0WLY-0001tr-0e; Fri, 06 Oct 2017 13:23:36 -0400 Original-Received: by mail-ua0-x232.google.com with SMTP id f46so11525002uae.1; Fri, 06 Oct 2017 10:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/DkTbBxIjGcMBsnHMLIHLwx+QcTYE2CJi+hk3RAXIYw=; b=LgD49v0YsUQg9Nx7siqMk8yowtiPaNLG9TxaLivjprrP4jdq2pSZrwem69z6/l/tHe q73hf0d2d0v7Sfjlg6iNlo4ViT3lUBbs4mJEIvwqbBIBv1Gc5XIyrGhJYdF8klQeRr2s IFBfl72NOHA7FH3tUw2uNHCdwfpp4P1/10yEDKTkdcflU65xiVY4YCSFF+tfEGGULQlF Wshl3Q12YufphUwq4Wm/VUVqfPOcX9Iw26YUoggsTnj9dmkhUFfQC+2jeqYdfl1WGQUL 5cV1fSFCvYF0/qHHCVZLmKmP7BwlA6UUHbHc/UJ/tamE58IeYvDjWUaxvfaSHDDgbCaK fJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/DkTbBxIjGcMBsnHMLIHLwx+QcTYE2CJi+hk3RAXIYw=; b=TTOhN4asnxqe2UaW9OxTEtSL2huV0wX+Al7lRpDdYPdQIa4fJLNq1821UrjH497zD0 gn3xgh2d1LOpyz5WYBRuCR6kKQdJDYx2qiFciBG92qIi6JjC5494juUlYztT4gQQra/I pTdh2ZBww/uF0SPI98mY2/BNXNc5QxSSkAv6QlxpxEeyjNRDzydMdv2hy5+4biABrrMa blQu0uSf1OxhYMs9JZIrSW/Oo7dlZBHUyxXY6GH2VqBbbc/t6MAVkE6WYUhdAN6HFobZ lFHBGNEraDFN0v2B4ymxvCtsP2Z0jQWypc0SQf0tdxTdYvvWEA5oMKznRIfBqYcAtb/u sYRw== X-Gm-Message-State: AMCzsaVwI/ZUzidd3vDhE8YdEkO4rVN0GzqufxDpPknziODFLTc7iZXP yLmxyi4s+Q7tVsVF2HMxjyDrvZCrV85xpv0yYrs= X-Google-Smtp-Source: AOwi7QCTOSgXKKy086htTkOekIKuXwnN3NH6CmW/l9+y2oVqlXkqssN7D/6OajS+oB0cXpRotWTCBkQvTDuS+REnxL8= X-Received: by 10.176.3.2 with SMTP id 2mr1474728uat.14.1507310615135; Fri, 06 Oct 2017 10:23:35 -0700 (PDT) Original-Received: by 10.176.22.114 with HTTP; Fri, 6 Oct 2017 10:23:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219199 Archived-At: On 6 October 2017 at 16:16, Richard Stallman wrote: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > > The GCC bug is not fixed yet. etags.c confused GCC by using an > > assignment inside an 'if' expression, which is contrary to the usual GNU > > style, and last year I worked around the GCC bug by changing etags.c to > > use a cleaner style. I notice that indent.c also has an assignment > > inside an 'if' expression that is relevant to these warnings. Richard, > > does it help to recode indent.c to use the usual GNU style, as in the > > attached patch? > > I don't understand the question. Paul was asking me to test the attached patch. > An assignment inside an if condition is somewhat ugly, > and moving the assignment out of the code is in general > a good thing for clarity. So by all means do it. That's not the proposal. You're free to read the patch if you wish. > If that works around a GCC bug, that is good -- but the bug > still needs to be fixed. Indeed, but fortunately the impact is low.