From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Improve reporting of I/O, access errors for Emacs Date: Mon, 16 Sep 2019 19:11:58 +0100 Message-ID: References: <834l1cxpfw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d2f9da0592af8b21" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190983"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Paul Eggert , Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 16 20:13:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9vUj-000nRR-Mw for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 20:13:01 +0200 Original-Received: from localhost ([::1]:38420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9vUi-0000Kg-BP for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 14:13:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38247) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9vUR-0000I0-Nf for Emacs-devel@gnu.org; Mon, 16 Sep 2019 14:12:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9vUJ-000743-Nn for Emacs-devel@gnu.org; Mon, 16 Sep 2019 14:12:41 -0400 Original-Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:46512) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9vUB-00071E-U4; Mon, 16 Sep 2019 14:12:28 -0400 Original-Received: by mail-oi1-x231.google.com with SMTP id k25so522970oiw.13; Mon, 16 Sep 2019 11:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3/d+huBXPanustq8BjU/7IaoHTpk8nxS2COPWPb+nZY=; b=jonquxB/rijW+tRgnlWyGp6PYdJ3+Anw1zOJu0mLhPsA3K7K9AcakZWgJC8+tGV7gI Q7KO3zJzcSRj6JwJ14d2aQ88995TC1ThhHtKkWIHoGOWeVvJsSfEsxP5nqp2lOD1LeSn wUHrRLZ16Hfp8eDLYD+7V3QHBfg7IJ6oW7hpTCIsoNztCPJI86sF6Ya9wU/ufJbrcPSO s/AwnAPHLqzUZaJYMYemOxG3sXfOcAzowBrBFM/HTTvIQ+0QO1y2edSHwbQ2uj7joWGi Vki7T38IdnRQxc/UNwX5YUvLuAMbv6ALiFwITTSNY2iCPPJkZTyi98LAw4+agF7PBN65 dMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3/d+huBXPanustq8BjU/7IaoHTpk8nxS2COPWPb+nZY=; b=O9IX7A949H+zYpbfJqFfhNigOsDmGP4qroNpoRl/+vJgBZ8hQY5zJvVtLEXzUjg3My J7jTWxRgPBD7ydF4APgxJeZlYE62SvM60ObqOB8L1XLYNeMfT8hrakEYbC9q2pj5XGZq dKy/mwmGtPjGmatMHX2eJU3bMj4Cgx6RTTfm3orwUygxvx0NXbwfNAgnNecgKF8zcA0X ZlrpYH3fdyNtg2GnN81UaNOaxlfKF6gI2t94t7kDfbHsWvJbZqcKxK4TVzZFH5P0mdU8 rsimmuQaVjUSzD64OrIACOmXBCGM2kJHsFKNLv39f/kQ5evOJXbRpvaYKmTAdb3jD69s sArA== X-Gm-Message-State: APjAAAVRoRdRIf89m1pdd3G1zg9BhRcdHJtGclyMfE2uRuDvRTn//dM7 T8giPRBNHk0RnGbhyFrwQlyYby7ZFhEFJYcbvFFD09Z4 X-Google-Smtp-Source: APXvYqzuK/XutZjcJRp7V9/NIfHbPPkhy+uB1kmcsQQsku0yeiLN+253G5qBYuw2xFQeMaNBDU4+q3Iu+mTbn3lqfm8= X-Received: by 2002:aca:5254:: with SMTP id g81mr456137oib.67.1568657546342; Mon, 16 Sep 2019 11:12:26 -0700 (PDT) In-Reply-To: <834l1cxpfw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240081 Archived-At: --000000000000d2f9da0592af8b21 Content-Type: text/plain; charset="UTF-8" On Mon, 16 Sep 2019 at 15:53, Eli Zaretskii wrote: > > From: Richard Copley > > Date: Mon, 16 Sep 2019 12:07:09 +0100 > > Cc: Emacs Development > > > > At the end of init_callproc in callproc.c, we check that PATH_GAME is > file_accessible_directory_p. On > > Windows, PATH_GAME begins with a literal '%emacs_dir%', so this never > works, but sets errno to > > ERROR_ACCESS_DENIED. Therefore, on every invocation of Emacs, I get this > warning: > > > > Warning: game dir '%emacs_dir%/var/games/emacs': Permission denied > > Thanks, should be fixed now. > LGTM, thanks. --000000000000d2f9da0592af8b21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 16 Sep 2019 at 15:53, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Richard Copley <rcopley@gmail.com>
> Date: Mon, 16 Sep 2019 12:07:09 +0100
> Cc: Emacs Development <Emacs-devel@gnu.org>
>
> At the end of init_callproc in callproc.c, we check that PATH_GAME is = file_accessible_directory_p. On
> Windows, PATH_GAME begins with a literal '%emacs_dir%', so thi= s never works, but sets errno to
> ERROR_ACCESS_DENIED. Therefore, on every invocation of Emacs, I get th= is warning:
>
>=C2=A0 =C2=A0Warning: game dir '%emacs_dir%/var/games/emacs': P= ermission denied

Thanks, should be fixed now.

LGTM, than= ks.

--000000000000d2f9da0592af8b21--