From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Wed, 23 Nov 2022 12:49:17 +0000 Message-ID: References: <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> <83wn82osoo.fsf@gnu.org> <871qq8xfzr.fsf@gmx.de> <87mt8uwo2q.fsf@dfreeman.email> <87zgcs6nvb.fsf@gmx.de> <87r0y3luad.fsf@dfreeman.email> <87iljf72ua.fsf@gmx.de> <87a64qykcf.fsf@gmx.de> <8735ab12pr.fsf@gmx.de> <720bcf72-e944-4978-982f-4b6fa8b31e5c@gmail.com> <86o7sxg7u7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40419"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , Danny Freeman , 58790@debbugs.gnu.org, Michael Albinus , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Dmitry Gutov , Eli Zaretskii , Stefan Kangas To: Arash Esbati Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 13:50:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxpCm-000ALU-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 13:50:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxpCc-00082T-Ol; Wed, 23 Nov 2022 07:50:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxpCW-00081r-Dq for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:50:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxpCU-0001hx-Ij for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:50:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxpCU-0004Oi-A0 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166920779316884 (code B ref 58790); Wed, 23 Nov 2022 12:50:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 23 Nov 2022 12:49:53 +0000 Original-Received: from localhost ([127.0.0.1]:54088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxpCL-0004OG-1r for submit@debbugs.gnu.org; Wed, 23 Nov 2022 07:49:53 -0500 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:36783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxpCI-0004O0-Rm for 58790@debbugs.gnu.org; Wed, 23 Nov 2022 07:49:51 -0500 Original-Received: by mail-lj1-f175.google.com with SMTP id u2so21274649ljl.3 for <58790@debbugs.gnu.org>; Wed, 23 Nov 2022 04:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=evWI5iz4XvYfdxdGXWQogFnWFc0QNFU6YodOO/mDZoo=; b=nq0FtdcRZfX+k2wvI/ox3fTLXg8gmzMnNjtLCDJNkYktdPBA/S0Tf8tTXNiGX4N46u SmmQeRDoet6GQYGleYzdZG07fnv4qFh8I5EB7CryyqvUjiNe+HEEIZYkEHhmypqG50Tq lkdjPFrB2j/V5Gr/uTkVFXK4gvKB9vIK5YaWZIvMKuRKIYgvt/Uzw22oJAdnEbaZA0Sp izdStGQv/bdB/3mH7LlLNOI57xhxyEmBIWyQAh4rhgvVT5sEqUf+8WwhAv7wX3wJgv8b W4p3WNd2J0KcQ3CwowoBDthWAZTw5BseVXl9L1xA0pJ4sEMRCXR9i94NoT3zbLh87EiW i5iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=evWI5iz4XvYfdxdGXWQogFnWFc0QNFU6YodOO/mDZoo=; b=54rioLMW/wR1DDdpUuuzLjTGqHCncD20Lj3RuiMjBuweMcVsSVxEHfoxww5H95wrO5 GgPPO94Yf791I9W7s+cOUvRaftyDmKYFqYWfysnPV7aS6tdOx0ioWd0L2q0baOn650Vb R0PMiNOpqCmD9YpZE4ugbSooKNKIRP1M/hdOskudyDYUslwUUGbcUK/xT5GPli/R88gM OnwfWDh84JvZ83iatKXPjrvdT/Wx9kqfS/uQIFZASz3sTbuLFGEGwWLUkMjDl7PCtW1E V+YFlxeE/i25m8P6qpL1wQVB5/Zj1j+USiZsn8CLrLQz9hHcqbbL2NOL6MpbwhqdHohz gcEQ== X-Gm-Message-State: ANoB5pkP5T8SSA79joz00y0TXNbiSdogAb8FFLcX/BOBMn28GNEVAXFg UgFD9x7Uxnzm+dTL/3zkuiMTyn7QvV4LJBf+4jA= X-Google-Smtp-Source: AA0mqf4WrMPXHepmHKFzDEV1NuF8Nw+TEaXHn+LqEpG2rWGN+Y/LNYPPWkSWnWr5zqDvEFLrLJCTRJ6tv3WvLkIHHLc= X-Received: by 2002:a2e:2a41:0:b0:277:77a:b53b with SMTP id q62-20020a2e2a41000000b00277077ab53bmr8937192ljq.59.1669207784732; Wed, 23 Nov 2022 04:49:44 -0800 (PST) In-Reply-To: <86o7sxg7u7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248735 Archived-At: On Wed, 23 Nov 2022 at 12:43, Arash Esbati wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > Yes,I think I follow. To be clear I think the problem is somewhere in > > > > (defun eglot--path-to-uri (path) > > "URIfy PATH." > > (let ((truepath (file-truename path))) > > (if (url-type (url-generic-parse-url truepath)) > > ;; Path is already a URI, so forward it to the LSP server > > ;; untouched. The server should be able to handle it, since > > ;; it provided this URI to clients in the first place. > > truepath > > ...) Thanks, yes. > > So either url-generic-parse-url and url-type is fixed in url-parse.el, = or > > we must add some Windows-specific guards in eglot.el. Or likely > > both, since url-parse.el is not a :core ELPA package. I don't think "url-generic-parse-url" needs any fix. It is for parsing a UR= L, not deciding if something is a URL. > Have a look at bug#59338: Danny came up with a patch for eglot.el. > > https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-11/msg01510.html > > Best, Arash Excellent.