From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#30295: CSS mode colour highlighting makes text hard to read Date: Tue, 30 Jan 2018 16:55:14 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1517331399 23702 195.159.176.226 (30 Jan 2018 16:56:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2018 16:56:39 +0000 (UTC) To: 30295@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 30 17:56:35 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egZCq-00052B-2Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 17:56:24 +0100 Original-Received: from localhost ([::1]:48538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egZEp-0006js-6C for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 11:58:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egZDT-0005zE-O7 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:57:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egZDS-0007lS-QU for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:57:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egZDS-0007l1-MQ for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egZDS-00066Q-8B for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151733136523332 (code B ref -1); Tue, 30 Jan 2018 16:57:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2018 16:56:05 +0000 Original-Received: from localhost ([127.0.0.1]:49778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egZCW-00064G-Pv for submit@debbugs.gnu.org; Tue, 30 Jan 2018 11:56:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egZCT-00063d-3o for submit@debbugs.gnu.org; Tue, 30 Jan 2018 11:56:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egZCM-0006MD-CY for submit@debbugs.gnu.org; Tue, 30 Jan 2018 11:55:55 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:50304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1egZCM-0006Lu-7H for submit@debbugs.gnu.org; Tue, 30 Jan 2018 11:55:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egZCK-0005PI-IJ for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:55:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egZCE-0006ET-ON for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:55:52 -0500 Original-Received: from mail-ot0-x229.google.com ([2607:f8b0:4003:c0f::229]:42149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egZCE-0006DV-GY for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 11:55:46 -0500 Original-Received: by mail-ot0-x229.google.com with SMTP id a7so7703863otk.9 for ; Tue, 30 Jan 2018 08:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fj/M8JGLyq/KLH8t8NkVEML9byPzLCGivXz0KRRoDHQ=; b=ajtQAG26OyyUqRkhqWezF44jcw+tQMK/wVvEU6QDYzbGp2FntaVhYVBWdTevaLi1UH Q8GYiuMEXICyVHT81XODkeaDPwodPFRETNAfnslwsGbIDGlSi+FhRDFzUe4jKe2r74pT CreLyv4/ny60wY74FGjFlJjW9bkg0ead9ryJF6XM4a+Gji8KMFAqqL0ORYcy+TnzeBVH T6Bhz1EFzwYDFuLnbw0oE6rNkG37M7DIsTgHP9qfPfIn4C8jk2goXwsleQJEAqqG40eC GkUlnxn5o3hkC1C9VVaXngP0WiJKclIiadtUOmhGZ7Vy+CoeCh8LLhdkMofJZdyRKdM+ DWBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fj/M8JGLyq/KLH8t8NkVEML9byPzLCGivXz0KRRoDHQ=; b=fUJwHEiKSLY9rWWwJifYZjsgx7V0ICbsZq9RhcUKrfy2VwMLm/tmPdZmPAzFBEgBT0 TTvae7vLBZssufaVpXy3/4G3McqIK/sZPRRcn0bNaKyp/HcGEOmhFxSA9ruqnpgULA2+ tXNhVJGu/AZ4Cb3iU37MG6ha/v4u2TMPTpKlRvRexWLFiWC5omm/jU4BYXpS5++E0zgh 25MbGQ2717117+yrt3nugbqK45fjaPuQ70SJjN+ylH9guJv5LEsS2Ka5P3jqgM0LRM5R jUr37jaXvNk576UwuK+x2bjzqhJ+RM0LOU/QOD0V8V59saLiGGyXD8ibXecT/2hnoLDx xZQQ== X-Gm-Message-State: AKwxytdVPHvmW3zZn4Kq3uLF08TD3FbsL7H6jb5mlBP/sF613IhzoGyj 0r7JXo2eEOSGSXFi2qdDmIa/jKDMzopw56U2Dtw= X-Google-Smtp-Source: AH8x224u4AcT35TH+X93wgTSYV4yKCFmLYATVLU2OyG1Ck4XB+TKxB7GhgxVMEkLedvBSF1bOObiHni8ga6GXlhjnzU= X-Received: by 10.157.37.11 with SMTP id k11mr5540659otb.66.1517331345266; Tue, 30 Jan 2018 08:55:45 -0800 (PST) Original-Received: by 10.157.74.83 with HTTP; Tue, 30 Jan 2018 08:55:14 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142706 Archived-At: In CSS mode, the value "green" or "#0f0" or "rgba(0,255,0,0.5)" is displayed with a white foreground and a 100%-green background, which is difficult to see. A white foreground is chosen on even lighter colours, for example, "#5e5" and "#87e087". See functions css--contrasty-color in textmodes/css-mode.el and color-distance in src/xfaces.c, and , and . If the color-distance is to be used, the appropriate formula is: (if (> (color-distance name "black") (color-distance name "white")) "black" "white") That formula still maps "green" to "white", but it does at least map lighter colours such as "#38e038" to "black". For what it's worth, in my inexpert opinion it makes more sense to compare the luma against that of mid-grey as Tom originally proposed.