From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Date: Fri, 4 Nov 2016 21:16:57 +0000 Message-ID: References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1478295948 3443 195.159.176.226 (4 Nov 2016 21:45:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Nov 2016 21:45:48 +0000 (UTC) Cc: Stephen Berman , 24873@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 04 22:45:42 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2mIh-0006yY-8f for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Nov 2016 22:45:27 +0100 Original-Received: from localhost ([::1]:41044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2mIk-0006jK-4O for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Nov 2016 17:45:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2lsE-0006zK-3Y for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 17:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2lsA-0003yi-3t for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 17:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2ls9-0003yM-W9 for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 17:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c2ls9-0007Lf-Mw for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 17:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Nov 2016 21:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24873-submit@debbugs.gnu.org id=B24873.147829425528216 (code B ref 24873); Fri, 04 Nov 2016 21:18:01 +0000 Original-Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 21:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lrj-0007L0-8X for submit@debbugs.gnu.org; Fri, 04 Nov 2016 17:17:35 -0400 Original-Received: from mail-ua0-f181.google.com ([209.85.217.181]:36234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lrh-0007Kn-Dl for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 17:17:33 -0400 Original-Received: by mail-ua0-f181.google.com with SMTP id b35so76818983uaa.3 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 14:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2eRko04uiXDPXCXD3jqY7xTNHmcaZCGlqwGc6dof/TE=; b=WOzu6vTsDMtVm8Ei6Jm4mLWDZx1wzL/OpsKUZkXfiTBw/xyR4lIDwDp8byrgAnEZoF j41pW3B3w3LfHh4voOPVk4INhSsTX3aFc1ys+M8/g47TvLbzNA6JS/hVXif3EN7g7+YG bYpEbDbUWNUJoG68vkY9oKHuQToRMuC0rQP6y78j7XbdMmWySmbDM2W4wGeH6eD7JJKA qJlvZ6ArKiZWmCiOnogih1gqd6VtsGhJUtHaYPKXINXIAzn9YsR2Z6dXI+QlSWfj5zTd +bvs5R/Vh3EflDgQEa9Bez9ypORR0wuaVQaGNBd6ra+rM1fnUlVbyA9pp+PVYHqXg6vl AwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2eRko04uiXDPXCXD3jqY7xTNHmcaZCGlqwGc6dof/TE=; b=WN0rk/Tjc/47Y5wqIBLZqPg3gZdYrfORwsbifrU4QyBMDOP/eolnHhYLfJX43Mi8X9 Jczd23D+vgY4i4qGxfjRuSy9lMB320vfT/b9ClFz3z/PuB0M+lTvlbMW4ARYCr/b3dpC MyCGG+B4O764jGY4eMaxPfUF104hidtOa0opxgHpFq609wE9VmtJPRNzTu8g2Ey8K9YQ l1oT6dtGmJOCi7k8KpWdH5JvNYtYhOtZFte80oQwlH9G+zchpuzrOZ+zCgnUH9HMpYPG TU3wxO12n90KjZMcScjZK8XZ61Mzw0tJMoY4SRrNtPqWEpinPpuWjssNb/fOogp8hdRN zSsA== X-Gm-Message-State: ABUngvex+GUp9sUQ4K8sddpQuFqyC4lSoDSpzNF/ji+6v8l0QVVKmTA2Zlqv80hJw0MtTFDBe2uBwnqJap/Uyg== X-Received: by 10.159.36.244 with SMTP id 107mr11142625uar.51.1478294247751; Fri, 04 Nov 2016 14:17:27 -0700 (PDT) Original-Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 14:16:57 -0700 (PDT) In-Reply-To: <20161104205329.GA24042@holos.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125358 Archived-At: On 4 November 2016 at 20:53, Mark Oteiza wrote: > On 04/11/16 at 08:59pm, Stephen Berman wrote: >> On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza wrote: >> >> > On 04/11/16 at 07:03pm, Richard Copley wrote: >> >> On 4 November 2016 at 11:16, Richard Copley wrote: >> >> > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: >> >> >> >> >> >> > From: Richard Copley >> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> >> >> > >> >> >> > The bug was introduced in the master branch between these two revisions >> >> >> > (not tight bounds, just builds I have lying around): >> >> >> > >> >> >> > GOOD: >> >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> >> >> > Author: Paul Eggert >> >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> >> >> > >> >> >> > BAD: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> >> >> >> >> Is this the result of turning on lexical-binding in iserach.el? >> >> > >> >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone >> >> > beats me to it. >> >> >> >> Yep, you nailed it. >> > >> > This was fixed already--your recipe works as expected for me. See bug#24580 >> >> My build contains the commit referenced in bug#24580 as fixing it, but I >> can still reproduce the problem with the OP's recipe (i.e. with -Q). > > Sorry if I jumped the gun closing. > > I'm on 2955936 (master HEAD at the moment) and can't reproduce. I can reproduce the issue with the given recipe in that revision. To summarize, here are the test results stated so far in this thread, plus a few more that I'm stating now, in chronological order: Good [RC] (before lexical binding in isearch.el): commit 329e0274ec6a4ae82f86905b8cf844971b943085 Author: Mark Oteiza Date: Tue Sep 27 13:34:29 2016 -0400 Bad [RC] (turn on lexical binding in isearch.el) commit cbb2e845187bfbcc62e2accc9df7891a2326608a Author: Mark Oteiza Date: Wed Sep 28 13:08:12 2016 -0400 Good?? [MO] (this is the revision mentioned in #24580) commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 Author: Mark Oteiza Date: Tue Oct 4 10:17:53 2016 -0400 Bad [SB] (unspecified, but containing the above). >> >> >> > BAD [RC]: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 Good [MO], Bad [RC]: commit 29559361f56c9398dcb69db7396dcfc0887843a2 Author: Mark Oteiza Date: Fri Nov 4 14:22:05 2016 -0400 Mark, it seems rude to ask, sorry, but are you sure you weren't testing a slightly different recipe? Otherwise it must be some difference in our environment which seems less likely.