From: Richard Copley <rcopley@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 28268@debbugs.gnu.org
Subject: bug#28268: 26.0.50; (MS Windows) crash on C-g after closing Git GUI
Date: Tue, 29 Aug 2017 17:48:36 +0100 [thread overview]
Message-ID: <CAPM58oifQ5ARF9qditKN_3+ZwWv=ae1=m=xNDSOB9UxUfpmxvA@mail.gmail.com> (raw)
In-Reply-To: <CAM-tV-8GkyhnpsucK3beuTTwjz0C2j-AE101wnqV-djBgrR8JA@mail.gmail.com>
On 29 August 2017 at 17:38, Noam Postavsky
<npostavs@users.sourceforge.net> wrote:
> On Tue, Aug 29, 2017 at 11:18 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> Recipe:
>>>
>>> Visit a git repo.
>>> C-x g ; magit-status
>>> ! g ; magit-run-popup, magit-run-git-gui
>>> ;; A nasty-looking window pops up (Git GUI, I presume). Close it.
>>> C-g ; Crashes.
>>
>> I couldn't reproduce this here: the Git GUI didn't pop up for me.
>> Perhaps something is missing from the recipe ("C-x g" was also
>> unbound), or maybe it's because my Git is configured to be run only
>> from Git Bash, not from anywhere else on Windows.
>
> I can't reproduce this here either. I need the patch at [1] to make
> the GUI pop up, but even after applying that I get no crash.
>
> (magit provides a Makefile such that "C-x g" is bound to magit-status
> if you do 'make emacs-Q', although I don't normally use this on
> Windows since I don't have 'make' on PATH)
>
> [1]: https://patch-diff.githubusercontent.com/raw/magit/magit/pull/3155.patch
It doesn't turn out to be a Magit bug. Please try this recipe instead.
Evaluate this:
(async-shell-command "\"C:\\Program Files\\Git\\cmd\\Git-GUI.exe\"")
Now type C-g in Emacs about 6 times to see the abort.
Note that the abort is fixed by Eli's recent change.
next prev parent reply other threads:[~2017-08-29 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 21:10 bug#28268: 26.0.50; (MS Windows) crash on C-g after closing Git GUI Richard Copley
2017-08-29 15:18 ` Eli Zaretskii
[not found] ` <CAPM58oj8XRzUJpRtbB_TCYxsfaWncDjwnGqTg-FFo6w2P5m8Qw@mail.gmail.com>
2017-08-29 16:08 ` bug#28268: Fwd: " Richard Copley
2017-08-29 16:09 ` Richard Copley
2017-08-29 16:22 ` Richard Copley
2017-08-29 16:53 ` Eli Zaretskii
2017-08-29 16:38 ` Noam Postavsky
2017-08-29 16:48 ` Richard Copley [this message]
2017-08-29 17:14 ` Noam Postavsky
2017-08-29 17:25 ` Eli Zaretskii
2017-08-29 17:33 ` Eli Zaretskii
2017-08-29 18:15 ` Richard Copley
2017-08-29 19:00 ` Eli Zaretskii
2017-08-29 18:59 ` Eli Zaretskii
2017-08-29 19:02 ` Richard Copley
2017-08-29 19:28 ` Eli Zaretskii
2017-08-29 19:38 ` Richard Copley
2017-08-30 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM58oifQ5ARF9qditKN_3+ZwWv=ae1=m=xNDSOB9UxUfpmxvA@mail.gmail.com' \
--to=rcopley@gmail.com \
--cc=28268@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.