From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: [w32] Build failure on master (pthread_sigmask.h) Date: Thu, 30 May 2019 16:54:13 +0100 Message-ID: References: <837ea8xc88.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006c44eb058a1cea74" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255209"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 30 17:55:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWNOs-0014Be-L9 for ged-emacs-devel@m.gmane.org; Thu, 30 May 2019 17:55:30 +0200 Original-Received: from localhost ([127.0.0.1]:55778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWNOr-0007s5-Cr for ged-emacs-devel@m.gmane.org; Thu, 30 May 2019 11:55:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWNOF-0007s0-Be for emacs-devel@gnu.org; Thu, 30 May 2019 11:54:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWNOE-0003iI-7c for emacs-devel@gnu.org; Thu, 30 May 2019 11:54:51 -0400 Original-Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:37279) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWNO6-0003Xg-KK; Thu, 30 May 2019 11:54:42 -0400 Original-Received: by mail-oi1-x22e.google.com with SMTP id i4so4945106oih.4; Thu, 30 May 2019 08:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q8cPyfj1QhNNbJEzB5POI/kgr9PI9F94gMM1Ua+ARkE=; b=C3ev0QIxa8MuJhD6ABTWBX9+qsZTdNy4xbxInwLeCjJtezVSfSyp9AJWKeEBdtZZv3 UKt+kAXMUvb7z6kQVArF1A2ObLKrpoUos6eW186QBH92eRxXrNb9NcW9veqWf6oyW/ZP iusKpddujyXf4ewKE3rU3PBsLIe5aQey/ft886hWf+3uRqhOIiRs1NTEVYVL2y3x93GC rXAH0l9GLhorq24hjMYybxS3oJQtKS+LJh7Azl0sS8vec3Ha8D2k9Qob65MVCbdVM/5j GXIO59pGwUbXReISYOuOhBESu1EE89lngbWE7GV6LoPJR8aA43yFMOn/ZuZqte9ljU7c 4dTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q8cPyfj1QhNNbJEzB5POI/kgr9PI9F94gMM1Ua+ARkE=; b=BWW7tGvkb+QTYOGZrS8ixqRxLPR9z3Obn5fHzYyCuiQZIVA9CzWJJUO4Mm08oKA62K b86rO/cH26kGv7JpXXd14CFv1YC0Byk8AED6gGyhlT0HzhAYmCrZ37StdSVLfYvO6WPk mU7YEkXzq5enl19V3fWMOhBvE6gvixM6omkS9eIly5iDtMXao8fCl+c4dAJzT8KulEGw jzPMxLqEK6TfyCdf9c1/YFSubdfLwWj2RbGkgRRXjcH6CSXNq3XB5vtq3f5M/4AT1ohA 8z6X4U5m0vZv+FE8rdvTO093/T/0VK/FfXreulqXGdMHX9uuSurj1Q5T4bBhiHF+IQH4 sdqA== X-Gm-Message-State: APjAAAVBEANNwlyOwGsWHHVC323sm256gLBSZ5hgqJW74bgjJO2WpYQA rtEm94R9tt5p1hTLhThlltj54CU6GYjOSiZUNlJfzMHP X-Google-Smtp-Source: APXvYqwN98je0+4uV1D3ejlR31L019nm3fTXqqLUmTVUdvHlfPZB0/9YQa9tK93EUEs4KisByj+UjDyfrnQ50j/hWjA= X-Received: by 2002:aca:b1d4:: with SMTP id a203mr3035416oif.67.1559231680233; Thu, 30 May 2019 08:54:40 -0700 (PDT) In-Reply-To: <837ea8xc88.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237170 Archived-At: --0000000000006c44eb058a1cea74 Content-Type: text/plain; charset="UTF-8" On Thu, 30 May 2019 at 15:12, Eli Zaretskii wrote: > > From: Richard Copley > > Date: Thu, 30 May 2019 14:04:26 +0100 > > > > Emacs master fails to build in MinGW-W64 (MSYS2). > > > > The cause seems to be that since the configuration changes in commit > "Update from Gnulib" of Wed May 29 > > 16:33:51 2019 -0700, we now include pthread_signal.h > > (< > https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-libraries/winpthreads/include/pthread_signal.h > >) > > which does this: > > > > #define pthread_sigmask(H, S1, S2) 0 > > > > The result: > > > > gcc -c -mtune=generic -DUSE_CRT_DLL=1 -I /c/projects/emacs/nt/inc > -mtune=generic -MMD -MF > > deps/pthread_sigmask.d -MP -fno-common -O2 -I. -I../src -I. -I./../src > pthread_sigmask.c > > In file included from > C:/msys64/mingw64/x86_64-w64-mingw32/include/signal.h:10, > > from pthread_sigmask.c:20: > > pthread_sigmask.c:34:1: error: expected identifier or '(' before numeric > constant > > 34 | pthread_sigmask (int how, const sigset_t *new_mask, sigset_t > *old_mask) > > | ^~~~~~~~~~~~~~~ > > This doesn't happen to me, but I don't use MinGW64. > > Can you spot the part of the changes which caused us to include > pthread_signal.h? We shouldn't include any part of pthreads in the > Windows build. > Not beyond the obvious (it's the pthread_sigmask.m4 changes), no. Sorry. Prior to this change, lib\pthread_sigmask.c wasn't compiled at all AFAICS. --0000000000006c44eb058a1cea74 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, 30 May 2019 at 15:12, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Richard Copley <rcopley@gmail.com>
> Date: Thu, 30 May 2019 14:04:26 +0100
>
> Emacs master fails to build in MinGW-W64 (MSYS2).
>
> The cause seems to be that since the configuration changes in commit &= quot;Update from Gnulib" of Wed May 29
> 16:33:51 2019 -0700, we now include pthread_signal.h
> (<https://sourceforge.net/p/mingw-w64/mingw-w64/ci= /master/tree/mingw-w64-libraries/winpthreads/include/pthread_signal.h&g= t;)
> which does this:
>
> #define pthread_sigmask(H, S1, S2) 0
>
> The result:
>
> gcc=C2=A0 -c -mtune=3Dgeneric=C2=A0 =C2=A0-DUSE_CRT_DLL=3D1 -I /c/proj= ects/emacs/nt/inc -mtune=3Dgeneric=C2=A0 -MMD -MF
> deps/pthread_sigmask.d -MP -fno-common -O2 -I. -I../src -I. -I./../src= =C2=A0 pthread_sigmask.c
> In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/sig= nal.h:10,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 from pth= read_sigmask.c:20:
> pthread_sigmask.c:34:1: error: expected identifier or '(' befo= re numeric constant
>=C2=A0 =C2=A0 34 | pthread_sigmask (int how, const sigset_t *new_mask, = sigset_t *old_mask)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0| ^~~~~~~~~~~~~~~

This doesn't happen to me, but I don't use MinGW64.

Can you spot the part of the changes which caused us to include
pthread_signal.h?=C2=A0 We shouldn't include any part of pthreads in th= e
Windows build.

Not beyond the obvious (it's the pthread_sigmask.m4 changes), no. = Sorry.
Prior to this change, lib\pthread_sigmask.c wasn't compiled= at all=20 AFAICS.

--0000000000006c44eb058a1cea74--