From: Richard Copley <rcopley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs Development <emacs-devel@gnu.org>
Subject: Re: [w32] Build failure on master (pthread_sigmask.h)
Date: Thu, 30 May 2019 16:54:13 +0100 [thread overview]
Message-ID: <CAPM58oiQEf60DELR5-0wYU=eVVdWjp7QG7dOkNDDxo1K2PC0tQ@mail.gmail.com> (raw)
In-Reply-To: <837ea8xc88.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Thu, 30 May 2019 at 15:12, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Richard Copley <rcopley@gmail.com>
> > Date: Thu, 30 May 2019 14:04:26 +0100
> >
> > Emacs master fails to build in MinGW-W64 (MSYS2).
> >
> > The cause seems to be that since the configuration changes in commit
> "Update from Gnulib" of Wed May 29
> > 16:33:51 2019 -0700, we now include pthread_signal.h
> > (<
> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-libraries/winpthreads/include/pthread_signal.h
> >)
> > which does this:
> >
> > #define pthread_sigmask(H, S1, S2) 0
> >
> > The result:
> >
> > gcc -c -mtune=generic -DUSE_CRT_DLL=1 -I /c/projects/emacs/nt/inc
> -mtune=generic -MMD -MF
> > deps/pthread_sigmask.d -MP -fno-common -O2 -I. -I../src -I. -I./../src
> pthread_sigmask.c
> > In file included from
> C:/msys64/mingw64/x86_64-w64-mingw32/include/signal.h:10,
> > from pthread_sigmask.c:20:
> > pthread_sigmask.c:34:1: error: expected identifier or '(' before numeric
> constant
> > 34 | pthread_sigmask (int how, const sigset_t *new_mask, sigset_t
> *old_mask)
> > | ^~~~~~~~~~~~~~~
>
> This doesn't happen to me, but I don't use MinGW64.
>
> Can you spot the part of the changes which caused us to include
> pthread_signal.h? We shouldn't include any part of pthreads in the
> Windows build.
>
Not beyond the obvious (it's the pthread_sigmask.m4 changes), no. Sorry.
Prior to this change, lib\pthread_sigmask.c wasn't compiled at all AFAICS.
[-- Attachment #2: Type: text/html, Size: 2272 bytes --]
next prev parent reply other threads:[~2019-05-30 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 13:04 [w32] Build failure on master (pthread_sigmask.h) Richard Copley
2019-05-30 14:12 ` Eli Zaretskii
2019-05-30 15:54 ` Richard Copley [this message]
2019-05-30 18:44 ` Eli Zaretskii
2019-05-30 19:39 ` Richard Copley
2019-05-31 9:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM58oiQEf60DELR5-0wYU=eVVdWjp7QG7dOkNDDxo1K2PC0tQ@mail.gmail.com' \
--to=rcopley@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.