Re: Unbreak build on macOS

[Richard Copley <rcopley@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Tue, 9 Jul 2019 at 12:44, Mattias Engdegård <mattiase@acm.org> wrote:

> On macOS, lib/fcntl.h does
>
> #   define open rpl_open
>
> which now (f8ab90839f) gets included in src/font.c and breaks the line
>
>       font_object = driver_list->driver->open (f, entity, psize);
>
> As an immediate remedy, I added
>
> #undef open
>
> to src/font.c.
>
> In general, '#define open' is a rather unpleasant thing to do. Can we at
> least assume enough of C99 to do
>
> #define open(...) rpl_open (__VA_ARGS__)
>
> instead? That would permit font.c to use bracketing as an alternative
> countermeasure.
>

The build is currently (as of Mattias' fdea0e602b) broken on MS Windows. I
didn't
check which recent revision introduced the breakage; possibly also
f8ab90839f.

make[1]: Entering directory '/c/projects/emacs/src'
  CC       font.o
font.c: In function 'font_open_entity':
font.c:2909:40: error: 'const struct font_driver' has no member named 'open'
       font_object = driver_list->driver->open (f, entity, psize);
                                        ^~

[-- Attachment #2: Type: text/html, Size: 1577 bytes --]