From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#15322: VC log buffer scrolls itself Date: Wed, 19 Nov 2014 21:57:47 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1416434305 16142 80.91.229.3 (19 Nov 2014 21:58:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 21:58:25 +0000 (UTC) To: 15322@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 19 22:58:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrDGU-0007Lm-1j for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 22:58:18 +0100 Original-Received: from localhost ([::1]:60896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrDGT-0003zi-MC for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 16:58:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrDGK-0003zZ-Mz for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 16:58:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrDGE-00035c-Jc for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 16:58:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrDGE-00035L-HV for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrDGE-0007S1-5a for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Nov 2014 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15322-submit@debbugs.gnu.org id=B15322.141643427028621 (code B ref 15322); Wed, 19 Nov 2014 21:58:02 +0000 Original-Received: (at 15322) by debbugs.gnu.org; 19 Nov 2014 21:57:50 +0000 Original-Received: from localhost ([127.0.0.1]:38781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrDG1-0007RZ-TK for submit@debbugs.gnu.org; Wed, 19 Nov 2014 16:57:50 -0500 Original-Received: from mail-qa0-f54.google.com ([209.85.216.54]:62383) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrDFz-0007RR-TH for 15322@debbugs.gnu.org; Wed, 19 Nov 2014 16:57:48 -0500 Original-Received: by mail-qa0-f54.google.com with SMTP id i13so1109930qae.27 for <15322@debbugs.gnu.org>; Wed, 19 Nov 2014 13:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=AM3O5f3q/nF1WTGT4YPpbICuGh1Sup9dBFOy4nznW/s=; b=vXPcNAVnHbLfL7xVjvRnmsiBLAo0LrShbKFj6HFHvE7mkmuUzTPQsxKGgK93foNCw+ +5tuqW+rr+axtrIMZZuiAklODv40me8bmFCHVFpzTsbbeFdr8mgk6AVlFB2/AJ/K4BX0 i3DbRQ3DHdIpjcKX7f4W8o+JEhtBy2/5rQXxu5i2y504m7gwkGDVGlxjHrzdAFetScMh U2JdiEyi47zkYvVkJm55ZybYRSFtZJ8q2bozOb0J4F8xlPBEQqcgOOAzaw+ezXxjWRnC PZnD2URiI33RK/uxnA3bxlIB4ehqdsmg7DJ+X8p9vSAHgDGMHzgZaOkw6YKl4TV8ltfa jppA== X-Received: by 10.229.188.137 with SMTP id da9mr54485197qcb.6.1416434267443; Wed, 19 Nov 2014 13:57:47 -0800 (PST) Original-Received: by 10.229.214.67 with HTTP; Wed, 19 Nov 2014 13:57:47 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96288 Having re-read Stefan's comment: > > It's natural to select a particular > > revision when running vc-print-log from (say) vc-annotate, but for > > a plain `C-x v l', the user just wants to see "the log" and presumably > > doesn't care about which revision happens to be current. ... perhaps I was going too far, but a fix is still needed to stop point jumping to the beginning of the buffer when working-revision is null (at least in Subversion). I suggest not calling `goto-location-func' or setting vc-sentinel-movepoint when working-revision is null, in `vc-print-log-internal'. I also suggest a null working-revision be passed by `vc-print-root-log', by the same argument Stefan used for `vc-print-log'. On 19 November 2014 21:19, Richard Copley wrote: > Glenn's change doesn't completely solve the problem, because > `log-view-goto-rev' goes to the beginning of the buffer when REV is > null, and because all the other callers of `vc-log-internal' are also > affected. It would be better to comment out the `goto-location-func' > call in `vc-log-internal'. Having done that, you will find that you > need to comment out the following line as well, or point will move to > the end of the buffer instead. > > Note this is a duplicate of bug 6351.