all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Copley <rcopley@gmail.com>
To: 15322@debbugs.gnu.org
Subject: bug#15322: VC log buffer scrolls itself
Date: Wed, 19 Nov 2014 21:57:47 +0000	[thread overview]
Message-ID: <CAPM58oiD4-esPLPY_yh0sF0Bx1sV3LfTE=2nheJWcHu94CWQOA@mail.gmail.com> (raw)
In-Reply-To: <CAPM58oihZHEvrvCRNyZ_ZzjXnDodkLBQ2=6qzTJgutR_Ct=H+g@mail.gmail.com>

Having re-read Stefan's comment:

> > It's natural to select a particular
> > revision when running vc-print-log from (say) vc-annotate, but for
> > a plain `C-x v l', the user just wants to see "the log" and presumably
> > doesn't care about which revision happens to be current.

... perhaps I was going too far, but a fix is still needed to stop
point jumping to the beginning of the buffer when working-revision is
null (at least in Subversion). I suggest not calling
`goto-location-func' or setting vc-sentinel-movepoint when
working-revision is null, in `vc-print-log-internal'.

I also suggest a null working-revision be passed by
`vc-print-root-log', by the same argument Stefan used for
`vc-print-log'.

On 19 November 2014 21:19, Richard Copley <rcopley@gmail.com> wrote:
> Glenn's change doesn't completely solve the problem, because
> `log-view-goto-rev' goes to the beginning of the buffer when REV is
> null, and because all the other callers of `vc-log-internal' are also
> affected. It would be better to comment out the `goto-location-func'
> call in `vc-log-internal'. Having done that, you will find that you
> need to comment out the following line as well, or point will move to
> the end of the buffer instead.
>
> Note this is a duplicate of bug 6351.





  reply	other threads:[~2014-11-19 21:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 13:24 bug#15322: VC log buffer scrolls itself Paul Pogonyshev
2013-09-10 15:57 ` Eli Zaretskii
2013-09-10 16:04 ` Glenn Morris
2013-09-10 18:05   ` Glenn Morris
2013-09-10 18:30     ` Eli Zaretskii
2013-09-11  6:58       ` Paul Pogonyshev
2013-09-11 13:28         ` Eli Zaretskii
2013-09-12  6:26     ` Glenn Morris
2013-09-12  7:25       ` Paul Pogonyshev
2013-09-12 15:57         ` Glenn Morris
2013-09-12 19:09           ` Stefan Monnier
2013-09-12 19:30             ` Glenn Morris
2013-09-26  7:17               ` Paul Pogonyshev
2013-10-24  8:39                 ` Paul Pogonyshev
2013-10-24  8:49                   ` Andreas Schwab
2013-10-24 14:24                     ` Stefan Monnier
2014-08-02 16:04                       ` Paul Pogonyshev
2015-05-03  3:38                     ` Dmitry Gutov
2014-11-19 21:19 ` Richard Copley
2014-11-19 21:57   ` Richard Copley [this message]
2015-05-03  3:32     ` Dmitry Gutov
2015-05-03 14:34       ` Eli Zaretskii
2015-05-03 15:58         ` Dmitry Gutov
2015-05-03 16:32           ` Eli Zaretskii
2015-05-03 18:33             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM58oiD4-esPLPY_yh0sF0Bx1sV3LfTE=2nheJWcHu94CWQOA@mail.gmail.com' \
    --to=rcopley@gmail.com \
    --cc=15322@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.