From: Richard Copley <rcopley@gmail.com>
To: Filipe Silva <filipe.silva@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
james@jojojames.com, Emacs developers <emacs-devel@gnu.org>
Subject: Re: Native line numbers, final testing
Date: Tue, 4 Jul 2017 17:35:16 +0100 [thread overview]
Message-ID: <CAPM58ohq61OtNg9S-u7C7KMMZVH1D7qQGvN6iAcENeXLrYHicg@mail.gmail.com> (raw)
In-Reply-To: <CAEwkUWP2GkApBZ7NEL1yZmp4uqcume+4VrUe6nxqXB-SFeENwA@mail.gmail.com>
On 3 July 2017 at 16:24, Eli Zaretskii <eliz@gnu.org> wrote:
> Maybe with C-n/C-p people will expect what you expected in the case of
> line numbers (but I'd like to hear more opinions before I'm convinced
> to change the code to do that)
In my opinion it is important for the column position resulting from
C-n and C-p to be simple and predictable. I often rely on those
commands in keyboard macros. A simple example:
C-d 0 C-b C-n
C-d 1 C-b C-n
C-d 2 C-p C-p
This is supposed to change the character at point to 0 and the
characters in the corresponding column in the next two lines to 1
and 2.
I think that's a common use case and it won't work if
display-line-numbers is on ...
Or will it? I'm afraid I got quite confused trying to test this.
I think I found a different bug. Recipe:
Open xdisp.c and go to line 30, column 30.
Type "C-d C-n C-d C-n C-d C-n C-d C-n"
The first C-n goes to column 30 on line 31 as expected.
The 2nd C-n goes to column 29 on line 31 (expected column 30).
The 3rd C-n goes to column 28 on line 31 (expected 30 (or 29?)).
The 4th C-n goes to column 27 on line 31.
Not sure if this is the same on master.
On 4 July 2017 at 17:22, Filipe Silva <filipe.silva@gmail.com> wrote:
> hehe thaks Eli. Are you sure you pushed your commit?
>
> On Jul 4, 2017 12:44 PM, "Eli Zaretskii" <eliz@gnu.org> wrote:
>>
>> > From: Filipe Silva <filipe.silva@gmail.com>
>> > Date: Tue, 4 Jul 2017 11:50:23 -0300
>> > Cc: James Nguyen <james@jojojames.com>, Emacs developers
>> > <emacs-devel@gnu.org>
>> >
>> > In my testing, I found that when point is on line 1, everything is fine.
>> > As you go down line by line, the
>> > line-number-current-face skips ahead by one so by the time point is on
>> > line 10, line-number-current-line face
>> > is really acting on a number 9 lines below what should be the current
>> > line.
>>
>> Ha-ha, what a stupid bug! Thanks, now fixed.
next prev parent reply other threads:[~2017-07-04 16:35 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 14:49 Native line numbers, final testing Eli Zaretskii
2017-06-30 17:51 ` Alex
2017-06-30 18:20 ` Eli Zaretskii
2017-06-30 19:06 ` Alex
2017-06-30 19:55 ` Eli Zaretskii
2017-06-30 21:15 ` Alex
2017-07-01 8:00 ` Eli Zaretskii
2017-07-01 21:00 ` Alex
2017-07-02 2:40 ` Eli Zaretskii
2017-07-02 5:16 ` Alex
2017-07-02 15:10 ` Eli Zaretskii
2017-07-02 16:47 ` Stefan Monnier
2017-07-02 16:51 ` Eli Zaretskii
2017-07-02 17:38 ` Stefan Monnier
2017-07-02 19:27 ` Eli Zaretskii
2017-07-03 5:06 ` Alex
2017-07-03 15:24 ` Eli Zaretskii
2017-07-04 19:36 ` Alex
2017-07-05 17:39 ` Eli Zaretskii
2017-07-07 2:46 ` Alex
2017-07-07 6:19 ` Eli Zaretskii
2017-07-07 9:24 ` Eli Zaretskii
2017-07-08 20:51 ` Alex
2017-07-09 20:16 ` James Cloos
2017-07-09 21:45 ` Yuri Khan
2017-07-10 2:33 ` Eli Zaretskii
2017-07-10 7:09 ` Yuri Khan
2017-07-10 17:02 ` Eli Zaretskii
2017-07-10 2:31 ` Eli Zaretskii
2017-07-10 5:35 ` James Cloos
2017-07-10 17:00 ` Eli Zaretskii
2017-07-10 18:15 ` Filipe Silva
2017-07-10 18:18 ` Eli Zaretskii
2017-07-10 18:23 ` Filipe Silva
2017-07-10 18:32 ` James Cloos
2017-07-11 20:58 ` Alex
2017-07-11 21:18 ` Filipe Silva
2017-07-11 21:20 ` Filipe Silva
2017-07-11 21:37 ` Alex
2017-07-12 2:35 ` Eli Zaretskii
2017-07-12 2:53 ` Alex
2017-07-12 14:21 ` Eli Zaretskii
2017-07-12 17:22 ` Alex
2017-07-12 17:25 ` Alex
2017-07-12 18:38 ` Eli Zaretskii
2017-07-12 20:03 ` Alex
2017-07-13 2:38 ` Eli Zaretskii
2017-07-13 4:11 ` Alex
2017-07-13 15:56 ` Eli Zaretskii
2017-07-26 3:50 ` Alex
2017-07-26 14:42 ` Eli Zaretskii
2017-07-29 6:12 ` Alex
2017-07-29 7:01 ` Eli Zaretskii
2017-07-07 9:47 ` Eli Zaretskii
2017-07-07 9:49 ` Eli Zaretskii
2017-07-07 11:14 ` Filipe Silva
2017-07-07 12:21 ` Eli Zaretskii
2017-07-07 12:29 ` Eli Zaretskii
[not found] ` <CAEwkUWN8GkCyOiF4jEgKuZwJHhvMgJi9yVnvggRvu+Yddfp4qQ@mail.gmail.com>
2017-07-07 12:56 ` Filipe Silva
2017-07-01 1:59 ` Filipe Silva
2017-07-02 19:27 ` James Nguyen
2017-07-03 2:33 ` Eli Zaretskii
2017-07-03 3:22 ` James Nguyen
2017-07-03 15:58 ` Eli Zaretskii
2017-07-03 17:04 ` James Nguyen
2017-07-04 10:57 ` Filipe Silva
2017-07-04 11:00 ` Filipe Silva
2017-07-04 13:51 ` Kaushal Modi
2017-07-04 14:30 ` Eli Zaretskii
2017-07-04 14:32 ` Eli Zaretskii
2017-07-04 14:48 ` Filipe Silva
2017-07-04 14:50 ` Filipe Silva
2017-07-04 15:44 ` Eli Zaretskii
2017-07-04 16:22 ` Filipe Silva
2017-07-04 16:34 ` Filipe Silva
2017-07-04 16:35 ` Richard Copley [this message]
2017-07-04 16:44 ` Eli Zaretskii
2017-07-04 17:13 ` Richard Copley
2017-07-04 17:35 ` Filipe Silva
2017-07-04 17:48 ` Eli Zaretskii
2017-07-04 17:52 ` Stefan Monnier
2017-07-10 18:22 ` Filipe Silva
2017-07-10 20:28 ` Stefan Monnier
2017-07-04 17:47 ` Eli Zaretskii
2017-07-04 17:50 ` Alex
2017-07-04 18:24 ` Eli Zaretskii
2017-07-04 18:37 ` Richard Copley
2017-07-04 18:43 ` Eli Zaretskii
2017-07-05 20:24 ` Andy Moreton
2017-07-06 17:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPM58ohq61OtNg9S-u7C7KMMZVH1D7qQGvN6iAcENeXLrYHicg@mail.gmail.com \
--to=rcopley@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=filipe.silva@gmail.com \
--cc=james@jojojames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.