From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Last commit breaks macOS build Date: Thu, 5 Jan 2017 09:30:19 +0000 Message-ID: References: <103c5ca4-dba4-9cf1-1c15-535684235be9@alice.it> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1483608702 21701 195.159.176.226 (5 Jan 2017 09:31:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Jan 2017 09:31:42 +0000 (UTC) Cc: Emacs developers , Angelo Graziosi To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 05 10:31:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cP4OO-0004H0-Vv for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2017 10:31:29 +0100 Original-Received: from localhost ([::1]:44865 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cP4OT-0007cR-3q for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2017 04:31:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cP4Np-0007c8-LS for emacs-devel@gnu.org; Thu, 05 Jan 2017 04:30:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cP4No-0004g8-OL for emacs-devel@gnu.org; Thu, 05 Jan 2017 04:30:53 -0500 Original-Received: from mail-ua0-x231.google.com ([2607:f8b0:400c:c08::231]:34152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cP4No-0004fY-KN for emacs-devel@gnu.org; Thu, 05 Jan 2017 04:30:52 -0500 Original-Received: by mail-ua0-x231.google.com with SMTP id 34so333665715uac.1 for ; Thu, 05 Jan 2017 01:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eCdOEfPlRpgDiuLER3lgdJPWfompJ782x/rF39/KQxY=; b=e9hOj/7WxfTKGY9Iu67MShTUlrCuNUDXH79TlYxxrXC3f3+pZwWb0OLTfY8Wy90R99 0herJvhnVAz4qa0ivTE0MUXoOhUpsjG7LkdvM+LmcQ7sxz5fwn2hjXNOl9r2peKoMuZR MCHLCf8a2+54ek9xDZYOaTxmeYKeq9A7QA7sebbnHKjg5s0QTNYqjg2VVQG4nQPuwRcm 2fMVshX4J6tkQw2yf7WZvjI2kiihTIw1AQFp/IxfKza9LKfLJn40ILucd4ETjNaFLmqA JbrvZu4xLrohMqbx89dcieWBvacneQYCxxWx07IkxkWVRt/QQ8bB38J9Xzpb921O28nz Xg1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eCdOEfPlRpgDiuLER3lgdJPWfompJ782x/rF39/KQxY=; b=EBJSK1cRa7UUI8DtyGhv1LZfUl1xez3dYgnBHEC56rjJ79LAOg2S1oTveDpPJuyxBU /bbaXfVH+hdUSBc+65ttLroGGMRE73diRURQXC8dqW+kZPnuQzg27pEOiVkDboW4scT6 mhQ53OmJynrZIu8B0vdghcRmgIe2FCz/k4vhmQq8gsBsMXHjWvbnv1dXqc/8PrUA70wM CgIKXgd03AGVS68T+qeTWTpDLFC+oIPh6HvEgDojGdhJPtRn7PHiDnA27BMyCHm3ba1S RU/EmKc2XSrI822qtMWwAe3Ib64gPi2DXTYqBJUy0si6T5Z5rNXySiOvWBzG3on+QEdE 2tmA== X-Gm-Message-State: AIkVDXIJi3CGZMb5KSD/AzhmPEvfFD73NO3R3RBWYOkCxDv0fwBAPFUuJLidfqErwCreQqQD1yUVCcR4QLuDuQ== X-Received: by 10.159.36.209 with SMTP id 75mr3233361uar.51.1483608650024; Thu, 05 Jan 2017 01:30:50 -0800 (PST) Original-Received: by 10.176.71.29 with HTTP; Thu, 5 Jan 2017 01:30:19 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211119 Archived-At: On 5 January 2017 at 03:21, Paul Eggert wrote: > Angelo Graziosi wrote: > >> Interfering nt/gnulib.mk from lib/gnulib.mk ... > > > Did it really say "Interfering"? :-) > >> sed: 46: "This is of m...": command c expects \ followed by text >> >> and the 'configure' is not created... > > > This is caused by our recent attempt to better-automate MS-Windows builds. I > fixed one nonportable construct, but evidently there are others. > > It's time to break out a bigger hammer. Please try the attached patch. I > have tested it on Fedora, but not on MS-Windows and so have not installed it > yet. Hi Paul, In MSYS2 on Windows, with the patch I get this error: gcc -DHAVE_CONFIG_H -I. -I../../repo/emacs/lib -I../src -I../../repo/emacs/src -march=native -mtune=native -D_WIN32_WINNT=_WIN32_WINNT_WIN7 -DUSE_CRT_DLL=1 -I /g/emacs/build/../repo/emacs/nt/inc -fno-common /* -W... */ -Og -g -ggdb -MT set-permissions.o -MD -MP -MF .deps/set-permissions.Tpo -c -o set-permissions.o ../../repo/emacs/lib/set-permissions.c ../../repo/emacs/lib/set-permissions.c: In function 'set_acls': ../../repo/emacs/lib/set-permissions.c:500:6: error: #error Must have acl_delete_def_file (see POSIX 1003.1e draft 17). # error Must have acl_delete_def_file (see POSIX 1003.1e draft 17). ^~~~~ ../../repo/emacs/lib/set-permissions.c:539:13: warning: implicit declaration of function 'acl_delete_def_file' [-Wimplicit-function-declaration] ret = acl_delete_def_file (name); ^~~~~~~~~~~~~~~~~~~ ../../repo/emacs/lib/set-permissions.c:539:7: warning: nested extern declaration of 'acl_delete_def_file' [-Wnested-externs] ret = acl_delete_def_file (name); ^~~ Without the patch, set-permissions.c isn't compiled.