From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sat, 16 Sep 2017 09:34:42 +0100 Message-ID: References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> <83ingnq01t.fsf@gnu.org> <83fubrpxsv.fsf@gnu.org> <83r2v9masw.fsf@gnu.org> <83efr8mje5.fsf@gnu.org> <83o9qbkuxm.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1505550923 31972 195.159.176.226 (16 Sep 2017 08:35:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 08:35:23 +0000 (UTC) Cc: Fabrice Popineau , Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 10:35:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt8ZJ-00089J-Qm for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 10:35:17 +0200 Original-Received: from localhost ([::1]:56407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8ZR-0003gJ-7h for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 04:35:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8ZH-0003dh-HR for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:35:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dt8ZG-0006Jf-Ma for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:35:15 -0400 Original-Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:54773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dt8ZF-0006IY-AK; Sat, 16 Sep 2017 04:35:13 -0400 Original-Received: by mail-vk0-x22c.google.com with SMTP id c19so1924531vke.11; Sat, 16 Sep 2017 01:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8tDnCHe/xvgF99VVpjB5lSvSs3pyml/6IZZhjAgA9RY=; b=Lee9BPCAxqoZGt33W+YRTuPyks9pElud3EtsAwEkpNDyKChja0FGF62cmuh/y32J4C hzdl40WUFldsYJhPfacxanHZ7F1oGPfVW9DjhZ75qVajktJgOZ2rPceoGrr5qZsWt8lC F2MBFTFIsj1RQEUDqpEWd6yWzkuma0/g3sys35N9GMltiHN9AW0ucE3vF5SNDtKuyLQs lzVH2GKdbTIq0lXA69aq5iMtmLNCYEZM12yME4rXCiMJnWmS6N6A9VMAt9ljcL1rYMc/ 7lgRiIp6HNluvOa2ynKvTnOb/sG9ODsk9otnDzsZWpnKrWhpCaaDEYNuWf2ZbluxaF4L 38ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8tDnCHe/xvgF99VVpjB5lSvSs3pyml/6IZZhjAgA9RY=; b=n11VCD/QpDy7OgJ4O1rETrDB1eStbznq5MEbYpsq7UI9WtJjtozDW0Dqfr4aFygbwz Th/15rQrnJGDd/m5jcR4k1eI161ya28rDltz1f1wIKkWibnA9SiiP4wqpX7p4ZZYQxV+ ENjXXjH0UEQvDvz3RDlByuo06JTrfUf6o0JohY+LG9MBp5UdJDnVK6CINc3RgTEiHGya 55Pr7T5Kp6lbc5k+1nuRxGG0s3D95tBO9W4RETN5oexLj0ERYeD6iTiKMUS7qo5v3MxY jJlQx514FEHvAhpkRYExdmrQ87LdtdXov8A2NMXhc9TtnflVAEmNH9Wj9HDn6u9qWAI5 WdBg== X-Gm-Message-State: AHPjjUgmcaVWR83vBBMa5OpLUO8oEcyDXubwB2h67wUwkPigrcrbdzYy h2VhMSTAYVMF5ARXr7HdJqrLpdeijsSoos/1c7A= X-Google-Smtp-Source: AOwi7QDrkYKG+PN4NLfe4FCKCiF0mmmUc/slDe8mUPJrPBXDP/PT4bfo8K0VRxV++qs9DDNAAzzRxYqkFcUKaxRrfuc= X-Received: by 10.31.165.196 with SMTP id o187mr20945506vke.103.1505550912410; Sat, 16 Sep 2017 01:35:12 -0700 (PDT) Original-Received: by 10.159.41.102 with HTTP; Sat, 16 Sep 2017 01:34:42 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c05::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218348 Archived-At: On 16 September 2017 at 09:19, Richard Copley wrote: > On 16 September 2017 at 07:40, Eli Zaretskii wrote: >> >> If you look at the beginning of w32.c, you will see that we include >> string.h before we #undef strerror. The header nt/inc/ms-w32.h >> #define's strerror to sys_strerror, so the inclusion of string.h >> should have supplied the prototype for sys_strerror. Why doesn't it >> do that in MinGW64? Does some system header #undef strerror too >> early? > > I see, thanks. No, there's no #undef. We end up including string.h before > ms-w32.h (w32.c includes io.h and io.h unconditionally includes string.h). Also beware fcntl.h includes io.h. But string.h is not included before ms-w32.h otherwise than via fcntl.h and io.h.