all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Copley <rcopley@gmail.com>
To: 13730@debbugs.gnu.org
Subject: bug#13730: 24.3.50; Diff from Bzr-Log-View not highlighted
Date: Sun, 17 Feb 2013 05:27:52 +0000	[thread overview]
Message-ID: <CAPM58oh1_5brjMKCQ7EsWXdffpmCknj5CSco_U9-ivNNz5Y0Kg@mail.gmail.com> (raw)
In-Reply-To: <CAPM58og6OcvV7j2zHYT7UUvYa5-hxqyKf6vvMhf_GgE7wjXNXw@mail.gmail.com>

> Unfortunately font-lock gets turned off in a change-major-mode-hook
> function (font-lock-change-mode in "font-core.el"), which doesn't seem
> to have been anticipated.

Sorry, that's a red herring, it has nothing to do with font-lock-change-mode.

Now that turning a minor mode off during a major mode function
disables the corresponding global minor mode, turning the minor mode
back on should re-enable the global minor mode, as in the patch below.

(In Emacs trunk, whitespace mode is turned on in diff mode by a
directory-local variable. Thus the function `whitepace-turn-on' is
called from inside the diff-mode major mode function; but
`whitespace-turn-on' turns font lock off and turns it back on again.)

=== modified file 'lisp/emacs-lisp/easy-mmode.el'
*** lisp/emacs-lisp/easy-mmode.el	2013-02-15 20:01:51 +0000
--- lisp/emacs-lisp/easy-mmode.el	2013-02-17 05:18:06 +0000
***************
*** 461,468 ****
         ;; kill-all-local-variables.
         (defvar-local ,disable-MODE nil)
         (defun ,MODE-disable-in-buffer ()
! 	 (unless ,mode
! 	   (setq ,disable-MODE t)))
         (put ',MODE-disable-in-buffer 'definition-name ',global-mode))))

  ;;;
--- 461,467 ----
         ;; kill-all-local-variables.
         (defvar-local ,disable-MODE nil)
         (defun ,MODE-disable-in-buffer ()
!          (setq ,disable-MODE (not ,mode)))
         (put ',MODE-disable-in-buffer 'definition-name ',global-mode))))

  ;;;





  reply	other threads:[~2013-02-17  5:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 12:10 bug#13730: 24.3.50; Diff from Bzr-Log-View not highlighted rcopley
2013-02-17  1:16 ` Glenn Morris
     [not found]   ` <CAPM58ohKAudLVMs2YLtpF5DLAyFqVJR8Bv_iYg30+GDy1OBuWA@mail.gmail.com>
2013-02-17  3:38     ` Richard Copley
2013-02-17  5:27       ` Richard Copley [this message]
2013-02-17  6:40         ` Glenn Morris
2013-02-19 22:04           ` Richard Copley
2013-02-19 22:07             ` Glenn Morris
2013-02-17  6:36     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPM58oh1_5brjMKCQ7EsWXdffpmCknj5CSco_U9-ivNNz5Y0Kg@mail.gmail.com \
    --to=rcopley@gmail.com \
    --cc=13730@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.